From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 63731@debbugs.gnu.org, Steven Allen <steven@stebalien.com>
Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate
Date: Fri, 26 May 2023 10:34:02 +0200 [thread overview]
Message-ID: <87v8gfmqyt.fsf@gmail.com> (raw)
In-Reply-To: <83pm6nlhll.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 May 2023 09:41:42 +0300")
Disclaimer: I havenʼt looked at the patch yet
>>>>> On Fri, 26 May 2023 09:41:42 +0300, Eli Zaretskii <eliz@gnu.org> said:
>> From: Steven Allen <steven@stebalien.com>
>> Date: Thu, 25 May 2023 20:18:02 -0700
>>
>> This patch imports the full list from unicode.org instead of
>> special-casing a few characters as was done previously.
>>
>> With this patch, '👍️' (1F44D FE0F) should look the same as '👍' (1F44D).
>> Without it, it will look like '👍️'.
>>
>> As a simple regression test, '✔' (2714) should still as "text" while '✔️'
>> (2714 FE0F) should still display as an emoji.
>>
>> Fixes https://github.com/alphapapa/ement.el/issues/137
>>
>> NOTE: I'm not a Unicode expert, nor do I understand how Emacs handles
>> Unicode (beyond what was required to implement this patch). But this
>> patch appears to work and I can't find any regressions.
Eli> AFAIU, this change will populate composition-function-table for many
Eli> "normal" characters, including ASCII digits and symbol/punctuation
Eli> characters from the 0x2xxx blocks. E.g., after you build Emacs with
Eli> this patch, what do the following evaluations yield:
Eli> M-: (aref composition-function-table ?0) RET
Eli> M-: (aref composition-function-table #x2122) RET
Eli> If they yield non-nil values, it could mean dramatic slowdown of
Eli> redisplay with these characters. Which is precisely what we wanted to
Eli> avoid when we made the decision which parts of the Unicode-defined
Eli> Emoji sequences to support in Emacs, and how to arrange for that
Eli> support to work.
Yes. We donʼt want to do composition checks for ASCII if we can avoid it.
Eli> The issue you site is strange: according to the "C-u C-x =" display
Eli> there, Emacs did compose #x1f44d with VS-16 using the Noto Color Emoji
Eli> font, so I don't quite understand why VS-16 is then also shown as an
Eli> empty rectangle. On my system Noto Color Emoji doesn't work, and "C-u
Eli> C-x =" says this instead:
Eli> Composed with the following character(s) "️" using this font:
Eli> harfbuzz:-outline-Noto Emoji-regular-normal-normal-mono-15-*-*-*-c-*-iso10646-1
Eli> by these glyphs:
Eli> [0 1 128077 422 19 2 17 14 2 nil]
Eli> [0 1 65039 3 19 0 1 0 1 [0 0 0]]
Eli> with these character(s):
Eli> ️ (#xfe0f) VARIATION SELECTOR-16
Eli> which explains why I see two glyphs and not 1. But in the display
Eli> shown in the above issue, I see
Eli> Composed with the following character(s) "️" using this font:
Eli> ftcrhb:-GOOG-Noto Color Emoji-regular-normal-normal-*-18-*-*-*-m-0-iso10646-1
Eli> by these glyphs:
Eli> [0 1 128077 569 22 0 23 17 5 [0 0 136]]
Eli> with these character(s):
Eli> ️ (#xfe0f) VARIATION SELECTOR-16
Eli> which describes only one glyph, not two. So the result ought to be
Eli> what you expect.
I see the emoji followed by a blank box with Noto Color Emoji here. I
donʼt yet understand why.
Eli> Robert, what am I missing here?
1F44D FE0F is a valid sequence according to tr51
(aref composition-function-table #x1f44d)
=> (["\\(?:👍[🏻-🏿]\\)" 0 compose-gstring-for-graphic])
which means that the composition is being triggered by this entry:
(aref composition-function-table #xfe0f)
=> (["\\c.\\c^+" 1 compose-gstring-for-graphic] [nil 0 compose-gstring-for-graphic])
(time passes)
Ugh. The following fixes it for me:
diff --git a/lisp/composite.el b/lisp/composite.el
index fb8b76114f4..af86d1436d3 100644
--- a/lisp/composite.el
+++ b/lisp/composite.el
@@ -756,7 +756,7 @@ compose-gstring-for-dotted-circle
;; Allow for bootstrapping without uni-*.el.
(when unicode-category-table
(let ((elt `([,(purecopy "\\c.\\c^+") 1 compose-gstring-for-graphic]
- [nil 0 compose-gstring-for-graphic])))
+ )))
(map-char-table
#'(lambda (key val)
(if (memq val '(Mn Mc Me))
Although the following is less invasive:
diff --git a/lisp/composite.el b/lisp/composite.el
index fb8b76114f4..333428f008a 100644
--- a/lisp/composite.el
+++ b/lisp/composite.el
@@ -762,6 +762,11 @@ compose-gstring-for-dotted-circle
(if (memq val '(Mn Mc Me))
(set-char-table-range composition-function-table key elt)))
unicode-category-table))
+ ;; for Emoji presentation selector
+ (set-char-table-range
+ composition-function-table
+ #xFE0F
+ `([,(purecopy "\\c.\ufe0f") 1 compose-gstring-for-graphic]))
;; for dotted-circle
(aset composition-function-table #x25CC
`([,(purecopy ".\\c^") 0 compose-gstring-for-dotted-circle]))
Didnʼt we conclude that composition had some issues with multiple
entries for the same codepoint if there was a mix for forward and
backward looking regexp?
Robert
--
next prev parent reply other threads:[~2023-05-26 8:34 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 3:18 bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Steven Allen
2023-05-26 6:41 ` Eli Zaretskii
2023-05-26 8:34 ` Robert Pluim [this message]
2023-05-26 8:46 ` Eli Zaretskii
2023-05-26 11:14 ` Robert Pluim
2023-05-26 12:06 ` Eli Zaretskii
2023-05-26 14:02 ` Robert Pluim
2023-05-26 14:55 ` Eli Zaretskii
2023-05-26 15:25 ` Robert Pluim
2023-05-26 15:52 ` Eli Zaretskii
2023-05-26 16:24 ` Robert Pluim
2023-05-26 17:27 ` Eli Zaretskii
2023-05-26 17:35 ` Robert Pluim
2023-05-26 18:05 ` Eli Zaretskii
2023-05-28 11:43 ` Robert Pluim
2023-05-28 12:44 ` Eli Zaretskii
2023-05-26 17:43 ` Eli Zaretskii
2023-05-28 10:29 ` Robert Pluim
2023-05-28 12:37 ` Eli Zaretskii
2023-05-28 11:57 ` Robert Pluim
2023-05-28 12:47 ` Eli Zaretskii
2023-05-29 10:44 ` Robert Pluim
2023-05-29 13:58 ` Eli Zaretskii
2023-05-29 14:43 ` Robert Pluim
2023-05-29 14:55 ` Eli Zaretskii
2023-05-29 16:13 ` Robert Pluim
2023-05-29 17:18 ` Eli Zaretskii
2023-05-30 7:25 ` Robert Pluim
2023-05-30 12:10 ` Eli Zaretskii
2023-05-30 13:30 ` Robert Pluim
2023-05-30 16:32 ` Eli Zaretskii
2023-05-31 16:11 ` Robert Pluim
2023-05-31 16:18 ` Eli Zaretskii
2023-06-01 12:43 ` Eli Zaretskii
2023-06-01 13:30 ` Robert Pluim
2023-06-01 16:10 ` Eli Zaretskii
2023-06-01 16:34 ` Robert Pluim
2023-06-02 8:15 ` Robert Pluim
2023-06-02 12:06 ` Eli Zaretskii
2023-06-02 12:25 ` Robert Pluim
2023-06-02 12:58 ` Eli Zaretskii
2023-06-02 13:58 ` Robert Pluim
2023-06-03 5:36 ` Eli Zaretskii
2023-06-05 13:08 ` Robert Pluim
2023-06-05 13:12 ` Eli Zaretskii
2023-06-05 13:31 ` Eli Zaretskii
2023-06-05 14:06 ` Robert Pluim
2023-06-05 13:36 ` Robert Pluim
2023-06-05 13:47 ` Eli Zaretskii
2023-06-05 14:27 ` Robert Pluim
2023-06-05 15:35 ` Eli Zaretskii
2023-06-05 15:57 ` Robert Pluim
2023-06-05 16:20 ` Robert Pluim
2023-06-05 16:41 ` Eli Zaretskii
2023-06-06 7:24 ` Robert Pluim
2023-06-05 16:39 ` Eli Zaretskii
2023-06-06 7:28 ` Robert Pluim
2023-06-06 11:53 ` Eli Zaretskii
2023-05-26 15:06 ` Steven Allen
2023-05-26 15:29 ` Robert Pluim
2023-05-26 16:03 ` Steven Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8gfmqyt.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=63731@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=steven@stebalien.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).