From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Fri, 21 Jul 2023 18:08:14 +0200 Message-ID: <87v8edb635.fsf@gmx.de> References: <87o7k6pmk3.fsf@localhost> <834jly351p.fsf@gnu.org> <87lefapkdx.fsf@localhost> <831qh230h5.fsf@gnu.org> <87wmyu8mi0.fsf@localhost> <83wmyu1l1k.fsf@gnu.org> <87fs5hemi1.fsf@gmx.de> <83edl11qzn.fsf@gnu.org> <874jlxebz5.fsf@gmx.de> <87lef9mqio.fsf@localhost> <87edl1scbw.fsf@gmx.de> <87fs5hmp6i.fsf@localhost> <87cz0lmoxy.fsf@localhost> <83v8edzb31.fsf@gnu.org> <87r0p1cta3.fsf@gmx.de> <87pm4ll7ox.fsf@localhost> <87a5vpcmc7.fsf@gmx.de> <878rb9l1f5.fsf@localhost> <87zg3pb6yt.fsf@gmx.de> <83zg3p9s39.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23750"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dmitry@gutov.dev, yantar92@posteo.net, 64735@debbugs.gnu.org, sbaugh@janestreet.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 21 18:09:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMshA-0005uN-Re for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jul 2023 18:09:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMsgn-0004DK-My; Fri, 21 Jul 2023 12:09:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMsgg-0004A1-O7 for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 12:09:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMsgg-00079t-GG for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 12:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMsgg-0006LN-B3 for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 12:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jul 2023 16:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.168995571024322 (code B ref 64735); Fri, 21 Jul 2023 16:09:02 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 21 Jul 2023 16:08:30 +0000 Original-Received: from localhost ([127.0.0.1]:34644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMsg9-0006KE-IX for submit@debbugs.gnu.org; Fri, 21 Jul 2023 12:08:29 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:51917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMsg7-0006Jx-EZ for 64735@debbugs.gnu.org; Fri, 21 Jul 2023 12:08:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1689955695; x=1690560495; i=michael.albinus@gmx.de; bh=i56p7OaV5d+8wLROiMiof/k1K+E6k0Y+/BJk4dUv2SM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=GFDqnHCAI2xAYKCSUaakDkwdKX6sp9nevWyu8q21uc2wRFSYKn9vm9dzmKg8INvYww3OAM4 l2d69alue1SsZ71Ob2H9OT4u9gEv5s3vz7agmBGDItBYNxo1IxKsc9iAYaU5q2iQo7kQ3mF1p MpeivcLXUL0NCb4X4bZi0zv2HOHxnl+VxKPsX5OxmwUbhFgaztZdwdwPHODE7dRYc5FhKRwdI EEpfAYsU/ym6a8Lq4TP1IRp3fI76muw1/5Y+lIzSChwUq5DfMwBXo/exVP3ZHrvsEFWAtLQ2U Yy7tEqXO/sz/29VPTilFPIcIGpiU9VdNGpswSMk7LfewbojExK3w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.27]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M26rD-1qKwjO2mM5-002WQl; Fri, 21 Jul 2023 18:08:15 +0200 In-Reply-To: <83zg3p9s39.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Jul 2023 18:55:54 +0300") X-Provags-ID: V03:K1:S5cxs2b/fHV5MePDrlvge3joUI0ZN4SaKncPOSaWddIY3MtwAsd 9z66YVfkYExDiuLkcA/snL+Pc3BA0Tjg6/M8zAhY1gVa1Frd55KX5EK2dmDG6rkVI0qiW5K M5RK5JPHT9u5Yd013azVcAsxAhSW++6hOKifDeZD7oRGUTmaYAxXqr5kD9dCoaPuYvdUnLA FQCoKzPd/IUPiZKedutrg== UI-OutboundReport: notjunk:1;M01:P0:s9Y0A2U2xvI=;R4MPshp++0+Ho3ys5ffaLRiRRU1 PY17MSZ50DOmogQ2b6/D2m7lZqScJLoMaWnNfyggSYh8RaL9wtv4YY85I0S0ZNkRFVRj+sRfJ /CDvV9Krwp2toxGATEbytsFsX6eXq7eERrK2VL1D5eu7hZ/bwDUhIk2wLUnxXWnoaiJaa3Ucs TfzoWkJSrtrHepN2dVat0UGyTcHj1QZiljvuEOo0/Bbf/yes7VFdF+1HWHAmOQIHSz28suYoO 6GdmS71gjc3cq7kdFDOMTg4+zRTd5jePbYuKd8GDLwkrHO8IX3aF0i/AirlKw2qnpURhCa7A+ ye3AaYxmN3et+fIXvAhZqATfH2+58qPu27o9Gp+7OWkwWVv3LtxL/JwZJQTJkEIDglh0nGOR6 LuTty/jp3ZUZjb6my0U+NSPU8tmRjgin98kKU106tK/rRDCycj38W3xB/fvSU8bB8/UK+btdY lrj3kwxbd3Pucc6mGQ6CJ6jgpheSvFBJUcJ04lUYBzPTOO9OdponBUQBrRVtIQxf/BbE0f/Ks mj52w0lie2Ekoc1MMgi5zzzo3UIMkZ4O9a7LcXv61tSMicUQzczysR/K5ke9qbGMD4R7Qle96 u/gQ7TvEzhGeUZa3T8T0fSdbrONff4ebLAAXnM/0HzrfSKicvUwhWJoczzYiZ5F9o48SATO67 XUyOq/akgB5hfz2srFjQuFwZEwBt8LHoTXPg+Aml4aK2u732blQE1K3rgN/PfzsFImOHqGffM IW2iOq7UzM+sEtVIiWhYoH9sQu4WxpGVN//CMPlmdfK50zPrGqYTqXTnWl8wNr3IUpTVIOk+ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265739 Archived-At: Eli Zaretskii writes: Hi Eli, >> > (length (directory-files-recursively "~/Git" "")) >> > ;; =3D> 113628 >> > (benchmark-run-compiled 1 (directory-files-recursively "~/Git" "")) >> > ;; =3D> (1.597328425 1 0.47237324699997885) >> > (benchmark-run-compiled 1 (let (file-name-handler-alist) (directory-f= iles-recursively "~/Git" ""))) >> > ;; =3D> (1.0012111910000001 1 0.4860752540000135) >> > (benchmark-run-compiled 1 (without-remote-files (directory-files-recu= rsively "~/Git" ""))) >> > ;; =3D> (1.147276594 1 0.48820330999998873) >> > (inhibit-remote-files) >> > (benchmark-run-compiled 1 (directory-files-recursively "~/Git" "")) >> > ;; =3D> (1.054041615 1 0.4141427399999884) >> >> Thanks a lot! These figures show, that both without-remote-files and >> inhibit-remote-files are useful. Of course this shouldn't stop us to >> find further approaches for performance optimizations. >> >> I'll wait for some days whether there's opposition, before installing >> them in master. > > Can you spell out what you intend to install? I intend to install without-remote-files and inhibit-remote-files, which I have shown upthread. Plus documentation. > The figures provided in this thread indicate speedups that are modest > at best, so I'm not sure they justify measures which could cause > problems (if that indeed could happen). >> > (benchmark-run-compiled 1 (directory-files-recursively "~/Git" "")) >> > ;; =3D> (1.597328425 1 0.47237324699997885) 1.59 seconds. >> > (benchmark-run-compiled 1 (without-remote-files (directory-files-recu= rsively "~/Git" ""))) >> > ;; =3D> (1.147276594 1 0.48820330999998873) 28% performance boost. >> > (inhibit-remote-files) >> > (benchmark-run-compiled 1 (directory-files-recursively "~/Git" "")) >> > ;; =3D> (1.054041615 1 0.4141427399999884) 34% performance boost. I believe it is more than a modest speedup. And without-remote-files mitigates problems which could happen due to let-binding file-name-handler= -alist. Best regards, Michael.