From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#65055: 30.0.50; save-place-abbreviation-file-names :set fails for saveplace-pdf-view places Date: Fri, 04 Aug 2023 23:43:56 +0530 Message-ID: <87v8du65gb.fsf@gmail.com> References: <87edki4wdz.fsf@gmail.com> <83cz02vgst.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6906"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 65055@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 04 20:15:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRzKf-0001Xw-RO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Aug 2023 20:15:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRzKJ-0002tc-Sn; Fri, 04 Aug 2023 14:15:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRzKI-0002lA-1G for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 14:15:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRzKH-0002rm-Nv for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 14:15:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRzKH-0001kn-Ih for bug-gnu-emacs@gnu.org; Fri, 04 Aug 2023 14:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Aug 2023 18:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65055 X-GNU-PR-Package: emacs Original-Received: via spool by 65055-submit@debbugs.gnu.org id=B65055.16911728636670 (code B ref 65055); Fri, 04 Aug 2023 18:15:01 +0000 Original-Received: (at 65055) by debbugs.gnu.org; 4 Aug 2023 18:14:23 +0000 Original-Received: from localhost ([127.0.0.1]:54821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRzJe-0001jW-Lk for submit@debbugs.gnu.org; Fri, 04 Aug 2023 14:14:22 -0400 Original-Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:48620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRzJc-0001jJ-UU for 65055@debbugs.gnu.org; Fri, 04 Aug 2023 14:14:21 -0400 Original-Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-687087d8ddaso2168109b3a.1 for <65055@debbugs.gnu.org>; Fri, 04 Aug 2023 11:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691172855; x=1691777655; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5UUI3jTQRb9JXPcz1cWkW8uj/gcZi2lB9XXnF4gD0po=; b=Na5htC47zH3e1RXmbeH++A77zTuBEqaYZbsh5lwTNFgJ2Q7viMsmgepR7sdL5x3box ya42GOAgEgy/bp+x7RDQWcS90GIf6XNKLc6aRPuoNf9Ra3u3mVEMBxC6TIBySzx4E5yD CEiJZQHWlaaxyK+oq4kIxb1pG4bjsF0zwtlhdatuqpnVPlbGf8QQl9CQd/RPF695SJ0H /p9ryVOWUYIMvJ8ckQDyU8EcII2cW03krcv7qZFgibI96qb6c8/oVinZ8kjJcBsOy0+T omv6hlrLS/2ryR7twNPAEEQekqbpOgMp+CmXF0nhJPjlOR/OiVGkgR8I7MalJWm5wLWO D7CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691172855; x=1691777655; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5UUI3jTQRb9JXPcz1cWkW8uj/gcZi2lB9XXnF4gD0po=; b=aFwGyXWzCJpoMMCJKU5wNpMBTCQVqeftKfvowB7BzpBURd+BwcdWKBcWGdaye3U2VC 8rAkE6bdD+yXidrwwnai0rcwHvbETfg63v6icAzqN3kbj2V39L5Hbw5k2qhhd6mMSTdR aWwmKoIvpgr5ZTEIWLLrSCvTpjgq0vkSbxP0Gw048oel/+m8EAAKMt4kxe4LtH71Syrv CUwIbPipdztSLJeCht03MZV8palIN9BxQzxmLT/wTZULnXSe8YHCg/EzkCy5FWbfp6zR sdAOBI8sFhBalcYua7+8X+TJTBK1WOizCkb/8P+xZ7SYRiyE5TKQFt4gW1XKqs6FbH8N NpuA== X-Gm-Message-State: AOJu0Yz2/tjMhWX6PONBAWJ5r3qBs3kmGLg/YXEfzpXkqadPdBSq9E/9 Q9Kqp7UresNX0mfpk7CHbk4dUPW9Q64WIg== X-Google-Smtp-Source: AGHT+IG2DX6+lFyJbkfdt4ODmPWP9m6cnHY548GRp/9NIqmBLXI1LWulWCf7/8BFruBh5YqrUbNVRA== X-Received: by 2002:a05:6a20:6a28:b0:135:293b:9b14 with SMTP id p40-20020a056a206a2800b00135293b9b14mr3045966pzk.55.1691172855049; Fri, 04 Aug 2023 11:14:15 -0700 (PDT) Original-Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id j3-20020aa78003000000b00678afd48250sm1841799pfi.218.2023.08.04.11.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Aug 2023 11:14:14 -0700 (PDT) In-Reply-To: <83cz02vgst.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Aug 2023 20:49:38 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266706 Archived-At: [=E0=AE=B5=E0=AF=86=E0=AE=B3=E0=AF=8D=E0=AE=B3=E0=AE=BF =E0=AE=86=E0=AE=95= =E0=AE=B8=E0=AF=8D=E0=AE=9F=E0=AF=8D 04, 2023] Eli Zaretskii wrote: >> From: Visuwesh >> Date: Fri, 04 Aug 2023 21:45:04 +0530 >>=20 >> saveplace-pdf-view package [1] uses a custom "place" format to save and >> restore the last position for PDF files viewed via doc-view package. >>=20 >> One such "place" is >>=20 >> ("/home/viz/tmp/piron1976.pdf" >> (pdf-view-bookmark "piron1976.pdf" >> (filename . "~/tmp/piron1976.pdf") >> (position . 1) >> (last-modified 25805 5369 546130 641000) >> (page . 2) >> (slice) >> (size . fit-width) >> (origin) >> (handler . pdf-view-bookmark-jump-handler))) >>=20 >> This fails with the following backtrace because=20 >> (cdr (pdf-view-bookmark ...) is a list, > > I don't understand: the valid format of save-place-alist is documented > in its doc string, so this looks like a bug in saveplace-pdf-view > package? Or what am I missing? Unfortunately, that's only half the story. save-place-alist can also have elements such as ("SOME-DIRECTORY" (dired-filename . "SOME-FILENAME")) to save the place for dired buffers. This is why the :set function of the user option checks if second element of above place is a list and also changes the "SOME-FILENAME" to be abbreviated/expanded. But instead of checking if the second element of the place's cdr is a string, the :set function simply assumes that it will be always be a string. This is not wrong as such since that's the only allowed format as far as core Emacs is concerned but I think having the check in place would help expand the save-place-alist format as the user desires.