From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#65380: [PATCH] Add command to copy contents in a diff-mode buffer Date: Sat, 19 Aug 2023 19:30:27 +0000 Message-ID: <87v8davnho.fsf@posteo.net> References: <87wmxrwe6h.fsf@posteo.net> <83o7j3z4wm.fsf@gnu.org> <87pm3jwboc.fsf@posteo.net> <83lee7z3xs.fsf@gnu.org> <87jztrvxx2.fsf@posteo.net> <83r0nyyhlz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36203"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65380@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 19 21:31:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXRfM-0009GC-Hh for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Aug 2023 21:31:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXRf5-0003Gx-EG; Sat, 19 Aug 2023 15:31:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXRf3-0003GS-TF for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 15:31:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXRf3-0004WV-LB for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 15:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXRf4-00007V-Aw for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 15:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65380 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65380-submit@debbugs.gnu.org id=B65380.1692473446437 (code B ref 65380); Sat, 19 Aug 2023 19:31:02 +0000 Original-Received: (at 65380) by debbugs.gnu.org; 19 Aug 2023 19:30:46 +0000 Original-Received: from localhost ([127.0.0.1]:52316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXRen-00006z-M8 for submit@debbugs.gnu.org; Sat, 19 Aug 2023 15:30:45 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:48763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXRei-00006c-Vj for 65380@debbugs.gnu.org; Sat, 19 Aug 2023 15:30:44 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8C4C7240101 for <65380@debbugs.gnu.org>; Sat, 19 Aug 2023 21:30:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692473433; bh=nfEif4S0GkqFYqmTuKhXg3lxRS0S0L9RKJ/C2wBcEks=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=SdnxE74BcbNYPEjLkD5djBe+6wgOfsaX4t5Swk9jaZhh5xbpyOmpJOrOE12N+s97H Ki3do5wKQVxb9qgf/hD8d4m7tonmuQw6ylmeLCgH8JkR04+fNsHdh4WYVvWbV3k3zY mfQLNUHgCuxgUDY0RlGxkC/B8WLiZN0dcQgonaKyRe8QM6JwbYkcjE029ysfcluR9E tUuLmxttO31KJcdY0TAPLVkZvHF2nPFcVywuxXihJS4k6aC1+z9GZnB4KRksEgYXw6 b5/Aog/blCDKaDDmfbuPxpdRkH1p1IZu2220hQI34jS15VSXGfQYjJO4a4n+5gke72 VSZirSBRD/Yxw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RSpjw1h1Bz9rxH; Sat, 19 Aug 2023 21:30:27 +0200 (CEST) In-Reply-To: <83r0nyyhlz.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Aug 2023 22:09:12 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267908 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: 65380@debbugs.gnu.org >> Date: Sat, 19 Aug 2023 15:45:13 +0000 >> >> Eli Zaretskii writes: >> >> > But diffs don't necessarily show the entire body/ies of function(s), >> > they show just part of them. So this seems to be useful only in a >> > very small subset of cases? >> >> In theory yes, but as I mentioned in my first message, it comes up >> surprisingly often, at least to the degree that I think it would be >> something nice to have in general. If you think the current >> implementation is too primitive, one could extend it to check if the >> region is a subregion of a hunk, and handle that appropriately. > > I'd like to hear from more people who will find this useful enough to > have in Emacs. My first thought was that this is something you should > keep as your local extension, but maybe I'm mistaken. I have no problem with that, and there is no urgency in applying this patch.