From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Gerd Möllmann" <gerd.moellmann@gmail.com>,
"Herbert J. Skuhra" <herbert@gojira.at>,
65609@debbugs.gnu.org, "Andrew Scott" <andj.scott@gmail.com>
Subject: bug#65609: 30.0.50; inhibit-eol-conversion breaks revert-buffer
Date: Wed, 30 Aug 2023 21:43:23 +0800 [thread overview]
Message-ID: <87v8cwtzlw.fsf@yahoo.com> (raw)
In-Reply-To: <837cpchd9w.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 30 Aug 2023 16:26:35 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Thanks for an easy test case. We are reading too much from the file
> on disk when reverting in this case.
>
> Po Lu, I think we need the patch below to fix this. Gerd, does this
> solve your problem as well, including the abort during bootstrap?
> Herbert, I think this could also be related to the problems you see,
> so please try the patch below.
>
> diff --git a/src/fileio.c b/src/fileio.c
> index 23e1a83..8919e08 100644
> --- a/src/fileio.c
> +++ b/src/fileio.c
> @@ -4805,7 +4805,7 @@ DEFUN ("insert-file-contents", Finsert_file_contents, Sinsert_file_contents,
>
> /* 'try' is reserved in some compilers (Microsoft C). */
> ptrdiff_t trytry = min (gap_size, READ_BUF_SIZE);
> - if (!NILP (end))
> + if (seekable || !NILP (end))
> trytry = min (trytry, total - inserted);
>
> if (!seekable && NILP (end))
I don't believe this should incur any difficulties upon the Android
port, so please proceed with installing it if it works.
next prev parent reply other threads:[~2023-08-30 13:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 15:45 bug#65609: 30.0.50; inhibit-eol-conversion breaks revert-buffer Andrew Scott
2023-08-30 13:26 ` Eli Zaretskii
2023-08-30 13:42 ` Gerd Möllmann
2023-08-30 14:22 ` Eli Zaretskii
2023-08-30 13:43 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-08-30 14:18 ` Eli Zaretskii
[not found] ` <CAEtA7Wfv8UauiVpjJ669-R=QdC-u32mOhn_S+hQTUr3_9_zK=g@mail.gmail.com>
2023-09-03 15:51 ` Eli Zaretskii
2023-08-30 17:06 ` Herbert J. Skuhra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8cwtzlw.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=65609@debbugs.gnu.org \
--cc=andj.scott@gmail.com \
--cc=eliz@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=herbert@gojira.at \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).