From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66187: read-file-name unexpected behavior when MUSTMATCH is a function Date: Tue, 26 Sep 2023 01:37:12 -0700 Message-ID: <87v8bx48ww.fsf@breatheoutbreathe.in> References: <87r0mni6m1.fsf@breatheoutbreathe.in> <87bkdq3nw6.fsf@web.de> <875y3yx221.fsf@breatheoutbreathe.in> <87pm260wh9.fsf@web.de> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5261"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, 66187@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 26 10:49:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ql3ka-0001Be-Rd for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Sep 2023 10:49:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ql3kV-0004mP-Jc; Tue, 26 Sep 2023 04:48:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ql3kT-0004mG-29 for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2023 04:48:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ql3kP-000754-Il for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2023 04:48:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ql3kc-0005UX-5Y for bug-gnu-emacs@gnu.org; Tue, 26 Sep 2023 04:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Sep 2023 08:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66187 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: Philip Kaludercic , "Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors" , 66187@debbugs.gnu.org Original-Received: via spool by 66187-submit@debbugs.gnu.org id=B66187.169571813421066 (code B ref 66187); Tue, 26 Sep 2023 08:49:02 +0000 Original-Received: (at 66187) by debbugs.gnu.org; 26 Sep 2023 08:48:54 +0000 Original-Received: from localhost ([127.0.0.1]:47216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql3kT-0005Th-Oi for submit@debbugs.gnu.org; Tue, 26 Sep 2023 04:48:54 -0400 Original-Received: from out-190.mta1.migadu.com ([2001:41d0:203:375::be]:50441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ql3kQ-0005T7-Ul for 66187@debbugs.gnu.org; Tue, 26 Sep 2023 04:48:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1695718115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sVvKxRMEbwze5zrSnl7z+YdobUyjhIsxZZJcajSU2SM=; b=IaAgNWbgovrEQspfFMMw6tlU/uL1OzXuuyYYFRt4dUIKCQMcAV1kPFPB0D82z/nWNsXEfn sO0M7M7Jho7rYLEz0MBzvz9b1B9bhtJg+bFovXAwfrE0/tXzfQec+HS70i4R2EQgWznq08 wBzaX68DOcsohmLKCZ0IojddKDGfEgE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87pm260wh9.fsf@web.de> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271363 Archived-At: Michael Heerdegen writes: > AFAIU the algorithm > works like this: first it's checked whether a completion is allowed (by > checking whether it's the name of an existing file and consulting > PREDICATE when specified). Only when it is not allowed we check whether > MUSTMATCH declares it acceptable. Thank you!! That makes sense now. > This is not really explained in the docstring, however. > > In your example, the default-directory is the name of an existing file, > so the MUSTMATCH argument is irrelevant, the specified PREDICATE is > fulfilled, so it's accepted as input. > > If I guess correctly I think you want something like this: > > #+begin_src emacs-lisp > (let ((acceptable-p (lambda (filename) > (and (file-directory-p filename) > (directory-empty-p filename))))) > (read-file-name "Clone into new or empty directory: " nil nil > (lambda (filename) > (if (file-exists-p filename) > (funcall acceptable-p filename) > t)) > nil > acceptable-p)) > #+end_src > > Does that come close? Thank you! What I was hoping for may not have a clean solution: - the completions buffer displays and allows tab-completion for all directories, empty or not, then - upon pressing RET on a non-empty directory, the "[Match required]" message appears. Only upon pressing RET on an empty directory does completion succeed. If this cannot be accomplished elegantly, I'll consider other designs for the interactive prompt in package-vc-checkout. Thanks!! Joseph