From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Sun, 17 Dec 2023 11:19:57 +0000 Message-ID: <87v88xyt2a.fsf@localhost> References: <878r919qfh.fsf@localhost> <87fs06w4ui.fsf@localhost> <83bkaurut9.fsf@gnu.org> <87o7esq319.fsf@localhost> <83bkasrb3f.fsf@gnu.org> <83wmtgpuyf.fsf@gnu.org> <871qboprh3.fsf@localhost> <87y1dwobey.fsf@localhost> <878r5v20gu.fsf@localhost> <83bkapl5zh.fsf@gnu.org> <83zfy9jkoh.fsf@gnu.org> <878r5tglwp.fsf@localhost> <83ttohjet0.fsf@gnu.org> <83sf41jed7.fsf@gnu.org> <87y1dtyu4y.fsf@localhost> <83plz5jdgj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32761"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 17 12:17:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEp9D-0008KN-1M for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Dec 2023 12:17:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEp8q-0008Pi-1j; Sun, 17 Dec 2023 06:17:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEp8o-0008PV-A7 for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 06:17:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEp8m-0003Jh-KM for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 06:17:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEp8n-0001Qh-O2 for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 06:17:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Dec 2023 11:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.17028118195484 (code B ref 66117); Sun, 17 Dec 2023 11:17:01 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 17 Dec 2023 11:16:59 +0000 Original-Received: from localhost ([127.0.0.1]:56652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEp8k-0001QM-Ss for submit@debbugs.gnu.org; Sun, 17 Dec 2023 06:16:59 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:46365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEp8h-0001Q6-8C for 66117@debbugs.gnu.org; Sun, 17 Dec 2023 06:16:57 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 17DDE240027 for <66117@debbugs.gnu.org>; Sun, 17 Dec 2023 12:16:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1702811808; bh=CnEK4WPNzTPJt9mUaBe5sGTWZfLCaf9uQ44WlO62QRg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=OsWLx3gGjEhAH+KxrbhApdaiuQYq4iU99QMpN5jvu2M1iQ21T66QIq4CW2VEUlT4H 0IahhElonG7ypFeM7Rt7k9pICkrjBFbo/odPPNZW59hNpXe3nWEHIH2I0LtQ5mHIKe mBBIpTED2pXlymklEjUBkOjdkhZQAmTX4H2IH2doFq6qsk1NShikcU+Vsnd/m0a+ei YPOCfSUEm4tXncs7B0YXtR+JionHIvVXowXQhVo1nf5lkf6h5xDMY19Ftk0MknCeVg 65gnUFTyI/9ALQkL/y9QtkQA9afFzE9DaUXAd6+PJLWF91mu/Sz4NE5nvk78EkVXDp mQXAWtH+faIEA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4StL4v0gm7z6twx; Sun, 17 Dec 2023 12:16:46 +0100 (CET) In-Reply-To: <83plz5jdgj.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276416 Archived-At: Eli Zaretskii writes: >> AFAIU, not different. Previously, we had >> >> > @@ -4785,7 +4779,6 @@ init_buffer_once (void) >> > bset_tab_line_format (&buffer_defaults, Qnil); >> > bset_abbrev_mode (&buffer_defaults, Qnil); >> > bset_overwrite_mode (&buffer_defaults, Qnil); >> > - bset_case_fold_search (&buffer_defaults, Qt); >> >> So, the default value was Qt previously as well. > > buffer_defaults is not the default value, AFAIU. Unless I misunderstand, the comment says that buffer_defaults does hold the default values. /* This structure holds the default values of the buffer-local variables that have special slots in each buffer. The default value occupies the same slot in this structure as an individual buffer's value occupies in that buffer. Setting the default value also goes through the alist of buffers and stores into each buffer that does not say it has a local value. */ extern struct buffer buffer_defaults; >> The DEFVAR_LISP + V... + DEFSYM + Fmake_variable_buffer_local is taken >> from other buffer-local variables. For example, > > I'm talking specifically about any changes from previous behavior > visible from Lisp. I think we should test all of the following: > > default-value > default-boundp > setq-default > default-toplevel-value > set-default-toplevel-value > > and make sure they all behave exactly the same, both in and out of a > let-binding. The patch did not introduce test failures for make check on my side. Are there existing tests for buffer-locals? Or do we need to add them? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at