From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt Date: Tue, 23 Jan 2024 17:38:07 -0800 Message-ID: <87v87jecjk.fsf__16981.322218065$1706060379$gmane$org@neverwas.me> References: <87v87yvnly.fsf@dataswamp.org> <834jfikb4d.fsf@gnu.org> <87mstavias.fsf@dataswamp.org> <87wmseoskl.fsf@dataswamp.org> <87plxyowpg.fsf__13716.8874776521$1705633220$gmane$org@neverwas.me> <87wms1k6xg.fsf@dataswamp.org> <87plxt2yjx.fsf@neverwas.me> <87ttn5job9.fsf@dataswamp.org> <87r0i9jhp6.fsf@dataswamp.org> <87zfwxxdmn.fsf__6793.81943061657$1705958905$gmane$org@neverwas.me> <87zfwwism6.fsf@dataswamp.org> <87wms0is9o.fsf@dataswamp.org> <87sf2oin9p.fsf@dataswamp.org> <87le8gi3bn.fsf@dataswamp.org> <87bk9bh8jt.fsf__34675.6314321951$1706056632$gmane$org@neverwas.me> <87o7dbh7lu.fsf@dataswamp.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14025"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 68401@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 24 02:39:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rSSEj-0003Pa-IE for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Jan 2024 02:39:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSSEE-00014l-QW; Tue, 23 Jan 2024 20:38:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSSEE-00014c-8s for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 20:38:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSSEE-0005Lj-0f for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 20:38:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rSSEI-0001rF-Om for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 20:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2024 01:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68401 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68401-submit@debbugs.gnu.org id=B68401.17060603027064 (code B ref 68401); Wed, 24 Jan 2024 01:39:02 +0000 Original-Received: (at 68401) by debbugs.gnu.org; 24 Jan 2024 01:38:22 +0000 Original-Received: from localhost ([127.0.0.1]:44227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSSDd-0001ps-FV for submit@debbugs.gnu.org; Tue, 23 Jan 2024 20:38:21 -0500 Original-Received: from mail-108-mta226.mxroute.com ([136.175.108.226]:39813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSSDa-0001pi-T6 for 68401@debbugs.gnu.org; Tue, 23 Jan 2024 20:38:20 -0500 Original-Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta226.mxroute.com (ZoneMTA) with ESMTPSA id 18d391e1c1a0003727.001 for <68401@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 24 Jan 2024 01:38:11 +0000 X-Zone-Loop: 3510aeba559bf93fb30a2cdff502cee08196013fb97d X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pM5HflBTRFYkJcXVYPFXyCfLyYznj0efh7x6nKSFWWM=; b=irDMWcRdD6GQC0nPusTmrx+Wpv l0ovkeGTRpv47+ixwa6vm2gDL2TtViNGtBEMMcnk7Sih3Nm45yP3NgcbK93HBzgo73AYsEXoetHrK blJk3/31958GCQtqfXtu+C7xcyqC6OHwQZji82/m8qa44/RrkwaF3dv6QTfK6Cxk5xSme33ICQVNE MZPKcX2l3uGrw8NY95guAUVgnmElEv4O34m12E7jEpFBbIXuz1nLbcQRKeuqEtCtQX8Z6SFV6KUan 8jz6nCp8lap5I9fboREwB423y7pBSniv9lJmm6AtafezfBD54ehJk0BD5Sey/TrgdR0DIsxhrHomS neFhiJ1Q==; In-Reply-To: <87o7dbh7lu.fsf@dataswamp.org> (Emanuel Berg's message of "Wed, 24 Jan 2024 01:56:29 +0100") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278759 Archived-At: Emanuel Berg writes: > J.P. wrote: > >> I don't understand the point of adding your purpose-built >> predicate `erc--connected-and-joined-p' if you're not going >> to use it to replace >> >> (lambda () (erc-channel-p (erc-default-target))) >> >> completely. IOW, having both is redundant > Redundant from the POV of `erc--connected-and-joined-p' because it calls `erc--current-buffer-joined-p' (which see). Please compare that function's definition to the lambda. There are overlapping concerns there. That is, one "subsumes" the other, thus obviating the need for it. > ?? > > (lambda () (erc-channel-p (erc-default-target))) > > has been there all along, you then told me to add the > "logical" connectivity test. > > If we can just use the lambda, I'll be happy to drop the test. You can't just use the lambda, but you can lose it entirely in favor of your predicate. > >> If you're not already doing so, please try expanding your >> macro use sites to verify correctness. > > ??? > > My "macro use sites" is what? If you expand one of your `erc-with-all-buffers-of-server' forms with both the lambda and `erc--connected-and-joined-p' present, it should become clear why only the latter is needed.