From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69168: [BUG] 30.0.50; pp-emacs-lisp-code produces invalid elisp for backquoted forms Date: Sun, 25 Feb 2024 06:00:38 +0100 Message-ID: <87v86dt9xl.fsf@web.de> References: <877cj5y1qg.fsf@gmail.com> <87mss1nono.fsf@web.de> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4511"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69168@debbugs.gnu.org To: No Wayman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 25 06:11:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1re6n3-00015D-Q5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Feb 2024 06:11:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1re6me-00072h-4M; Sun, 25 Feb 2024 00:10:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1re6mc-00072K-JW for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2024 00:10:38 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1re6mb-0002Wj-Fu for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2024 00:10:38 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1re6mz-0007EI-NZ for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2024 00:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Feb 2024 05:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69168 X-GNU-PR-Package: emacs Original-Received: via spool by 69168-submit@debbugs.gnu.org id=B69168.170883782427679 (code B ref 69168); Sun, 25 Feb 2024 05:11:01 +0000 Original-Received: (at 69168) by debbugs.gnu.org; 25 Feb 2024 05:10:24 +0000 Original-Received: from localhost ([127.0.0.1]:39644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re6mO-0007CK-EM for submit@debbugs.gnu.org; Sun, 25 Feb 2024 00:10:24 -0500 Original-Received: from mout.web.de ([212.227.15.3]:49595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re6d5-0006kk-5d for 69168@debbugs.gnu.org; Sun, 25 Feb 2024 00:00:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1708837215; x=1709442015; i=michael_heerdegen@web.de; bh=wmU3nRMzm0t9o+a3e3pceIFoxHrZvW261v68A9bwo/0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=oh3Exud68H6NFuOX+THGOqC4I0w8T5+mBihHafVKdKY2rqcxxdq4kT5wpznfXM6F IuZ96EryIUVvBs0oPnksbqC0eRgSlmvYpywZNdEffLrPCyny+DeND/skh403fAXML OTfe1vuSIYFi360Dh0Bg49T5CRQqKxiF6ZuydW2cNcWIr8RoUSoswHiIQDFR8jJ1E q9Ni7cgNi3h0I4KUdaL6PIOCQqhZg3Kv4v20dVww7PwS7J3tvNdZp1sgGF5z45RL4 1YfPh4ZAylrrcUbcbdDxAz27REubjsMTs1SC22PQLNR6JeGwZ1vtfNL7ri+gh5kUa OmP9EIVcBgrgr2jqVA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([92.76.229.82]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MgAJ8-1qyjib1JDq-00ha8v; Sun, 25 Feb 2024 06:00:15 +0100 In-Reply-To: <87mss1nono.fsf@web.de> (Michael Heerdegen's message of "Fri, 16 Feb 2024 03:11:55 +0100") X-Provags-ID: V03:K1:MY07Cg1Fkh9lX1gsJDu2/ckyYZIX285eg9MrNq8XMmJh/gOeOWV nM0j3QGIRr2Y9H3KzZ65yaObMhyV5mBmjeEIxoFWDoZPS77ywwfHW9ljnMFtu1oCc0qvVLf 90RQUuHdUh0gW7Qh9N7VNIP9hwXdwDzZkOTS+1Xeh6e240qAvFL8vNq6miVIMhJ9xzathWg hmKvtAdAcP/ioRZ90hsMQ== UI-OutboundReport: notjunk:1;M01:P0:mHEOBhnZTzA=;CDE0+IzySR5+aoQxdHMezCigJGI RskAGzH4rUUHGWuxzPpeUva5PJ87AM0uXczdDDkGFN8uy/7HNI2q7LaL5icvIqiFLXfPsgPmW bZtmUO7WuoWfDw9nuwAqz0eiskWSocMf4vQIcxQctFO0Ex63oNtLLiRnpWN9mw0RL+f3pXR5H bbhnY1f885cK7LLJL2okzZ1XJVOoCG6cFLiHWCC8I0U1QoLivshM04vWvFW1AFFHstK5ukyhb rqpHfv08bG+Mb2BooOIb5Gd43QYklXmaCbboy7wkubEbMlQtlwr6pFXPOV7hP7THTin4jYfa0 rW4dXhBQvzDx42vJ4shxUSMxZF/nYw07bw2fJJBjMbASVq0tb1PPK40jyXhT4wSPq+FmeoOI+ e6/N4K/MHrMQtK4u4vWwE2oR9Du/YzShfNivUCWn2+9qtKhxqOKXlasZrdS1usIb6o1+8DVUj 7PS+QlY2GKkujmXbxNfLiQCX0kM29wg5bfNPnbHr3AmjzP/hwO7SeVaNWxWfTnzq4ArVqmMIZ DHenDHTzYO4EJWNFUJDqwteyyG8kEcKlTRsfQu+Dwe8FI2sGwVrsRn+ly09QXlkqBwvnEus38 +R/vokN9N5uiNZAWoTjB1aaTeyBOQKAu7Szzk052v5tpdBvdXlzFQrYnwpeAk9hP99I61mAGy xdJrR4ySzMHEbkQKjiNlhJqqilF1IdTnBklzCShIYk7/IIPKc62ZLKrScgUtd8UB7LPgOj1Cs 9aL6oGjWUE3h92c+XXAxL+UTZ8ycvIQ1RckS2SxjUZdBONU6wnojdwhiBZHgnRJdKoz5zwAP X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280586 Archived-At: --=-=-= Content-Type: text/plain Michael Heerdegen writes: > The second problem is that the recursive calls of `pp--insert-lisp' > print symbols using `princ' (i.e., without quoting), so even the list > representation is wrong. I think we should print any symbol using `prin1', not `princ' - printing symbols that need quoting without quoting is not useful: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-pp-emacs-lisp-code-printing-of-symbols.patch Content-Transfer-Encoding: quoted-printable =46rom f493708a456608f59b29c3f2308ecc51177667ec Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Sun, 18 Feb 2024 02:48:15 +0100 Subject: [PATCH] Fix pp-emacs-lisp-code printing of symbols * lisp/emacs-lisp/pp.el (pp--insert-lisp): Print symbols readably (bug#69168). =2D-- lisp/emacs-lisp/pp.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lisp/emacs-lisp/pp.el b/lisp/emacs-lisp/pp.el index 1d722051406..944dd750839 100644 =2D-- a/lisp/emacs-lisp/pp.el +++ b/lisp/emacs-lisp/pp.el @@ -458,6 +458,8 @@ pp--insert-lisp (string (let ((print-escape-newlines t)) (prin1 sexp (current-buffer)))) + (symbol + (prin1 sexp (current-buffer))) (otherwise (princ sexp (current-buffer))))) (defun pp--format-vector (sexp) =2D- 2.39.2 --=-=-= Content-Type: text/plain Michael. --=-=-=--