From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#70036: 30.0.50; Move file-truename to the C level Date: Sun, 31 Mar 2024 14:57:15 +0200 Message-ID: <87v852o8yc.fsf@betli.tmit.bme.hu> References: <87le63xzjt.fsf@thornhill.no> <87ttkrqvru.fsf@betli.tmit.bme.hu> <87il17xsea.fsf@thornhill.no> <86wmpmhp0a.fsf@gnu.org> <874jcqygpn.fsf@thornhill.no> <875xx6muzt.fsf@ulti.tmit.bme.hu> <8734say2wi.fsf@thornhill.no> <87zfugoxwn.fsf@betli.tmit.bme.hu> <86wmpjdh1o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4812"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: 70036@debbugs.gnu.org, theo@thornhill.no To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 31 14:58:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqulX-000104-6a for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Mar 2024 14:58:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqul8-0000cB-Il; Sun, 31 Mar 2024 08:58:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqul7-0000c3-2F for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2024 08:58:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rqul6-0006zx-Q0 for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2024 08:58:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rqul9-0005YK-4j for bug-gnu-emacs@gnu.org; Sun, 31 Mar 2024 08:58:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Mar 2024 12:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70036 X-GNU-PR-Package: emacs Original-Received: via spool by 70036-submit@debbugs.gnu.org id=B70036.171188984921279 (code B ref 70036); Sun, 31 Mar 2024 12:58:02 +0000 Original-Received: (at 70036) by debbugs.gnu.org; 31 Mar 2024 12:57:29 +0000 Original-Received: from localhost ([127.0.0.1]:46763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqukb-0005X9-3O for submit@debbugs.gnu.org; Sun, 31 Mar 2024 08:57:29 -0400 Original-Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]:47547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqukZ-0005Wg-4T for 70036@debbugs.gnu.org; Sun, 31 Mar 2024 08:57:27 -0400 Original-Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a450bedffdfso356200266b.3 for <70036@debbugs.gnu.org>; Sun, 31 Mar 2024 05:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711889838; x=1712494638; darn=debbugs.gnu.org; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=vMXCRTsZvPwJSLZfOj/CE1g92WkNwJUP8zrxYA1SryM=; b=P6Ar78BQYMl6HjwMccQGLixpWMbRoMeVj1RJ/NLVJYL7Rdn3rURr47RdAmcnYVh7f+ HhDZbFPQ4p4Ubbb+xgPRE+2l4A7cCDBUzQGiXDLlByCEEFXfskIHhszN0ChAS4w+toyU OLofRc7M7IBIyyA9bSlKax+SCIvdIyREz0Ml7QE+iKcI09hzz27gCXG2kGFfoMhQqZys mX/nLEkaL7th+JbU+TUyCMA+TlxgjFlS8rzSmrkroFY546IrH3ddMyX9JU2EH0/KgWC3 Ah+IVHZtSvFvsR8fgA+V+uFR3LP1Fo96Xz0Vms39iIHes1enBCsje7NUALvPvlYgCkYO jpNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711889838; x=1712494638; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vMXCRTsZvPwJSLZfOj/CE1g92WkNwJUP8zrxYA1SryM=; b=NoPY0pqW5gFqtVhQRNSjeYsvto6TSte+ofOJwTCPHN8Gj2RREnYRn8nUY4WerPIqFl u4k55fbmulstE6nih3KUTtNo9ILGh+ik7yxLDQi0Q9ZSqssUwZ5oQ64Y+/Zbrlpfys7v FGtIBuiO/rgTYX0S8pcP9fglY/3mtfEjoGjMvdZ9x5EaRmmv4T5OO5rD2dMM/WtDQyoE bA4B/AKJ0H0C8NAQe0P6jyYt3rOhu8XafkeVCMEvy/ZRprrxXeJXg50S232rEypl5aDL DZDZtQiJf+b0mFrAqnw01X10aKl1CisE0cW7XE+aqF/MVGyrzBDkFb/RXHDGBqWfDoA7 Laug== X-Forwarded-Encrypted: i=1; AJvYcCUZjeChaSHzUx1DjbC30EpD004sKm/gNDPk3+OccLuemEhxTkdl4GH78qgzT+LVARLEME95lLhX5PEEjHHGZ9oEnUfn6kA= X-Gm-Message-State: AOJu0Yxx7CKd2ObTcrGbr+lvUF9fueI+gNrExmJFv5h93GDh3ICyHqsr f2tDK7aqLau6eu3CMEGnV+IsIviMSkQ8z4FmNzTiwwdtAXqLPMEDl9XHLyvH X-Google-Smtp-Source: AGHT+IGoySoOaQVnK2/itQg++at1SzC1co8euSR4ySE3ojmcoQai1DLwmMnflPt8kKzJY+J9azenOQ== X-Received: by 2002:a17:907:3181:b0:a4e:663a:3cf4 with SMTP id xe1-20020a170907318100b00a4e663a3cf4mr754818ejb.6.1711889837589; Sun, 31 Mar 2024 05:57:17 -0700 (PDT) Original-Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id h8-20020a1709060f4800b00a46d049ff63sm4118192ejj.21.2024.03.31.05.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Mar 2024 05:57:17 -0700 (PDT) In-Reply-To: <86wmpjdh1o.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Mar 2024 15:45:39 +0300") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX5+fmhoaEwMDD/ ///TMNVWAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAAPEgAADxIBIZvyMwAAAAd0SU1FB+AICBUfHgLs gGoAAAGXSURBVCjPRdK/b5tAFAfw753gBEwM2ApMbuVIqf+Ko0qiyhOu4sj2xJBYMn/FUdX7UUUZ OjHgyvf+yj6IcW6Bjx53934ADEvs8bmEr8UVoTYTOyJO9KoYsVofN8kILdbeJ8Li6YpZWop4xOK0 VdfIoXmkHn5/5D7/Ts/8THacSqnkKTcMTxgUkVzFnEIRTKwwYYSCvzfg16f0i8YApW/XG/Pm8R49 dXjxKmRnxv3OwooQWcv4RUYem1fsNe/WU63uk7AmYxk78y32/ee2tZB4fO+WcZ7lnIGEolXW1EGw LfkSuQ0XTgRefgNlfNwRNV6QhBxJ8JNxTMUPyBqTd0bjaAP5G7NJRU39z80hLOZTjqB7K3tEEFSj aEsuQew6qBxxyhHjVUR7H7NpC9iHJZGLMCEuweqAqE1BHbfK2oRIz9EHYA/+wiFWru9smeVfuWNZ 2+NFtX80UA1TvJNdytM4DwO4kY7bJz8Qcd0G0ceslZGkkeoBsjUHwF1+jjM3XHaXEZ7mGLfwPFO+ RV9QLY2iEdmDo78D/gNPaXVYqd+pyQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxNi0wOC0wOFQyMzoz MDoyOCswMjowMGy/yHYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTYtMDgtMDhUMjM6MzA6MjgrMDI6 MDAd4nDKAAAAAElFTkSuQmCC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282432 Archived-At: Eli Zaretskii writes: >> From: Felician Nemeth >> Cc: Eli Zaretskii , 70036@debbugs.gnu.org >> Date: Sat, 30 Mar 2024 10:46:00 +0100 >> >> I think using find-buffer-visiting instead of get-file-buffer and >> file-truename instead of expand-file-name in Eglot is problematic. >> Let's say we have these files: >> >> /project/a.c >> /project/a.h -> /other/a.h >> >> Eglot will communicate these file names to the LSP server: /project/a.c >> and /other/a.h. Then the server cannot "associate" a.h with a.c. >> Additionally, a.h will be outside of the LSP workspace. >> >> This indeed confuses clangd a bit: it only takes into account the >> changes of buffer a.h when it is saved. (Because it assumes >> /project/a.h is not opened in the editor.) > > Can LSP servers resolve symlinks? If they can, then expand-file-name > is TRT, AFAIU. The LSP specification does not talk about symlinks. The servers I used let the operating system resolve symlinks for them. All in all, I think Eglot should switch to use expand-file-name as well. It should also use get-file-buffer instead of the more complicated caching mechanism proposed previously. Theo? Nevertheless, Eglot will continue to handle poorly the case when there is a symlink in a project that points outside of the project. Hopefully, this can be potentially solved later with the idea behind eglot--servers-by-xrefed-file.