From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#70375: 30.0.50; Obsolete certain comint-osc symbols Date: Sun, 14 Apr 2024 09:53:46 +0200 Message-ID: <87v84kcrcl.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6882"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Matthias Meulien To: 70375@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 14 09:55:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvuhp-0001es-6T for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Apr 2024 09:55:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvuhS-00006P-DK; Sun, 14 Apr 2024 03:54:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvuhR-000068-8y for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 03:54:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvuhR-0007Yn-0i for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 03:54:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvuhb-0000lB-KM; Sun, 14 Apr 2024 03:55:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: orontee@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Apr 2024 07:55:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70375 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Matthias Meulien Original-Received: via spool by submit@debbugs.gnu.org id=B.17130812532334 (code B ref -1); Sun, 14 Apr 2024 07:55:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Apr 2024 07:54:13 +0000 Original-Received: from localhost ([127.0.0.1]:34225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvugn-0000bY-3r for submit@debbugs.gnu.org; Sun, 14 Apr 2024 03:54:13 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:42268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvugj-0000Zo-Pe for submit@debbugs.gnu.org; Sun, 14 Apr 2024 03:54:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvugS-0008U5-U4 for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 03:53:52 -0400 Original-Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvugR-0007PF-5i for bug-gnu-emacs@gnu.org; Sun, 14 Apr 2024 03:53:52 -0400 Original-Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a51b008b3aeso261036266b.3 for ; Sun, 14 Apr 2024 00:53:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713081229; x=1713686029; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=gsv+BoN5tyZaO/oS8iN5ZeG9NbTE3Z4BCicdhVyEju8=; b=QJIij5SLSI1DO9hbBkb/QqMBtPd/WlZ65NsLnqcp2YTuxrnOVcZzTxYXfFVWJIIXc5 CdCWLk3GlSqtNhUhefdSFCk9BWwjEwnXk3d7hjAwvQO5ZEcTmlOOz9luyEGf3f0iZedw 2sG7Ykh21IEhHkPVjNP0Ex0hRRPUa+HEtpIUcsfYvcEqJdA/VlCw02nhfsqD6U5BzMgY mFPqoWjdT5n/J83Q0ieShz9AXZDk9WpkULq0v9r2Hv6p2PJRaq+FU7swALe9WlbaMvb/ iSmcn++6BGcA7rPZH2u230by/RGqfE0MeXuGUMYKCfiFI8jNXxV076PR0qG9cfDFEUV5 SOUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713081229; x=1713686029; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gsv+BoN5tyZaO/oS8iN5ZeG9NbTE3Z4BCicdhVyEju8=; b=Aia1fVz60srBz+yZf/KsNXpeoHpu1sr7Cytl2O1GS4tbI2Xo+GfT0xR2j04/7J7EMH Bk94H0nfS7QgxhqPvkyVazM2F5UwEBzn3puwpqPyyI2vUnhKodof1UR9duztFsyw7xH3 Tp7yJzkdX44976F08tR8LkGI9iP0A2usDn19SP+1qbHwb42AvEtn/gJydyRCD4RWR6Sc Zj/4vfBQHbmOBKi6dN2yTJ97fEGkPPA3hs5d4CGrBOMXKVKrJB85yMVJNiU/1q37CLF0 bSkv50j69lGQ4xQjFg0VDWwJni2V/W6gD7gwOmBnQDeBhbYCgxp1ck/HjqWTBlXf0CJY n/aA== X-Gm-Message-State: AOJu0YxAnuEqVd4UJ04wUwmXsq+DwjB51W7WaKPw2X/qFBb43mZ9BMw1 Bs2oxKa7vE+OBCzQ+3siHEdyw/O3aIW5F535fODXoVrd4/68PqD0RMvqvA== X-Google-Smtp-Source: AGHT+IHNtxgCsz1DwTHO4dAGprLmVTHV4kD5ydMNw7VE2pghK8tQ50lXP+P/Qw9NYQgNCzsl8y6wrg== X-Received: by 2002:a17:906:4086:b0:a51:cab2:e55d with SMTP id u6-20020a170906408600b00a51cab2e55dmr4806207ejj.15.1713081228529; Sun, 14 Apr 2024 00:53:48 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8a87:ff00::6223]) by smtp.gmail.com with ESMTPSA id di18-20020a170906731200b00a4e9359fbe8sm3903269ejc.44.2024.04.14.00.53.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Apr 2024 00:53:47 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283257 Archived-At: --=-=-= Content-Type: text/plain When ansi-osc.el was created, moving code originally in comint.el, the variable and function aliases created for backwards compatibility purposes were not marked as obsolete. The attached patch fixes this. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Obsolete-comint-osc-symbols-moved-to-ansi-osc.el.patch >From a2b4a0e0282f94949890cff65427e7536642cc0b Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Sun, 14 Apr 2024 09:43:27 +0200 Subject: [PATCH] Obsolete comint-osc symbols moved to ansi-osc.el * lisp/comint.el (comint-osc-handlers, comint-osc-directory-tracker, comint-osc-hyperlink-handler, comint-osc-hyperlink, comint-osc-hyperlink-map): Mark as obsolete. --- lisp/comint.el | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index a8fe095e99c..bae89beb76b 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -3961,18 +3961,22 @@ comint-redirect-results-list-from-process ;;; OSC escape sequences (Operating System Commands) ;;============================================================================ ;; Adding `comint-osc-process-output' to -;; `comint-output-filter-functions' enables the interpretation of OSC -;; escape sequences. By default, OSC 7 and 8 (for current directory -;; and hyperlinks respectively) are acted upon. Adding more entries -;; to `comint-osc-handlers' allows a customized treatment of further -;; sequences. +;; `comint-output-filter-functions' enables the interpreting of OSC +;; escape sequences. See `ansi-osc-handlers' for a list of OSC +;; sequences which are interpreted by default and information on how to +;; handle new sequences. ;; Aliases defined for reverse compatibility -(defvaralias 'comint-osc-handlers 'ansi-osc-handlers) -(defalias 'comint-osc-directory-tracker 'ansi-osc-directory-tracker) -(defalias 'comint-osc-hyperlink-handler 'ansi-osc-hyperlink-handler) -(defalias 'comint-osc-hyperlink 'ansi-osc-hyperlink) -(defvaralias 'comint-osc-hyperlink-map 'ansi-osc-hyperlink-map) +(define-obsolete-variable-alias + 'comint-osc-handlers 'ansi-osc-handlers "30.1") +(define-obsolete-function-alias + 'comint-osc-directory-tracker 'ansi-osc-directory-tracker "30.1") +(define-obsolete-function-alias + 'comint-osc-hyperlink-handler 'ansi-osc-hyperlink-handler "30.1") +(define-obsolete-function-alias + 'comint-osc-hyperlink 'ansi-osc-hyperlink "30.1") +(define-obsolete-variable-alias + 'comint-osc-hyperlink-map 'ansi-osc-hyperlink-map "30.1") (defun comint-osc-process-output (_) "Interpret OSC escape sequences in comint output. @@ -3985,7 +3989,7 @@ comint-osc-process-output Specifically, every occurrence of such escape sequences is removed from the buffer. Then, if `command' is a key of the -`comint-osc-handlers' alist, the corresponding value, which +`ansi-osc-handlers' alist, the corresponding value, which should be a function, is called with `command' and `text' as arguments, with point where the escape sequence was located." (let ((start (1- comint-last-output-start)) -- 2.44.0 --=-=-=--