From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69941: 30.0.50; Faulty fontification of radio button widgets Date: Mon, 13 May 2024 15:53:54 +0200 Message-ID: <87v83h4y31.fsf@rub.de> References: <87h6gynx49.fsf@rub.de> <87o79c8n60.fsf@gmx.net> <87zfst4zuh.fsf@rub.de> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1259"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69941@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 13 15:55:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6W9E-000Aa9-Tm for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 May 2024 15:55:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6W8w-0008KI-UB; Mon, 13 May 2024 09:55:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6W8s-0008HH-Aj for bug-gnu-emacs@gnu.org; Mon, 13 May 2024 09:55:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6W8r-0002wx-Hk for bug-gnu-emacs@gnu.org; Mon, 13 May 2024 09:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s6W8r-0001sF-S8 for bug-gnu-emacs@gnu.org; Mon, 13 May 2024 09:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 May 2024 13:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69941 X-GNU-PR-Package: emacs Original-Received: via spool by 69941-submit@debbugs.gnu.org id=B69941.17156084497183 (code B ref 69941); Mon, 13 May 2024 13:55:01 +0000 Original-Received: (at 69941) by debbugs.gnu.org; 13 May 2024 13:54:09 +0000 Original-Received: from localhost ([127.0.0.1]:32882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6W80-0001rn-Q1 for submit@debbugs.gnu.org; Mon, 13 May 2024 09:54:09 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:43213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6W7x-0001rQ-Ew for 69941@debbugs.gnu.org; Mon, 13 May 2024 09:54:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1715608436; x=1716213236; i=stephen.berman@gmx.net; bh=sMb8MAyxOIIKdXeoMTUpEavQK8aCoMFiDqjaDTjkU2Q=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=Pk40CLOZQTzyjaG/+GDvJ3yuJtPZplmSEAhWqBaH18rXC1bDvcYo+AaxfwJV5WXj GOCR+P6wyzXV1ykwl1rNIefZVPsdchzw98zAkp75Yl3oZxCNfJd9m2lrO3w+2f+2P qkPXzAJQkLQN7pS3g7w8Ufjgv5E7FcLJenho24NfPkxR8rGLKy6mc+AlQbC/zMWHx PVQROviBtIeJ6hGMx1ne8hhtPiynhn2AdxlJIIgWRo8x26QU/Hh7M3GjLIJ7NlEM7 AAbLAI05cXYg54UwnnK11Xx619xOPS38fHOPMU5t6WWC6+2fAhHSuiVUqogP1N+ha zv5PpmaE2Ml+lPkIqA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([94.134.95.151]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MhD2O-1sjgQL3Z4c-00hfIJ; Mon, 13 May 2024 15:53:55 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 13 May 2024 09:28:54 -0400") X-Provags-ID: V03:K1:09jy+VBFUXzG7wgDB0RFSCvBvCdi4Vc2EUUFF8b74kVlu8YsfdX p4SswbMegrFwqr9hstqmU3ANrJav1I72XLYxMXu6KOL0UQt09AXCQqmWlTxacY57QILEtJw Ad0UpdpKXIuUmC9Y0ImF0RUXZ8nlXneludnJlgArKUGyZqxVPQhDF0Qkk89QCL5Sqklfyts wdZn+IvO2bRhiSCWJiIgQ== UI-OutboundReport: notjunk:1;M01:P0:durF7ie02HU=;TttKmhHk3RRRXbKL/Va+CVWLenL 8Mte5rl2w/9vvkSLnUZqdMLSj7iY6pGt+qSfpoFfozdIZ5dLw5TZvaysf2FBqqlp0b04h8IUz gnoaKraCd2OH/7b2QN9AsNaGMyNP8zYWpf40inlbl3hMRWywXIg81Nl8hSz7a004YN0p1uNT0 E8TuwWVcsw8pKm2UXbsdJasjpYbC/VUeDfyxbUIaPVZsZJAiAlxDj9IXfBo07B4QaceEN+2d+ yHMgbNb7zyr/kbWkZZqnlp3wSQXj5IldJAJMp05iUcmRPwRj5OvUf7ZYEvKh5Cd8R33Zu0M3n wc986XNIS9varnRCJK9xTGx1H1I1rkOZZnyQqRbPQBVWIIdXm0kNrs8B1+sMDy+kPun14Cbpe 36SHw2YtXg0k6NnT35kFkop6s2sUucJSYv1N6OkzPTnLAeiXgQV5X6AcpPrH/9OcKsrp2PPs0 iAAiKBbgd8SjK/1h5k4Gu37TVOb3bFlR/4TtSiz+Sot8rJzxQDq5/+nvNJ5PPIKrolmXI6cpb ysV9Am2ImNXcdTp3m0M9RyyayVcmmH8cryRNOOqDRU2G0lGZuk8Eadrt6+e0CWiL/XytwBwRp qthF07C0LcUFibwE3JMN+sIQW9tLYBldc9EgRp7DYyPVZPVtYFrsLG6cEvhXfjdgwHSXWO1De ymtDY51DV5Y2dAAsAx1bV0AAduiJmP1kwQjYLB0ekPNZh/FK9BK1AjICiDrLONWsnDE1gG/vG obJy9WIk702dicf77ydbQVtzfrPBd/fgX4iknvus09KWhtf86jVOiJ7wp1WEFK3TBhz1nBqC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284974 Archived-At: On Mon, 13 May 2024 09:28:54 -0400 Stefan Monnier wrote: >>> I meant the "too late" insertion of radio buttons into >>> radio-button-choice widgets (and likewise of checkboxes into checklist >>> widgets), because IIUC the way this is currently done (by >>> widget-radio-add-item and widget-checklist-add-item, respectively) >>> requires that the container widget is already in the buffer. >> >> Then maybe widgets which expect to be filled after they're created >> should make sure they have an additional character at the beginning and >> another at the end so insertions "inside" don't get confused from >> insertions "right before" or "right after". Something like with editable-field widgets (cf. commit 3bff434b8: "Document need to put some text before the %v escape in :format string")? Wouldn't that complicate the display these widgets, e.g. forcing a corresponding offset of all radio buttons or checkboxes in order to align with the first one? > Or maybe `widget-*-add-item` should temporarily change the insertion > type of the from/to markers? What do you mean by "temporarily"? Recall the problem that prompted my OP in this bug is the misfontification of the first radio button in a deactivated radio-button-choice widget, and the deactivation can happen any time, long after the widget and its children haven been created. Maybe it could be left up to the deactivation code to ensure that the radio-button-choice widget's :from and the :from of its first child coincide when deactivation (and accompanying fontification) occurs, and then reset the previous values afterwards. Though that seems pretty ad hoc... (and would resetting the :from affect the fontification?) Steve Berman