unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: 60078@debbugs.gnu.org, "Björn Bidar" <bjorn.bidar@thaodan.de>
Subject: bug#60078: 30.0.50; Gnus: Can't remove groups of select methods that don't exist anymore
Date: Tue, 14 May 2024 20:42:05 +0000	[thread overview]
Message-ID: <87v83gdt2d.fsf@kubajecminek.cz> (raw)
In-Reply-To: <875xvh9ppx.fsf@ericabrahamsen.net>

This whole issue sent me really deep, so thank you for sticking by.

"Eric Abrahamsen" <eric@ericabrahamsen.net> writes:

> I think you're right about the definition of "foreign", and that there's
> a bug/misunderstanding in code like this, but this check isn't a
> complete fix because `gnus-group-secondary-p' looks up the group's
> method, and the whole reason we're running this code is that the group's
> method no longer exists. (The original/current code also has this
> issue.) If the method is actually gone, groups that used to belong to it
> will also be passed over.

Then it comes down to you as package maintainer to decide what bogus
group actually is, because current definition makes little sense to
me. For example, if the server is down and Gnus is not able to get
active info, all groups belonging to that server become bogus, which is
a little unfortunate.

> So I guess there's two scenarios to support: in the first, the server is
> still there but one or more groups are gone (someone's deleted an IMAP
> folder from the server) and in the second the server itself has been
> removed from the user's config files, and we're clearing out the old
> groups.

Both of these cases can be handled with simple (group-active group)
predicate. Do you have a clue why Lars wanted to handle foreign groups
separately? I've searched (ding) mailing list, old bug reports,
changelogs, commit messages, and everything else I could find but I
found nothing.

Thanks!

-- 
Kuba Ječmínek (http://kubajecminek.cz)






  reply	other threads:[~2024-05-14 20:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 22:55 bug#60078: 30.0.50; Gnus: Can't remove groups of select methods that don't exist anymore Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-22 23:01 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-23  3:26   ` Eric Abrahamsen
2024-02-23  9:22     ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-23 16:12       ` Eric Abrahamsen
2024-04-01 21:10 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-11  3:38   ` Eric Abrahamsen
2024-05-12 22:08     ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-14  0:55       ` Eric Abrahamsen
2024-05-14 20:42         ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-05-16 17:02           ` Eric Abrahamsen
2024-05-16 19:53             ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-17  2:55               ` Eric Abrahamsen
2024-05-17 20:48                 ` Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-21 22:48                   ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v83gdt2d.fsf@kubajecminek.cz \
    --to=bug-gnu-emacs@gnu.org \
    --cc=60078@debbugs.gnu.org \
    --cc=bjorn.bidar@thaodan.de \
    --cc=eric@ericabrahamsen.net \
    --cc=kuba@kubajecminek.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).