From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#71213: [PATCH] Use the current face foreground for read-passwd icons Date: Tue, 28 May 2024 19:33:46 +0200 Message-ID: <87v82x4z9h.fsf@gmail.com> References: <87o78stq7g.fsf@gmail.com> <8734q3u2fz.fsf@gmx.de> <87jzjff7m1.fsf@gmail.com> <87a5kas82t.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3576"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 71213@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 28 19:36:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sC0k6-0000cy-N7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 May 2024 19:36:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sC0jq-0007kp-CT; Tue, 28 May 2024 13:35:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sC0jp-0007kR-1N for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 13:35:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sC0jo-0004BF-PX for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 13:35:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sC0jy-0005Z8-5E for bug-gnu-emacs@gnu.org; Tue, 28 May 2024 13:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 May 2024 17:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71213 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71213-submit@debbugs.gnu.org id=B71213.171691770721290 (code B ref 71213); Tue, 28 May 2024 17:36:02 +0000 Original-Received: (at 71213) by debbugs.gnu.org; 28 May 2024 17:35:07 +0000 Original-Received: from localhost ([127.0.0.1]:48721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC0j4-0005XK-Hl for submit@debbugs.gnu.org; Tue, 28 May 2024 13:35:06 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:53349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC0j1-0005W5-RZ for 71213@debbugs.gnu.org; Tue, 28 May 2024 13:35:05 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-420180b5922so12738895e9.2 for <71213@debbugs.gnu.org>; Tue, 28 May 2024 10:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716917628; x=1717522428; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jRcPSiLGH2vZUS0ANcDeRUfayBmG95sCe5wrOb9NFFc=; b=cmW5GqdKLuDjxMDwA4+D3DSyuUQ8rUDnfDccsAQwDsNmK6XvTxkGY48eaF2mVNcOan vLZ4kqefs2+BtjQmOZgmOZTsI7uMOqL4RNdTnGGyVadLW7Fe5rBvXtfrHsdsaD0u437i zgyQ02OQs/WFuXHIfMJp9DTLIpgSXDHXogWjeJLTBQkVwU02n0H6vJ21hdL4DBTXvEkd 2Ib0N8cSuC31Fb9fQfnbQBUXl8bIXC0cX4k/eB3fjC35BxNod0AwYnIgz4mNkgHaAI5F X9EbipFdjhuaXmU0g5sZW5OlANB24MbNGhg9KyjLFJqsB0ZW5lz6YhSzTjkoPMwr80k8 i2Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716917628; x=1717522428; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jRcPSiLGH2vZUS0ANcDeRUfayBmG95sCe5wrOb9NFFc=; b=MCPV7a71sGpStZtz7ZQpQ99e9thWTUfjkU+Mf7ravmBL0kRoamjY/MLax3Z+acW2Pj U503rRJWmf02Npy0kgML5yGSYqrlpGdYsA6rBnw5b18tl1+GawOqcCLDfvve0+lnGNwF 1Wkz/gS2G7sBqoUYEgJgwB6FNeDz6a+XX4Yler6+Qs2AgkZs6VRsdvay32vIKRsU5tDa 5YfPrGheyd2TZBF2qdyR4warW4hkc+RBOAXFQkz9R6RrpCbUWfoKB+pM+ymDvDv88nfg BVTvaJGcWsRQz+ekZFb62im4QIuInAZfumoLY2BNcYA7BxhcxQ7Putlmmgg6n1lAJupZ 4X9A== X-Gm-Message-State: AOJu0Ywv8WVjpIAtB32eWSkqdKRilxr5dSoKEZ2ldCw9ubzNyLiFZF2y ZDTQswcUVZd0iO9nHcCYxJRacya/e6G7mubmbYb7znlperimaKvrPUJeAA== X-Google-Smtp-Source: AGHT+IFwCrjWvdqJ1+yh2PapTFHroMdEr4uw70pWqstZ3d3o1mMpEE4DGh1WkQovCj7c37MxngCdhw== X-Received: by 2002:a5d:47a6:0:b0:357:bd78:4964 with SMTP id ffacd0b85a97d-357bd784af5mr8175560f8f.27.1716917627741; Tue, 28 May 2024 10:33:47 -0700 (PDT) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3557a1c9546sm12256676f8f.82.2024.05.28.10.33.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 10:33:47 -0700 (PDT) In-Reply-To: <87a5kas82t.fsf@gmx.de> (Michael Albinus's message of "Tue, 28 May 2024 09:34:50 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286103 Archived-At: Michael Albinus writes: >>>> We've done something similar for other icons, e.g. in 2021-11-02 "Use >>>> current face foreground for SVG icons in customize" (11702a6dd7c). I >>>> think it makes sense for these too, since "#2e3436" (and any shade of >>>> not-strictly-gray-but-close-enough) is liable to have low contrast with >>>> the mode line background depending on the theme (e.g. modus-vivendi). >>>> >>>> Let me know what you think. >>> >>> I have absolutely no knowledge about image formats. I've stolen the two >>> files from the Gnome repository, that's it. So I won't object any >>> change. >> >> Right, AFAIU we followed the same approach for the icons I mention above >> (grabbed the icons somewhere, realized their foreground fared poorly >> depending on the background, stripped their 'fill' attribute). > > So I would say it is OK to install your patch. Other people will comment > only if they see an unexpected change, so this is likely the best way to > test your proposal :-) A'ight =F0=9F=AB=A1 thanks for weighing in; will install momentarily then, = after adding the bug# to the changelog.