From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 71213@debbugs.gnu.org
Subject: bug#71213: [PATCH] Use the current face foreground for read-passwd icons
Date: Tue, 28 May 2024 19:33:46 +0200 [thread overview]
Message-ID: <87v82x4z9h.fsf@gmail.com> (raw)
In-Reply-To: <87a5kas82t.fsf@gmx.de> (Michael Albinus's message of "Tue, 28 May 2024 09:34:50 +0200")
Michael Albinus <michael.albinus@gmx.de> writes:
>>>> We've done something similar for other icons, e.g. in 2021-11-02 "Use
>>>> current face foreground for SVG icons in customize" (11702a6dd7c). I
>>>> think it makes sense for these too, since "#2e3436" (and any shade of
>>>> not-strictly-gray-but-close-enough) is liable to have low contrast with
>>>> the mode line background depending on the theme (e.g. modus-vivendi).
>>>>
>>>> Let me know what you think.
>>>
>>> I have absolutely no knowledge about image formats. I've stolen the two
>>> files from the Gnome repository, that's it. So I won't object any
>>> change.
>>
>> Right, AFAIU we followed the same approach for the icons I mention above
>> (grabbed the icons somewhere, realized their foreground fared poorly
>> depending on the background, stripped their 'fill' attribute).
>
> So I would say it is OK to install your patch. Other people will comment
> only if they see an unexpected change, so this is likely the best way to
> test your proposal :-)
A'ight 🫡 thanks for weighing in; will install momentarily then, after
adding the bug# to the changelog.
next prev parent reply other threads:[~2024-05-28 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-26 17:53 bug#71213: [PATCH] Use the current face foreground for read-passwd icons Kévin Le Gouguec
2024-05-27 7:41 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-27 18:11 ` Kévin Le Gouguec
2024-05-28 7:34 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-28 17:33 ` Kévin Le Gouguec [this message]
2024-06-03 17:14 ` Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v82x4z9h.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=71213@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).