From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#72077: 30.0.60; customizing which-key-dont-use-unicode to nil results in nil which-key-separator Date: Sat, 13 Jul 2024 12:48:36 +0000 Message-ID: <87v819o3tn.fsf@posteo.net> References: <87zfqmel65.fsf@gmail.com> <86o771jxtb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6737"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72077@debbugs.gnu.org, Robert Pluim , Justin Burkett To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 13 14:49:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sScBj-0001Ym-6J for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Jul 2024 14:49:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sScBS-0001Qc-O3; Sat, 13 Jul 2024 08:49:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sScBR-0001QT-HS for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 08:49:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sScBR-0003yX-8F for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 08:49:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sScBR-0008Ka-R3 for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 08:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2024 12:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72077 X-GNU-PR-Package: emacs Original-Received: via spool by 72077-submit@debbugs.gnu.org id=B72077.172087492732004 (code B ref 72077); Sat, 13 Jul 2024 12:49:01 +0000 Original-Received: (at 72077) by debbugs.gnu.org; 13 Jul 2024 12:48:47 +0000 Original-Received: from localhost ([127.0.0.1]:55277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sScBD-0008K8-11 for submit@debbugs.gnu.org; Sat, 13 Jul 2024 08:48:47 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:36325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sScBA-0008Ju-Ss for 72077@debbugs.gnu.org; Sat, 13 Jul 2024 08:48:46 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 4504A240101 for <72077@debbugs.gnu.org>; Sat, 13 Jul 2024 14:48:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1720874918; bh=ej1N9BFqlZrtHKvn3i8LzS9qMPLnRHBBoYlmGuMkJuY=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=g+y11QMrVse+0+pzc8ZWY/I6cloVnSSSZ2Gv1NGc79Gi9Q4CcEPwMiyvx0HJ9JBGW IIDcTT+09+3h0PSPp5tpwfGq+nxIupn7fAAFdJboDRNj1atTg1IlbMGwb9venyYmGe mVLbl6DWuF8hUsnqEHuK/Et44+laBS4jPzAJjAk28eqJP7yE2gBTSNTuWM4Oe/UbCD +ynRIrhB93lLlNjBMFCvQx/E+dPWRTZyz3bcSi/V8OPR0EnJzONCZj3ab7NdPcadu3 0BtogruWBqOPQweOuKAnOWZ22PhuUaQNxd1WC3aT4Og/dMDtWZrtzWxs3Ya8o81hSk LJnJsFgd/XbKQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WLpDN74dRz9rxL; Sat, 13 Jul 2024 14:48:36 +0200 (CEST) In-Reply-To: <86o771jxtb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Jul 2024 15:12:00 +0300") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288812 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> Cc: Philip Kaludercic >> From: Robert Pluim >> Date: Fri, 12 Jul 2024 16:31:46 +0200 >>=20 >>=20 >> mkdir /tmp/emacs-30 >> HOME=3D/tmp/emacs-30 src/emacs >> M-x which-key-mode >> M-x customize-variable which-key-dont-use-unicode RET >>=20 >> toggle it to nil, save it, resulting in the following .emacs: >>=20 >> ;;; -*- lexical-binding: t -*- >> (custom-set-variables >> ;; custom-set-variables was added by Custom. >> ;; If you edit it by hand, you could mess it up, so be careful. >> ;; Your init file should contain only one such instance. >> ;; If there is more than one, they won't work right. >> '(which-key-dont-use-unicode nil)) >> (custom-set-faces >> ;; custom-set-faces was added by Custom. >> ;; If you edit it by hand, you could mess it up, so be careful. >> ;; Your init file should contain only one such instance. >> ;; If there is more than one, they won't work right. >> ) >>=20 >> C-x shows which-key using ?=E2=86=92 as separator >>=20 >> >>=20 >> HOME=3D/tmp/emacs-30 src/emacs >>=20 >> C-h v which-key-dont-use-unicode RET >>=20 >> which-key-dont-use-unicode is a variable defined in =E2=80=98which-k= ey.el=E2=80=99. >>=20 >> Its value is nil >> Original value was t >>=20 >> C-h v which-key-separator RET >>=20 >> which-key-separator is a variable defined in =E2=80=98which-key.el= =E2=80=99. >>=20 >> Its value is nil >> Original value was " =E2=86=92 " >>=20 >> C-h v which-key-ellipsis RET >>=20 >> which-key-ellipsis is a variable defined in =E2=80=98which-key.el=E2= =80=99. >>=20 >> Its value is nil >> Original value was "=E2=80=A6" >>=20 >> M-x which-key-mode >> C-x shows which-key using 'nil' as separator > > Justin, any comments or suggestions? This one is on me, I tweaked the 'which-key-dont-use-unicode' user option. The issue here seems to be that `custom-reevaluate-setting' always sets a value, even if there is no `standard-value' associated with a user option. I don't know if we want to change that (certainly not on the release branch), but a quick fix seems to be this: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/which-key.el b/lisp/which-key.el index 973616ef116..49c22be216a 100644 --- a/lisp/which-key.el +++ b/lisp/which-key.el @@ -130,9 +130,10 @@ which-key-dont-use-unicode `which-key-separator'." :set (lambda (sym val) (custom-set-default sym val) - (mapc #'custom-reevaluate-setting - '(which-key-separator - which-key-ellipsis))) + (dolist (sym '(which-key-separator + which-key-ellipsis)) + (when (get sym 'standard-value) + (custom-reevaluate-setting sym)))) :initialize #'custom-initialize-changed :type 'boolean :package-version "1.0" :version "30.1") --=-=-= Content-Type: text/plain -- Philip Kaludercic on peregrine --=-=-=--