From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#73635: dired-do-query-replace-regexp should check if files are selected first Date: Sat, 05 Oct 2024 09:52:08 +0530 Message-ID: <87v7y7b2mn.fsf@gmail.com> References: <87frpbb4cn.3.fsf@jidanni.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13291"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73635@debbugs.gnu.org To: Dan Jacobson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 05 06:24:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swwL9-0003IF-2b for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Oct 2024 06:24:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swwKt-0004Vo-4T; Sat, 05 Oct 2024 00:24:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swwKk-0004VQ-U8 for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2024 00:23:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1swwKk-0007R4-Lt for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2024 00:23:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=M5dRcw8bBnd8fSZ+CV2awuTdv0OyEz3HQmXxYIWVnqQ=; b=b0+RDDaS0Sb57OCCQKT1Ef7gncKZQ6ojfawQp0eudtxbE2nr5yW4ivlklKGx/VRrz57NUF5rvHXZmEVwLmemQhlh8SZiXi0KIwdyqqBNXwgo+vNbn43dx2JI1xY6LT1tvL63Ms+T1ifZp1YhedFtxKZ2OmJRGAttPM6LpYSSo+VFk67h3PmviVXPTS+lJ0rm2d8mXpAVYtsQR2hoXSKSA5ydRUJ1/GXdXI9fdcUrzsAKNAGb6VIPq+2DxR0lU+xXC/Iu+h9pP9mPkHIQr0Ks69QBUz19ytj1jiip2JqVl7z9eYmxhAOC87Xm6rRRZQz9Kv/dbRwP5o3sCjTJkdJo/w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1swwKo-0002th-7I for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2024 00:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Oct 2024 04:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73635 X-GNU-PR-Package: emacs Original-Received: via spool by 73635-submit@debbugs.gnu.org id=B73635.172810220611090 (code B ref 73635); Sat, 05 Oct 2024 04:24:02 +0000 Original-Received: (at 73635) by debbugs.gnu.org; 5 Oct 2024 04:23:26 +0000 Original-Received: from localhost ([127.0.0.1]:37104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swwKD-0002so-T8 for submit@debbugs.gnu.org; Sat, 05 Oct 2024 00:23:26 -0400 Original-Received: from mail-pl1-f194.google.com ([209.85.214.194]:46414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swwKB-0002sb-Th for 73635@debbugs.gnu.org; Sat, 05 Oct 2024 00:23:24 -0400 Original-Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-20b6458ee37so32313425ad.1 for <73635@debbugs.gnu.org>; Fri, 04 Oct 2024 21:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728102134; x=1728706934; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M5dRcw8bBnd8fSZ+CV2awuTdv0OyEz3HQmXxYIWVnqQ=; b=gdZ3BYJ/uDWlwVj4xHylpaaNHHzU9ei+sJlFtDjPPAHAJpeI1vR4eDzmb0msHU7DUw DiiA+NrC75x5zZ1kASFrjdGzLityigB0y1Wz5n9DdP2sl+WhQlVenpcgB82lxBPVyrlq D/uC/X6Jj+9tyKj9k0fpwpa9PM3QMomA8NhBFEyR+3HfAv/r5rDVSusXLV6IlJegEAcL veCuifbnvX3yiQkBpYYPC294JgJcc5meQcuRaqGkVVS8eWz+VenL2oZOf117bCe9X6fT iRWRrZTkimC4d7RLk/HTR4ZypMNrGRk55+eX7SF7/38UF92Hk5/xULYl9c+WgnIXY/0n sJPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728102134; x=1728706934; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M5dRcw8bBnd8fSZ+CV2awuTdv0OyEz3HQmXxYIWVnqQ=; b=ngLGBejtXDWCxtI0iNSQD5qIvLTQiMppktSG0uTlFkx/mVlO+wFWMi9/UdhAYl6kl8 fTsZYN16UBnnkfFXAgGJax6/PhVRSw1ZsBM9bs94YK8WiXPyGkY6E5rmCeocF9RbN+14 VWR7wP3ZLfggfw3Pua+SjXLGnGLwAqLY4/5XLB/ZRko6umsksXv+Gvk2o8nU6Po9hGb2 /flPMoQvRacpGow+gIpSS1tVS6WPlzd93ojB5e9bKlc9xPahjDU4V+wiWOObksAZEuL4 OzXWAPczBKqbhWzGvKO+K5vWoaylxY+7oDmzWuY8WMmN7kUqDeUsxmnpfPSU34yAKF4s 5w3Q== X-Gm-Message-State: AOJu0YzOn+UU124e1gr0y3FdwtybT05jAqWL7Nr6juL5UoLa1IVX5Hkk QrUuQDUAa6Cx7hXXSDngtS8AqBZ7FB8Y1+wOQRbDi3aV9ycjQ6C2 X-Google-Smtp-Source: AGHT+IEGupLIFbIkzQPZ5YOOPN81UL0oWQLnp8mOsO+liYzuSBvlHv1MxlGLhm7TS3JJd4ywe+HsHQ== X-Received: by 2002:a17:902:f602:b0:20b:7f94:9d35 with SMTP id d9443c01a7336-20bfef3368emr85235435ad.48.1728102133627; Fri, 04 Oct 2024 21:22:13 -0700 (PDT) Original-Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20c1398ee12sm5867995ad.287.2024.10.04.21.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2024 21:22:13 -0700 (PDT) In-Reply-To: <87frpbb4cn.3.fsf@jidanni.org> (Dan Jacobson's message of "Sat, 05 Oct 2024 11:44:56 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292997 Archived-At: [=E0=AE=9A=E0=AE=A9=E0=AE=BF =E0=AE=85=E0=AE=95=E0=AF=8D=E0=AE=9F=E0=AF=8B= =E0=AE=AA=E0=AE=B0=E0=AF=8D 05, 2024] Dan Jacobson wrote: > dired-do-query-replace-regexp > asks for the replace from value, > then asks for the replace to value, > and only then finally checks if any files are selected in the first > place. > > It needs to check first. > > E.g., yes there were files selected, but we just did a first run, and > are no longer looking at the dired buffer. We need to go back to the > dired buffer first. Fine. But at least let the user know before they > bother entering the from and to values. It uses the filename under point if there are no marked files like all dired commands.