From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#73932: [PATCH] Add noconfirm to 'package-autoremove' Date: Thu, 21 Nov 2024 21:17:14 +0000 Message-ID: <87v7wgp9r9.fsf@posteo.net> References: <2AA4E1A2-0422-40F5-BFD6-CDAE69996F1F@toadstyle.org> <864j55h0rl.fsf@gnu.org> <487C14D0-1114-49BC-996E-E3C74D17950F@toadstyle.org> <87iktfe2wr.fsf@posteo.net> <3EBD1382-E6F4-43BA-8CAA-39EAD42CC4CD@toadstyle.org> <85D8E91F-CBAE-4314-BDA9-B36C5FF81452@toadstyle.org> <87ttc5usan.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5193"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 73932-done@debbugs.gnu.org, Stefan Kangas To: Sean Devlin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 21 22:18:36 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tEEZQ-0001F4-2X for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Nov 2024 22:18:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tEEZ7-0003ik-F1; Thu, 21 Nov 2024 16:18:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tEEYu-0003gT-0i for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2024 16:18:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tEEYt-0005aZ-2d for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2024 16:18:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=aPNO9vtYdd3YCfcc6E3/Kj0z7gfczF/lyZmXiksnizY=; b=dJNHxb4KTmnxOMJOC5OKOFSh+qRqqj7f6eLLVIK2MTkl3Mh8durxp3dKq8pKajtCVein8h5bFNstXF+9mWsGP4KsI9XaNWzZCGTJuiFxi63P5uJ13vfloSjtD0Bp+S0KkkaozT/yRefspY59VI27xlYS4fQBo7PUKQMJHOVpX7aT9BYprT5hO22uaLnW9KKUC/xnwgPVieCjlmnLqEpJqEgiAx5Na6uH1ns/ktkWUOd7AWz+28Q+2+QGYij7ZB2Rh4yvn2M7ehKB/ztRSKye4xpw82a7d1uudEJr2dq+d20NyuHCrqFA4Qtyn0B5pgt2CssQGmUNPFtbah1Q9hzx4g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tEEYs-0007hN-NH for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2024 16:18:02 -0500 Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Nov 2024 21:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 73932@debbugs.gnu.org, philipk@posteo.net, spd@toadstyle.org Original-Received: via spool by 73932-done@debbugs.gnu.org id=D73932.173222384729543 (code D ref 73932); Thu, 21 Nov 2024 21:18:02 +0000 Original-Received: (at 73932-done) by debbugs.gnu.org; 21 Nov 2024 21:17:27 +0000 Original-Received: from localhost ([127.0.0.1]:51974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEEYI-0007gQ-Lu for submit@debbugs.gnu.org; Thu, 21 Nov 2024 16:17:27 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:56385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tEEYF-0007g6-NN for 73932-done@debbugs.gnu.org; Thu, 21 Nov 2024 16:17:24 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A83E7240027 for <73932-done@debbugs.gnu.org>; Thu, 21 Nov 2024 22:17:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1732223836; bh=A17X6joSCPFsQ78AhCSFee6EMCx1z0mkie7Kw8LeT1k=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=luY3vPM46/+LhU7qWvbwsVv4zabEU5Fx3+cMekXkG2OTfXfXLi17j3NoeEXsYUsgg TFu5SVKaTLxYbqgLMtG/DJAXVcYK0o5XRjwfgecHw0KW4Zuy4xc9b7EZYY14LnIL2w ow/htP7k8iH9YU57KurQOyGsQV4jLR/4fiApvXx6FVYLARIC96hhN1BXFe0FLVWkuM 4Dum1fUH5g3Q0pZu+Jw8i8wTG1dPcWyHUAN7auH2Ocg2tq4xzqH8ksIq/rEOsb12jd RLCeRDToSultL+jG/fErtlwAUTcJF2pXEbSPciYsUocYVo7rl1BqpRdVe7cIn3w+TB CcsaKqf88NqdA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XvWJq2f8Jz9rxB; Thu, 21 Nov 2024 22:17:15 +0100 (CET) In-Reply-To: <87ttc5usan.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 18 Nov 2024 03:36:32 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295757 Archived-At: Philip Kaludercic writes: > Sean Devlin writes: > >> Hi folks, >> >>> On Nov 5, 2024, at 12:45=E2=80=AFPM, Sean Devlin wr= ote: >>>=20 >>> Hi folks, >>>=20 >>>> On Oct 28, 2024, at 10:48=E2=80=AFAM, Sean Devlin = wrote: >>>>=20 >>>> Hi folks, >>>>=20 >>>>> On Oct 27, 2024, at 5:53=E2=80=AFAM, Stefan Kangas >>>>> wrote: >>>>>=20 >>>>> Philip Kaludercic writes: >>>>>=20 >>>>>> Is the variation interesting, where NOCONFIRM is a predicate so that >>>>>> we can selectively remove packages? >>>>>=20 >>>>> Do you have a use case in mind? >>>>>=20 >>>>>>> Sure, that might make sense. If we do that, should we do the >>>>>> same in package-install-selected-packages? It uses its NOCONFIRM >>>>>> argument in a similar way. >>>>>>=20 >>>>>> We can do that in a subsequent patch. >>>>>=20 >>>>> Feel free to post such a patch, indeed. Thanks in advance. >>>>=20 >>>> Here=E2=80=99s two patches: >>>>=20 >>>> <0001-Add-noconfirm-to-package-autoremove.patch><0002-Use-prefix-argum= ent-in-package-install-selected-pack.patch> >>>>=20 >>>> The first is the same as before, but it adds the prefix argument >>>> usage Eli suggested. >>>>=20 >>>> The second patch adds a matching prefix argument to >>>> package-install-selected-packages (if this is desired). >>>>=20 >>>> I didn=E2=80=99t implement a predicate option for NOCONFIRM yet, since= I >>>> couldn=E2=80=99t think of a use case, and the intended semantics are n= ot >>>> quite clear to me. >>>>=20 >>>> Please let me know what else is needed, and thanks! >>>=20 >>> Are there any outstanding issues? If so, how can I help resolve them? >>>=20 >>> Thanks! >> >> Just checking in again. Is there anything I can do to help resolve this? > > Sorry for the delay, I can apply it to master if nobody objects. I've pushed the changes, and will close this report. Thanks! >> Thanks! >> --=20 Philip Kaludercic on siskin