From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 4981@emacsbugs.donarmstrong.com, Dan Nicolaescu <dann@ics.uci.edu>
Subject: bug#4981: C-l during query-replace
Date: Mon, 30 Nov 2009 18:07:45 +0200 [thread overview]
Message-ID: <87tywcqe94.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwvaay45cfa.fsf-monnier+emacsbugreports@gnu.org> (Stefan Monnier's message of "Mon, 30 Nov 2009 09:13:52 -0500")
>> Thanks for fixing this. Are you sure that the new `recenter-positions'
>> is needed? Given that there are 3 choices, it's easy to cycle through
>> them, so adding yet another defcustom that would be use by a very small
>> number of users does not seem justified (IMHO).
>
> I agree that it's overengineering.
I think what is overengineering is adding recenter-top-bottom
in the first place. It imposes the arbitrary fixed cycling order
on users with no hope to customize such fundamental feature as
recentering. `recenter-positions' mitigates this problem in the true
Emacs way as the *customizable* editor.
Please also note that even a minor feature `next-error' allows a similar
customization with `next-error-recenter'. Perhaps we should try to merge
them, or at least provide a new option in `next-error-recenter' to use the
first value of `recenter-positions' as the primary position the user
prefers to put point after recentering.
> This patch is only acceptable if (to compensate) it unifies the two
> duplicate code paths of move-to-window-line-top-bottom and
> recenter-top-bottom.
Do you mean we should merge move-to-window-line-top-bottom and
recenter-top-bottom into one function?
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2009-11-30 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87skbwt9xq.fsf@mail.jurta.org>
2009-11-20 0:16 ` bug#4981: C-l during query-replace Dan Nicolaescu
2009-11-20 9:29 ` Juri Linkov
2009-11-29 23:44 ` Juri Linkov
2009-11-30 1:28 ` Stefan Monnier
2009-11-30 6:29 ` Dan Nicolaescu
2009-11-30 11:12 ` Juanma Barranquero
2009-11-30 12:04 ` Juri Linkov
2009-11-30 14:13 ` Stefan Monnier
2009-11-30 16:07 ` Juri Linkov [this message]
2009-11-30 17:24 ` Drew Adams
2009-11-30 20:55 ` Stefan Monnier
2009-11-30 16:30 ` bug#4981: marked as done (C-l during query-replace) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tywcqe94.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=4981@emacsbugs.donarmstrong.com \
--cc=dann@ics.uci.edu \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).