From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#5476: 23.1.91; bookmark open info node in fundamental mode Date: Wed, 27 Jan 2010 19:23:57 +0100 Organization: ThierryVolpiatto Message-ID: <87tyu7s8xu.fsf@tux.homenetwork> References: <87eildpxqg.fsf@tux.homenetwork> <877hr5pchf.fsf@tux.homenetwork> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1264617652 24826 80.91.229.12 (27 Jan 2010 18:40:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Jan 2010 18:40:52 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 27 19:40:49 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NaCoT-0004Y1-Ja for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jan 2010 19:40:26 +0100 Original-Received: from localhost ([127.0.0.1]:44999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NaCoS-0007KJ-W5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jan 2010 13:40:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NaCo5-00077D-Gs for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 13:40:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NaCo0-000746-U6 for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 13:40:00 -0500 Original-Received: from [199.232.76.173] (port=51298 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NaCo0-000743-NX for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 13:39:56 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:32937) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NaCo0-0004MT-5K for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 13:39:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NaCeS-0005I7-G9; Wed, 27 Jan 2010 13:30:04 -0500 X-Loop: bug-gnu-emacs@gnu.org In-Reply-To: Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Jan 2010 18:30:04 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5476 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.126461698120309 (code B ref -1); Wed, 27 Jan 2010 18:30:04 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Jan 2010 18:29:41 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NaCe4-0005HV-SC for submit@debbugs.gnu.org; Wed, 27 Jan 2010 13:29:41 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NaCe1-0005HG-Gh for submit@debbugs.gnu.org; Wed, 27 Jan 2010 13:29:38 -0500 Original-Received: from mx10.gnu.org ([199.232.76.166]:53576) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NaCdx-0000Cb-29 for submit@debbugs.gnu.org; Wed, 27 Jan 2010 13:29:33 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NaCdu-0002AL-Su for submit@debbugs.gnu.org; Wed, 27 Jan 2010 13:29:32 -0500 Original-Received: from lists.gnu.org ([199.232.76.165]:42219) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NaCdu-0002AF-Ma for submit@debbugs.gnu.org; Wed, 27 Jan 2010 13:29:30 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NaCdu-0002KD-4w for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 13:29:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NaCdp-0002Hq-Gw for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 13:29:29 -0500 Original-Received: from [199.232.76.173] (port=58500 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NaCdp-0002Hk-BM for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 13:29:25 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:36405) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NaCdp-00029P-0E for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 13:29:25 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NaCdh-0003Yy-Fe for bug-gnu-emacs@gnu.org; Wed, 27 Jan 2010 19:29:17 +0100 Original-Received: from 134.77.197-77.rev.gaoland.net ([77.197.77.134]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 27 Jan 2010 19:29:17 +0100 Original-Received: from thierry.volpiatto by 134.77.197-77.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 27 Jan 2010 19:29:17 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 31 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 134.77.197-77.rev.gaoland.net Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUHBARgJRFPS0WbMBTC TSG/uJs0yyVHAAAACXBIWXMAAAsSAAALEgHS3X78AAAACXZwQWcAAAAwAAAAMADO7oxXAAABpUlE QVQ4y3VTQXKDMAyUnD7AwvQOhtxj5N4LFh9ow/+/UtlpM0BczWSS0Wola7UBeEb3+3kJ/5p9ZLz3 UI0n0J0Y4K/lh1nG24FhlJOR2LdSKtpV5gfi/Zd+NdaJBbB4D5N0JnfUIVp6obZURkJwS2a8b9uX AkgxA5gCEcknAH1s2z0DPooWmjGKcJR+HNZt+9bm0GtGRycRuZGs98Ffr02vABWGopIAhmXmxnQN BwBXZjgFLHRoqbfeYxCLWqsjLyKhbEHW+A5nEs699Q2O80ALrgHTmUTy6P0MnKyKQpKHpoNWokxs F0D5VegvWmEozyE6nuMiS98mWzlUQ9bW8qYfqOaFtzWlYCqGeIs6HEyl08jkrxUG9MF5ipXpOOpd ZMoXPPVSLWJiiwNNB+eRSyxJZmQKcacikgucnCRiHuJOLmyYJRDPwOqAvY4pA+Wy+VS8G26BAsdb Ph2Hw7ORy/H0IOG0TnaM8Cp0XrFYyU0v2z8AqkifPVbLZ0qo/gsRg60C7p+8Ov9jrUIxFde+jnAq X42hyp/c+ZcnVyUYBarrqZt3+R8450png3cWKgAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAwOC0wNS0z MVQyMjoxNDoyMiswMjowMK3VBDcAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMDctMTAtMjhUMTc6MDg6 NDgrMDE6MDDLdIcLAAAAEXRFWHRqcGVnOmNvbG9yc3BhY2UAMix1VZ8AAAAgdEVYdGpwZWc6c2Ft cGxpbmctZmFjdG9yADJ4MiwxeDEsMXgxSfqmtAAAAABJRU5ErkJggg== User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1.91 (gnu/linux) Cancel-Lock: sha1:+C6VlepQ+M6LBT6QwsLsxMPjuAM= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -5.9 (-----) Resent-Date: Wed, 27 Jan 2010 13:30:04 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34760 Archived-At: Stefan Monnier writes: >> And then something like this: (need to clean for bookmark.el) > >> ,---- >> | (if (and file (file-readable-p file) (not (buffer-live-p buf))) >> | (with-current-buffer (find-file-noselect file) (setq buf (buffer-name))) >> | ;; No file found. See if a non-file buffer exists for this. If not, raise error. >> | (unless (and buf (get-buffer buf)) >> | (signal 'file-error `("Jumping to bookmark" "No such file or directory" file)))) >> | (set-buffer buf) ;>>>>>>>Now we are in the buffer given by the handler >> `---- > > Again, I think this would be wrong. The fix has to be elsewhere, not in > the generic handler. E.g. in Info-bookmark-jump, maybe. So you have to change completely the way bookmark handlers are implemented.I think it will create repeated code: Function similar to bookmark-default-handler (nearly the same) but specialized for info, if you want to create handler for Gnus, again a similar function with repeated code, etc... Or maybe you have a better idea ? ;-) Actually, bookmark-default-handler, the generic handler, handle only filename and return an error if we don't give a filename, IMHO that's wrong, it should handle filenames _and_ buffers. With bookmark-default-handler build this way it is then easy to create handlers for everything (e.g info, gnus, w3m etc...). -- Thierry Volpiatto