From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Johan =?UTF-8?Q?Bockg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#5849: 23.1.95; completion-auto-help blocks icomplete-mode Date: Sat, 09 Jul 2011 17:00:13 +0200 Message-ID: <87tyavv6rm.fsf@gnu.org> References: <87k4sfi5kp.fsf@stupidchicken.com> <2C116479CF744C2EAAAA4A28CC69F613@us.oracle.com> <87mxxbf8f5.fsf@stupidchicken.com> <87y63hkd4p.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1310223690 11353 80.91.229.12 (9 Jul 2011 15:01:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 9 Jul 2011 15:01:30 +0000 (UTC) Cc: 5849@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 09 17:01:24 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QfZ22-0002sp-9d for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jul 2011 17:01:22 +0200 Original-Received: from localhost ([::1]:56912 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfZ21-0005p2-N8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jul 2011 11:01:21 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:47204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfZ1l-0005oW-NB for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2011 11:01:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QfZ1j-0007RX-DZ for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2011 11:01:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfZ1i-0007RI-U2 for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2011 11:01:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QfZ1i-0002LI-IW; Sat, 09 Jul 2011 11:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Johan =?UTF-8?Q?Bockg=C3=A5rd?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jul 2011 15:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5849 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5849-submit@debbugs.gnu.org id=B5849.13102236248949 (code B ref 5849); Sat, 09 Jul 2011 15:01:02 +0000 Original-Received: (at 5849) by debbugs.gnu.org; 9 Jul 2011 15:00:24 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QfZ14-0002KI-Oz for submit@debbugs.gnu.org; Sat, 09 Jul 2011 11:00:23 -0400 Original-Received: from smtprelay-b22.telenor.se ([195.54.99.213]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QfZ12-0002K2-Da for 5849@debbugs.gnu.org; Sat, 09 Jul 2011 11:00:21 -0400 Original-Received: from ipb3.telenor.se (ipb3.telenor.se [195.54.127.166]) by smtprelay-b22.telenor.se (Postfix) with ESMTP id 4938EEA83F for <5849@debbugs.gnu.org>; Sat, 9 Jul 2011 17:00:14 +0200 (CEST) X-SMTPAUTH-B2: [bocjoh] X-SENDER-IP: [85.228.203.189] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: As5oAItsGE5V5Mu9PGdsb2JhbABThESESJ5ECwEBAQE3Moh6ArMNkASBK4QAgQ8Eox0 X-IronPort-AV: E=Sophos;i="4.65,504,1304287200"; d="scan'208";a="28037060" Original-Received: from c-bdcbe455.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.228.203.189]) by ipb3.telenor.se with ESMTP; 09 Jul 2011 17:00:13 +0200 Original-Received: by muon.localdomain (Postfix, from userid 1000) id 2541B484312; Sat, 9 Jul 2011 17:00:13 +0200 (CEST) Mail-Copies-To: never In-Reply-To: <87y63hkd4p.fsf@stupidchicken.com> (Chong Yidong's message of "Sun, 10 Apr 2011 17:30:46 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 09 Jul 2011 11:01:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:48336 Archived-At: Chong Yidong writes: > I have checked in the patch that I posted earlier for this bug into the > emacs-23 branch, and a more complete fix into the trunk. The latter > involves a new variable completion-show-inline-help, which > icomplete-mode binds to nil. The fix in the trunk sets completion-show-inline-help globally which is not quite right: emacs -Q M-x icomplete-mode RET C-x C-f nonexistingfile TAB =3D> no message Expected: "[No match]" This patch to the current trunk sets completion-show-inline-help locally when icomplete is actually being used (simple completion). 2011-07-09 Johan Bockg=C3=A5rd Fix previous fix of Bug#5849. * icomplete.el (icomplete-mode): Don't set completion-show-inline-help. (icomplete-minibuffer-setup): Set completion-show-inline-help locally during icompletion. =3D=3D=3D modified file 'lisp/icomplete.el' --- lisp/icomplete.el 2011-05-31 03:03:38 +0000 +++ lisp/icomplete.el 2011-07-09 14:01:48 +0000 @@ -179,11 +179,8 @@ (if icomplete-mode ;; The following is not really necessary after first time - ;; no great loss. - (progn - (setq completion-show-inline-help nil) - (add-hook 'minibuffer-setup-hook 'icomplete-minibuffer-setup)) - (remove-hook 'minibuffer-setup-hook 'icomplete-minibuffer-setup) - (setq completion-show-inline-help t))) + (add-hook 'minibuffer-setup-hook 'icomplete-minibuffer-setup) + (remove-hook 'minibuffer-setup-hook 'icomplete-minibuffer-setup))) =20 ;;;_ > icomplete-simple-completing-p () (defun icomplete-simple-completing-p () @@ -209,6 +206,7 @@ "Run in minibuffer on activation to establish incremental completion. Usually run by inclusion in `minibuffer-setup-hook'." (when (and icomplete-mode (icomplete-simple-completing-p)) + (set (make-local-variable 'completion-show-inline-help) nil) (add-hook 'pre-command-hook (lambda () (run-hooks 'icomplete-pre-command-hook)) nil t)