From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#11068: 24.0.94; Face-remapped background does not extend to end of window Date: Sat, 24 Mar 2012 22:17:41 +0800 Message-ID: <87ty1ekrqy.fsf@gnu.org> References: <1BE52A40-0403-433F-8164-DFDBD6771F80@gmail.com> <83ty1fvc28.fsf@gnu.org> <83obrmtbsy.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1332598691 10919 80.91.229.3 (24 Mar 2012 14:18:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 24 Mar 2012 14:18:11 +0000 (UTC) Cc: darthandrus@gmail.com, 11068@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 24 15:18:10 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SBRnE-0000rU-Ho for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Mar 2012 15:18:08 +0100 Original-Received: from localhost ([::1]:51983 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBRnD-0002d6-TO for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Mar 2012 10:18:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBRnB-0002cm-GM for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 10:18:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SBRn9-00008t-Sh for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 10:18:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBRn9-00008p-PP for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 10:18:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SBSH8-0000Jf-4H for bug-gnu-emacs@gnu.org; Sat, 24 Mar 2012 10:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Mar 2012 14:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11068-submit@debbugs.gnu.org id=B11068.13326005391207 (code B ref 11068); Sat, 24 Mar 2012 14:49:02 +0000 Original-Received: (at 11068) by debbugs.gnu.org; 24 Mar 2012 14:48:59 +0000 Original-Received: from localhost ([127.0.0.1]:37007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBSH4-0000JP-Mm for submit@debbugs.gnu.org; Sat, 24 Mar 2012 10:48:59 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:46876) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBSGz-0000JE-3U for 11068@debbugs.gnu.org; Sat, 24 Mar 2012 10:48:57 -0400 Original-Received: from bb121-6-68-206.singnet.com.sg ([121.6.68.206]:34522 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SBRmx-0000PO-Mz; Sat, 24 Mar 2012 10:17:52 -0400 In-Reply-To: <83obrmtbsy.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Mar 2012 14:37:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58084 Archived-At: Eli Zaretskii writes: > /* Face extension extends the background and box of IT->face_id > to the end of the line. If the background equals the background > of the frame, we don't have to do anything. */ > if (it->face_before_selective_p) > face = FACE_FROM_ID (f, it->saved_face_id); > + else if (it->face_id == DEFAULT_FACE_ID) > + face = default_face; > else > face = FACE_FROM_ID (f, it->face_id); This looks a bit strange. Why is DEFAULT_FACE_ID handled specially here? Shouldn't we be checking for face remapping no matter what the face_id is?