From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code Date: Wed, 25 Apr 2012 20:42:36 +0200 Message-ID: <87ty07hcv7.fsf@gmail.com> References: <0CC212AF2EA740A0B8FE5EEF91077A2D@us.oracle.com> <9DC04CC6E710430F90675022247AF8C1@us.oracle.com> <6D7414BA5657418E9D2AB4D0AA0E71A3@us.oracle.com> <87y5pk53ra.fsf@spindle.srvr.nix> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1335379456 25787 80.91.229.3 (25 Apr 2012 18:44:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 25 Apr 2012 18:44:16 +0000 (UTC) To: 11328@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 25 20:44:15 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SN7CI-0000Dh-Jw for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Apr 2012 20:44:14 +0200 Original-Received: from localhost ([::1]:53079 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SN7CH-0000lk-UO for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Apr 2012 14:44:13 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SN7CE-0000lU-Fc for bug-gnu-emacs@gnu.org; Wed, 25 Apr 2012 14:44:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SN7CC-0000sr-OF for bug-gnu-emacs@gnu.org; Wed, 25 Apr 2012 14:44:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SN7CC-0000sn-L4 for bug-gnu-emacs@gnu.org; Wed, 25 Apr 2012 14:44:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SN7D4-0007q5-2a for bug-gnu-emacs@gnu.org; Wed, 25 Apr 2012 14:45:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <0CC212AF2EA740A0B8FE5EEF91077A2D@us.oracle.com> Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Apr 2012 18:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.133537944130036 (code B ref -1); Wed, 25 Apr 2012 18:45:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Apr 2012 18:44:01 +0000 Original-Received: from localhost ([127.0.0.1]:53011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SN7C5-0007oC-2v for submit@debbugs.gnu.org; Wed, 25 Apr 2012 14:44:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37568) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SN7C0-0007nv-Gg for submit@debbugs.gnu.org; Wed, 25 Apr 2012 14:43:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SN7B1-0000nq-WC for submit@debbugs.gnu.org; Wed, 25 Apr 2012 14:42:57 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:34418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SN7B1-0000nk-Sb for submit@debbugs.gnu.org; Wed, 25 Apr 2012 14:42:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SN7B0-0000kn-8T for bug-gnu-emacs@gnu.org; Wed, 25 Apr 2012 14:42:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SN7Ay-0000nQ-Cn for bug-gnu-emacs@gnu.org; Wed, 25 Apr 2012 14:42:53 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:47802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SN7Ay-0000nD-5t for bug-gnu-emacs@gnu.org; Wed, 25 Apr 2012 14:42:52 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SN7At-0007RR-IM for bug-gnu-emacs@gnu.org; Wed, 25 Apr 2012 20:42:47 +0200 Original-Received: from lbe83-2-78-243-104-167.fbx.proxad.net ([78.243.104.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 25 Apr 2012 20:42:47 +0200 Original-Received: from thierry.volpiatto by lbe83-2-78-243-104-167.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 25 Apr 2012 20:42:47 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 14 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: lbe83-2-78-243-104-167.fbx.proxad.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) Cancel-Lock: sha1:kjXuOojUSczeTyb0bQligGrvAkA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59488 Archived-At: Hi Drew, about fluid variables in dired code, particularly in `dired-create-files', I would say instead of fluid "obscure", as they are variables that must be in any calls of `dired-create-files' within a lambda used as argument of this function. I think it would be better to have explicit arg in the caller and have also the lambda's there. The code would be easier to read and understand and no need to have obscure comments such as "fluid variable...etc". -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997