From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.bugs Subject: bug#11095: [PATCH] Re: bug#11095: 24.0.94; hi-lock-face-buffer/unhighlight-regexp': Augment? Date: Thu, 06 Dec 2012 03:45:54 +0530 Message-ID: <87txs09mcl.fsf@gmail.com> References: <81d37z271c.fsf@gmail.com> <87626i2i4r.fsf@gmail.com> <61B14D03B48D4D9E998771D3B7E4252C@us.oracle.com> <82F792DC51D24C39AEBFEE9BC6CBE335@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1354745641 26193 80.91.229.3 (5 Dec 2012 22:14:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 5 Dec 2012 22:14:01 +0000 (UTC) Cc: 11095@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 05 23:14:12 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TgNEI-0001Jl-Vt for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Dec 2012 23:14:11 +0100 Original-Received: from localhost ([::1]:52319 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgNE7-0008Rs-04 for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Dec 2012 17:13:59 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgNE4-0008R9-0g for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2012 17:13:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TgNE1-0000Ig-IW for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2012 17:13:55 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TgNE1-0000IW-Ez for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2012 17:13:53 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TgNEA-0004Sy-Cj for bug-gnu-emacs@gnu.org; Wed, 05 Dec 2012 17:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jambunathan K Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Dec 2012 22:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11095 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11095-submit@debbugs.gnu.org id=B11095.135474559317103 (code B ref 11095); Wed, 05 Dec 2012 22:14:02 +0000 Original-Received: (at 11095) by debbugs.gnu.org; 5 Dec 2012 22:13:13 +0000 Original-Received: from localhost ([127.0.0.1]:55402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgNDN-0004Ro-8U for submit@debbugs.gnu.org; Wed, 05 Dec 2012 17:13:13 -0500 Original-Received: from mail-pa0-f44.google.com ([209.85.220.44]:35549) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TgNDK-0004Re-FE for 11095@debbugs.gnu.org; Wed, 05 Dec 2012 17:13:11 -0500 Original-Received: by mail-pa0-f44.google.com with SMTP id hz11so3718265pad.3 for <11095@debbugs.gnu.org>; Wed, 05 Dec 2012 14:13:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=o8P/FoIU6I1UGEzOU/+tsgJv0+mCByEUZFlKRfuajVY=; b=iA19bvWMTafXXuVvOsiriiJmkkQ6+WBuRVszm1yiwodY98d/vo/aSiblJt+GK8pC/a FvePEzHYGbsbBHVEm0NyP+u8MNvKq0IOCuev1cXjw1Mx7HoCybCKajbC280MUmarCE/i JBU+5Uycf3A5u96dsdq6yjNtpj7vO+Ott/dVYjN7QOttSDotiCgtVX60E+OVjTmsMq+5 Epe07OW3uNLaW5xpaCk/qAxI3/pzC4j9+Z+uUXueOZBQfL4lc9m9xZujWGN7K8mp2F3k h4HBpIJQEJT1Nyb4fM1bKIDT5EfoKHbLOQ1jsuVU6FKva0kJCuvT0vChv/S7g5xlDkuJ s6zw== Original-Received: by 10.66.79.133 with SMTP id j5mr48242023pax.51.1354745580229; Wed, 05 Dec 2012 14:13:00 -0800 (PST) Original-Received: from debian-6.05 ([101.62.57.252]) by mx.google.com with ESMTPS id ok3sm3538271pbb.11.2012.12.05.14.12.56 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 05 Dec 2012 14:12:58 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Tue, 04 Dec 2012 22:46:23 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67991 Archived-At: Stefan Monnier writes: >>> I think the real issue here is that hi-lock should have a customizable >>> set of faces rather than a set of customizable faces. >>> So if the user doesn't like hi-yellow (which should be called >>> hi-lock-yellow, BTW) because she never highlights in yellow, she can >>> replace it with her own face with the name she likes. >> Ah, in that case you are really talking, I think, about having one or >> more user options, which each has a face (or a set of faces) as value. > > Just one option `hi-lock-faces'. 1. I want the name to be opaque and semantic. 2. I also want a pre-defined set of faces for highlighting apart from the one "core" highlight face. I think there are 9 hi-* faces and these numbers are good enough. Think of them as extra colors in my palette. Having a set of highlighting faces will help in theming. For example, consider finding file in ido-mode. When I do C-x C-f, I see various faces - the minibuffer prompt, ido-first-match, ido-subdir, ido-indicator all occurring /next/ to each other. If there are hi-lock-N faces, chosen by a theme designed, one can simply have ido faces inherit from these themed faces. It is much cleaner. Remember choosing faces that can co-exist in buffer without much trouble to eyes is challenging task - one needs to balance harmony and contrast. A theme designer is likely to work with a palette and can go with color-picking techniques like triad, tetrad schemes. See http://colorschemedesigner.com/ http://www.w3.org/wiki/Colour_theory http://packages.debian.org/squeeze/agave Triad and tetrads apparently are colors that are 120 and 90 degrees apart in the color wheel. So if there are N highlighting faces, they can be spaced 360/N degree apart in a color wheeel. Drew's reasoning that it is the N-th highlighting face in a sequence. 3. Configuring an yellow face in red is a bit ugly. It is declaring a variable name FALSE that is assigned a variable value true. >> Just why would you prefer a "customizable set of faces" over a "set of >> customizable faces"? And how does that relate to the names? > > Because the user can then choose the names that make sense to her. While reading a face name from minibuffer, if the face name itself is highlighted in that face - think rainbow mode - then the name of the face shouldn't matter. What you are asking for is a constant face whose properties don't change at all. One can have an elpa packages which provides constant faces, that are immediately useful.