From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#13426: Frame parameter fullscreen and maximized Date: Sun, 13 Jan 2013 12:16:23 +0200 Organization: JURTA Message-ID: <87txql2xs8.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1358072281 8204 80.91.229.3 (13 Jan 2013 10:18:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Jan 2013 10:18:01 +0000 (UTC) To: 13426@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 13 11:18:19 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TuKdt-00056T-BD for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Jan 2013 11:18:17 +0100 Original-Received: from localhost ([::1]:49263 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuKdd-0001iI-4m for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Jan 2013 05:18:01 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuKdT-0001fZ-J3 for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 05:18:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuKdN-0002hf-5V for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 05:17:51 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuKdN-0002hV-25 for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 05:17:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TuKde-000347-9k for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 05:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Jan 2013 10:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.135807227711770 (code B ref -1); Sun, 13 Jan 2013 10:18:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Jan 2013 10:17:57 +0000 Original-Received: from localhost ([127.0.0.1]:57707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TuKdZ-00033m-5d for submit@debbugs.gnu.org; Sun, 13 Jan 2013 05:17:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:44328) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TuKdX-00033a-Qd for submit@debbugs.gnu.org; Sun, 13 Jan 2013 05:17:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuKd5-0002fc-Bq for submit@debbugs.gnu.org; Sun, 13 Jan 2013 05:17:33 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:58839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuKd5-0002fY-9I for submit@debbugs.gnu.org; Sun, 13 Jan 2013 05:17:27 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuKcy-0001Ww-KL for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 05:17:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuKcr-0002eA-Pq for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 05:17:20 -0500 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:38592 helo=ps18281.dreamhostps.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuKcr-0002dz-K8 for bug-gnu-emacs@gnu.org; Sun, 13 Jan 2013 05:17:13 -0500 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 12EC1258B9E91F for ; Sun, 13 Jan 2013 02:17:11 -0800 (PST) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69708 Archived-At: There are two problems discovered at http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00203.html 1. On non-GTK builds when the Gnome system key M-f10 maximizes the frame, Emacs doesn't reflect this change in the frame parameter `fullscreen'. The test case that demonstrates this problem: 1. emacs -Q 2. Eval (frame-parameter nil 'fullscreen) => nil 3. Maximize the frame using Gnome system keys. 4. Eval (frame-parameter nil 'fullscreen) => nil 5. Maximize the frame using `M-x toggle-frame-maximized RET' 6. Eval (frame-parameter nil 'fullscreen) => 'maximized Running xprop on the maximized frame outputs: _NET_WM_STATE(ATOM) = _NET_WM_STATE_MAXIMIZED_VERT, _NET_WM_STATE_MAXIMIZED_HORZ 2. On GTK builds there is another problem: evaluating (set-frame-parameter nil 'fullscreen 'fullscreen) modifies the frame parameter `fullscreen' to `fullboth', not to `fullscreen' as requested. In this case xprop outputs: _NET_WM_STATE(ATOM) = _NET_WM_STATE_FULLSCREEN Second call of (set-frame-parameter nil 'fullscreen 'fullscreen) modifies the frame parameter `fullscreen' from `fullboth' to `fullscreen'. So to go to `fullscreen' requires two calls of (set-frame-parameter nil 'fullscreen 'fullscreen) Maybe the second problem could be fixed with a patch like below where `toggle-frame-fullscreen' checks for `fullboth' as an alias for `fullscreen': === modified file 'lisp/frame.el' --- lisp/frame.el 2013-01-03 00:36:36 +0000 +++ lisp/frame.el 2013-01-13 10:13:09 +0000 @@ -1666,7 +1666,7 @@ (defun toggle-frame-maximized () after disabling fullscreen mode. See also `toggle-frame-fullscreen'." (interactive) - (if (eq (frame-parameter nil 'fullscreen) 'fullscreen) + (if (memq (frame-parameter nil 'fullscreen) '(fullscreen fullboth)) (modify-frame-parameters nil `((maximized @@ -1690,10 +1690,10 @@ (defun toggle-frame-fullscreen () (modify-frame-parameters nil `((maximized - . ,(unless (eq (frame-parameter nil 'fullscreen) 'fullscreen) + . ,(unless (memq (frame-parameter nil 'fullscreen) '(fullscreen fullboth)) (frame-parameter nil 'fullscreen))) (fullscreen - . ,(if (eq (frame-parameter nil 'fullscreen) 'fullscreen) + . ,(if (memq (frame-parameter nil 'fullscreen) '(fullscreen fullboth)) (if (eq (frame-parameter nil 'maximized) 'maximized) 'maximized) 'fullscreen)))))