From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.bugs Subject: bug#12218: 24.2.50; vc-ediff: Pressing `n' moves focus away from ediff control panel Date: Wed, 13 Feb 2013 11:04:19 +0530 Message-ID: <87txpgrd44.fsf@gmail.com> References: <87pq6pvmw4.fsf@gmail.com> <506F076B.9040204@gmx.at> <874nm8alm4.fsf@gmail.com> <506F21F5.1050208@gmx.at> <877gr44v08.fsf@gmail.com> <506F3001.1030305@gmx.at> <87391sg0z4.fsf@gmail.com> <506FE852.5020603@gmx.at> <87k3v3ebo3.fsf@mail.jurta.org> <50727922.7010301@gmx.at> <87r4p919r7.fsf@mail.jurta.org> <878v6wmo7j.fsf@mail.jurta.org> <5117D9C9.9050608@gmx.at> <87k3qf9oog.fsf@mail.jurta.org> <87621zb2yb.fsf@gmail.com> <87zjz9r733.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1360733739 26115 80.91.229.3 (13 Feb 2013 05:35:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Feb 2013 05:35:39 +0000 (UTC) Cc: 12218@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 13 06:35:59 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U5V0e-0002w6-7R for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Feb 2013 06:35:56 +0100 Original-Received: from localhost ([::1]:45019 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5V0K-0006SC-Nk for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Feb 2013 00:35:36 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5V0H-0006S7-RF for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2013 00:35:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U5V0G-0006dM-BD for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2013 00:35:33 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5V0G-0006d8-7V for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2013 00:35:32 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U5V0j-0001HX-Gr for bug-gnu-emacs@gnu.org; Wed, 13 Feb 2013 00:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jambunathan K Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Feb 2013 05:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12218-submit@debbugs.gnu.org id=B12218.13607337444884 (code B ref 12218); Wed, 13 Feb 2013 05:36:01 +0000 Original-Received: (at 12218) by debbugs.gnu.org; 13 Feb 2013 05:35:44 +0000 Original-Received: from localhost ([127.0.0.1]:53116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U5V0S-0001Gj-0t for submit@debbugs.gnu.org; Wed, 13 Feb 2013 00:35:44 -0500 Original-Received: from mail-pa0-f44.google.com ([209.85.220.44]:34011) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U5V0O-0001GY-V8 for 12218@debbugs.gnu.org; Wed, 13 Feb 2013 00:35:42 -0500 Original-Received: by mail-pa0-f44.google.com with SMTP id kp1so508091pab.3 for <12218@debbugs.gnu.org>; Tue, 12 Feb 2013 21:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=Jy1dBUr9rC/SMl52F/DWM/c46m/Deoo1DNTrWERmDCs=; b=R8LD5fp2r7QH8zMA/laHdnKj21xwqPtIguTGCoaY4XIsAc47UKQ7ulY5sRoR1N1Zvy c+UIBQ5/D+ULPRubGPRh5srFo/wBiKG6M5Bl149Pc6Rol8nvrHWY15efgI99/Cd5yRyX Kyv1mIktaWUk4gOrXivjlO4lhMFpYvZgiceJAtyPrsdR13du8VhW7U9V8xuq2laZYQjI ibZPV8UrvOzZE2y5/eCaIgTcFTy23y/+d49INBMPiIwnTwajSVNFc8ISucOT0iyPATdQ GHwnE2DZWB63oQDA5gpZ9ufnnAzrizEaRzQva8DnFgdFxwqgDECHN6WFKPHvIP49SFOl +Idg== X-Received: by 10.66.78.1 with SMTP id x1mr60183354paw.2.1360733707804; Tue, 12 Feb 2013 21:35:07 -0800 (PST) Original-Received: from debian-6.05 ([115.241.62.17]) by mx.google.com with ESMTPS id o5sm80565893pay.5.2013.02.12.21.35.04 (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Tue, 12 Feb 2013 21:35:07 -0800 (PST) In-Reply-To: <87zjz9r733.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 12 Feb 2013 19:47:31 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71143 Archived-At: I recommend that this patch be applied. Works for me on my XFCE sytem. Juri Linkov writes: >>> But unfortunately I can't reproduce this bug reliably >>> to try various solutions. >> >> If you circulate a diff, I can try it out, as many times as you want. > > Please try this patch: > > === modified file 'lisp/vc/ediff-util.el' > --- lisp/vc/ediff-util.el 2013-01-03 00:36:36 +0000 > +++ lisp/vc/ediff-util.el 2013-02-12 17:47:25 +0000 > @@ -786,7 +786,11 @@ (defun ediff-recenter (&optional no-rehi > (frame-live-p ediff-control-frame) > (not ediff-use-long-help-message) > (not (ediff-frame-iconified-p ediff-control-frame))) > - (raise-frame ediff-control-frame)) > + (if (fboundp 'select-frame-set-input-focus) > + (select-frame-set-input-focus ediff-control-frame) > + (raise-frame ediff-control-frame) > + (select-frame ediff-control-frame) > + (focus-frame ediff-control-frame))) > > ;; Redisplay whatever buffers are showing, if there is a selected difference > (let ((control-frame ediff-control-frame)