From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#14567: Scrolling of large images Date: Sun, 16 Jun 2013 08:18:57 +0200 Organization: Emacs Helm Message-ID: <87txky60j2.fsf@gmail.com> References: <83ppvzur6i.fsf@gnu.org> <83obbjuov4.fsf@gnu.org> <83vc5osn0r.fsf@gnu.org> <83obbgsg33.fsf@gnu.org> <83k3m4sar0.fsf@gnu.org> <83ehccromw.fsf@gnu.org> <87bo7cpfpk.fsf@engster.org> <83li6bvl2i.fsf@gnu.org> <87bo77d9vt.fsf@engster.org> <83d2rnvhkw.fsf@gnu.org> <877ghvd6tq.fsf@engster.org> <87mwqrpqym.fsf@gmail.com> <83a9mrvcmi.fsf@gnu.org> <837ghvv94e.fsf@gnu.org> <87ip1epqkj.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1371363610 20548 80.91.229.3 (16 Jun 2013 06:20:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 16 Jun 2013 06:20:10 +0000 (UTC) To: 14567@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 16 08:20:10 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uo6Jt-0004tZ-Kr for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Jun 2013 08:20:09 +0200 Original-Received: from localhost ([::1]:41227 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uo6Jt-00008w-6B for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Jun 2013 02:20:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uo6Jq-00007d-3B for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2013 02:20:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uo6Jo-0006Gg-4j for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2013 02:20:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uo6Jo-0006GK-1e for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2013 02:20:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Uo6Jm-0005oZ-NN for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2013 02:20:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jun 2013 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.137136356722246 (code B ref -1); Sun, 16 Jun 2013 06:20:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Jun 2013 06:19:27 +0000 Original-Received: from localhost ([127.0.0.1]:47474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uo6JC-0005mj-Ql for submit@debbugs.gnu.org; Sun, 16 Jun 2013 02:19:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51704) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uo6J9-0005mT-C0 for submit@debbugs.gnu.org; Sun, 16 Jun 2013 02:19:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uo6J2-00063r-S4 for submit@debbugs.gnu.org; Sun, 16 Jun 2013 02:19:17 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:40547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uo6J2-00063n-P9 for submit@debbugs.gnu.org; Sun, 16 Jun 2013 02:19:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uo6J0-0008Iv-7H for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2013 02:19:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uo6Iy-00062Q-K5 for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2013 02:19:14 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:46420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uo6Iy-00062A-Da for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2013 02:19:12 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Uo6Iw-0003oY-Vg for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2013 08:19:10 +0200 Original-Received: from 37.160.0.8 ([37.160.0.8]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 16 Jun 2013 08:19:10 +0200 Original-Received: from thierry.volpiatto by 37.160.0.8 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 16 Jun 2013 08:19:10 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 62 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 37.160.0.8 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:f2tjPhMiYkpX35ivwl/YC/Pdgpg= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:75195 Archived-At: Thierry Volpiatto writes: > Eli Zaretskii writes: > >>> Date: Sat, 15 Jun 2013 14:26:13 +0300 >>> From: Eli Zaretskii >>> Cc: 14567@debbugs.gnu.org >>> >>> > From: Thierry Volpiatto >>> > Date: Sat, 15 Jun 2013 13:13:05 +0200 >>> > >>> > however it would be great to be able to scroll horizontally too. >>> >>> That's a much larger project, since we lack infrastructure to scroll >>> horizontally by pixels. >> >> Actually, I see that I was wrong: set-window-hscroll can do the job. >> The only problem is to get C-f/C-b and / keys invoke that >> function when appropriate. Patches are welcome. > > I don't understand how to use this, it is actually setting the number of > column where to start scrolling, and it seems an image have only one > column? > > Though only setting `auto-hscroll-mode' to nil let move with C-f/b and > left/right as expected, may be this value should be let-bounded when > image-mode is detected? I saw auto-hscroll-mode was already used, but have no effect, when moving it to image-mode and make it buffer-local, it is working. However, navigation in image looks a little slower than scrolling vertically, but maybe I am wrong. diff --git a/lisp/image-mode.el b/lisp/image-mode.el index 30dfd04..fdede81 100644 --- a/lisp/image-mode.el +++ b/lisp/image-mode.el @@ -446,7 +446,8 @@ to toggle between display as an image and display as text." (kill-all-local-variables) (setq major-mode 'image-mode) - + ;; Allow navigation of large images. + (set (make-variable-buffer-local 'auto-hscroll-mode) nil) (if (not (image-get-display-property)) (progn (image-toggle-display-image) @@ -643,8 +644,6 @@ was inserted." (if (coding-system-equal (coding-system-base buffer-file-coding-system) 'no-conversion) (setq-local find-file-literally t)) - ;; Allow navigation of large images. - (setq-local auto-hscroll-mode nil) (setq image-type type) (if (eq major-mode 'image-mode) (setq mode-name (format "Image[%s]" type))) -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997