bug#14738: 24.3.50; defcustom :type (repeat (cons symbol plist)) when nil is the default value.

bug#14738: 24.3.50; defcustom :type (repeat (cons symbol plist)) when nil is the default value.

[Jambunathan K]

1,2 below is a minor bug.
3,4 is a major bug.

0. C-M-x the below defcustom.  This is copied verbatim from gnus-art.el
1. M-x customize-variable RET gnus-face-properties-alist RET
2. The first PROP VALUE pair in the widget is more indented than the rest.

3. Change the standard value to nil.  C-M-x it.
4. Note that the INS DEL button for the plist is not available.  i.e., I
   cannot add more than one PROP VALUE pair.

(defcustom gnus-face-properties-alist (if (featurep 'xemacs)
					  '((xface . (:face gnus-x-face)))
					'((pbm . (:face gnus-x-face))
					  (png . nil)))
  "Alist of image types and properties applied to Face and X-Face images.
Here are examples:

;; Specify the altitude of Face images in the From header.
\(setq gnus-face-properties-alist
      '((pbm . (:face gnus-x-face :ascent 80))
	(png . (:ascent 80))))

;; Show Face images as pressed buttons.
\(setq gnus-face-properties-alist
      '((pbm . (:face gnus-x-face :relief -2))
	(png . (:relief -2))))

See the manual for the valid properties for various image types.
Currently, `pbm' is used for X-Face images and `png' is used for Face
images in Emacs.  Only the `:face' property is effective on the `xface'
image type in XEmacs if it is built with the libcompface library."
  :version "23.1" ;; No Gnus
  :group 'gnus-article-headers
  :type '(repeat (cons :format "%v" (symbol :tag "Image type") plist)))


In GNU Emacs 24.3.50.2 (i686-pc-linux-gnu, GTK+ Version 2.20.1)
 of 2013-06-27 on debian-6.05
Bzr revision: 113207 rgm@gnu.org-20130627161405-syv3a92xxzm15p2b
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
Important settings:
  value of $LANG: en_IN
  locale-coding-system: iso-latin-1-unix
  default enable-multibyte-characters: t

bug#14738: 24.3.50; defcustom :type (repeat (cons symbol plist)) when nil is the default value.

[Drew Adams]

> 0. C-M-x the below defcustom.  This is copied verbatim from gnus-art.el
> 1. M-x customize-variable RET gnus-face-properties-alist RET
> 2. The first PROP VALUE pair in the widget is more indented than the rest.
> 
> 3. Change the standard value to nil.  C-M-x it.
> 4. Note that the INS DEL button for the plist is not available.  i.e., I
>    cannot add more than one PROP VALUE pair.

FWIW, I do not see that behavior with emacs -Q in this build:

In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-06-27 on ODIEONE
Bzr revision: 113205 dgutov@yandex.ru-20130627095155-f1lv1c7xf99g1sss
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
 CFLAGS=-O0 -g3 LDFLAGS=-Lc:/Devel/emacs/lib
 CPPFLAGS=-Ic:/Devel/emacs/include'

It behaves normally, AFAICT.  With nil as the default value,
I get a INS button, and after clicking it I get another one
(at the same level), so I can define any number of PROP VALUE pairs.

HTH.

bug#14738: 24.3.50; defcustom :type (repeat (cons symbol plist)) when nil is the default value.

[Jambunathan K]

Drew Adams <drew.adams@oracle.com> writes:

>> 0. C-M-x the below defcustom.  This is copied verbatim from gnus-art.el
>> 1. M-x customize-variable RET gnus-face-properties-alist RET
>> 2. The first PROP VALUE pair in the widget is more indented than the rest.
>> 
>> 3. Change the standard value to nil.  C-M-x it.
>> 4. Note that the INS DEL button for the plist is not available.  i.e., I
>>    cannot add more than one PROP VALUE pair.
>
> FWIW, I do not see that behavior with emacs -Q in this build:
>
> In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
>  of 2013-06-27 on ODIEONE
> Bzr revision: 113205 dgutov@yandex.ru-20130627095155-f1lv1c7xf99g1sss
> Windowing system distributor `Microsoft Corp.', version 6.1.7601
> Configured using:
>  `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
>  CFLAGS=-O0 -g3 LDFLAGS=-Lc:/Devel/emacs/lib
>  CPPFLAGS=-Ic:/Devel/emacs/include'
>
> It behaves normally, AFAICT.  With nil as the default value,
> I get a INS button, and after clicking it I get another one
> (at the same level), so I can define any number of PROP VALUE pairs.

This is what I see with emacs -Q. 

Should be a XFCE, Debian/Squeeze issue?

,----
| Hide Gnus Face Properties Alist:
| INS DEL Image type: nil
|             Plist:             
|             Key: nil        <=================== Missing INS DEL
|             Value: nil
| INS
|     State : EDITED, shown value does not take effect until you set or save it.
|    Alist of image types and properties applied to Face and X-Face images. Hide
|    Here are examples:
`----
   


> HTH.

bug#14738: 24.3.50; defcustom :type (repeat (cons symbol plist)) when nil is the default value.

[Drew Adams]

> This is what I see with emacs -Q.
> 
> Should be a XFCE, Debian/Squeeze issue?
> 
> ,----
> | Hide Gnus Face Properties Alist:
> | INS DEL Image type: nil
> |             Plist:
> |             Key: nil        <=================== Missing INS DEL
> |             Value: nil
> | INS
> |     State : EDITED, shown value does not take effect until you set or save
> it.
> |    Alist of image types and properties applied to Face and X-Face images.
> Hide
> |    Here are examples:
> `----

This is what I see, with nil as the default value of the option:

,----
| Hide Gnus Face Properties Alist:
| INS
|     State : STANDARD.
|    Alist....
| Groups: Gnus Article Headers
`----

And this is what I see, with the default value you gave originally:

,----
| Hide Gnus Face Properties Alist:
| INS DEL Image type: pbm
|             Plist:
|                         INS DEL Key: :face
|                         Value: gnus-x-face
|             INS
| INS DEL Image type: png
|             Plist:
|                         INS
| INS
|     State : STANDARD.
|    Alist....
| Groups: Gnus Article Headers
`----

HTH.

bug#14738: 24.3.50; defcustom :type (repeat (cons symbol plist)) when nil is the default value.

[Jambunathan K]

Drew Adams <drew.adams@oracle.com> writes:

> This is what I see, with nil as the default value of the option:
>
> ,----
> | Hide Gnus Face Properties Alist:
> | INS
> |     State : STANDARD.
> |    Alist....
> | Groups: Gnus Article Headers
> `----

What if you try to INS now?  Does the plist have INS buttons?

bug#14738: 24.3.50; defcustom :type (repeat (cons symbol plist)) when nil is the default value.

[Drew Adams]

> > This is what I see, with nil as the default value of the option:
> >
> > ,----
> > | Hide Gnus Face Properties Alist:
> > | INS
> > |     State : STANDARD.
> > |    Alist....
> > | Groups: Gnus Article Headers
> > `----
> 
> What if you try to INS now?  Does the plist have INS buttons?

No, I see the same problem.

Plus, with the non-nil default value, the two INS buttons in the
Plist field act the same (there should not be two, one paired
with DEL and one alone).  Plus, all but the first INS DEL pair
are indented differently from the first pair.

bug#14738: 24.3.50; defcustom :type (repeat (codrew.adams@oracle.comns symbol plist)) when nil is the default value.

[Katsumi Yamaoka]

Drew Adams wrote:
>>> This is what I see, with nil as the default value of the option:
>>>
>>> ,----
>>>| Hide Gnus Face Properties Alist:
>>>| INS
>>>|     State : STANDARD.
>>>|    Alist....
>>>| Groups: Gnus Article Headers
>>> `----
>>
>> What if you try to INS now?  Does the plist have INS buttons?

> No, I see the same problem.

Maybe I am the culprit.  This seems to be a side effect of:

2013-01-07  Katsumi Yamaoka  <yamaoka@jpl.org>

	* wid-edit.el (widget-default-get): Work for inlined elements.
	(Bug#12670)

cf. http://news.gmane.org/group/gmane.emacs.bugs/thread=65693

> Plus, with the non-nil default value, the two INS buttons in the
> Plist field act the same (there should not be two, one paired
> with DEL and one alone).

I'm going to fix it, but

> Plus, all but the first INS DEL pair are indented differently
> from the first pair.

this seems to be due to another cause since reverting my patch
doesn't help.

bug#14738: 24.3.50; defcustom :type (repeat (codrew.adams@oracle.comns symbol plist)) when nil is the default value.

[Katsumi Yamaoka]

Katsumi Yamaoka wrote:
> Maybe I am the culprit.  This seems to be a side effect of:

> 2013-01-07  Katsumi Yamaoka  <yamaoka@jpl.org>
> 	* wid-edit.el (widget-default-get): Work for inlined elements.
> 	(Bug#12670)

> cf. http://news.gmane.org/group/gmane.emacs.bugs/thread=65693

Fixed.

[...]

>> Plus, all but the first INS DEL pair are indented differently
>> from the first pair.

> this seems to be due to another cause since reverting my patch
> doesn't help.

I guess what controls the indentation may be the built-in function
widget-apply or widget-put.  If so, I'm not capable to fix it.

bug#14738: 24.3.50; defcustom :type (repeat (codrew.adams@oracle.comns symbol plist)) when nil is the default value.

[Jambunathan K]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Katsumi Yamaoka wrote:
>> Maybe I am the culprit.  This seems to be a side effect of:
>
>> 2013-01-07  Katsumi Yamaoka  <yamaoka@jpl.org>
>> 	* wid-edit.el (widget-default-get): Work for inlined elements.
>> 	(Bug#12670)
>
>> cf. http://news.gmane.org/group/gmane.emacs.bugs/thread=65693
>
> Fixed.

Verified, Thanks.

> [...]
>
>>> Plus, all but the first INS DEL pair are indented differently
>>> from the first pair.
>
>> this seems to be due to another cause since reverting my patch
>> doesn't help.
>
> I guess what controls the indentation may be the built-in function
> widget-apply or widget-put.  If so, I'm not capable to fix it.

I will open new bug for this.