unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Kenjiro NAKAYAMA <knakayam@redhat.com>
To: 15967@debbugs.gnu.org
Subject: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened
Date: Mon, 25 Nov 2013 00:15:52 +0900	[thread overview]
Message-ID: <87txf1j0ev.fsf@dhcp-193-97.nrt.redhat.com> (raw)

Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it
doesn't save current URL in eww-history.

Signed-off-by: Kenjiro NAKAYAMA <knakayam@redhat.com>

        * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'.

---
 lisp/net/eww.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 6f09d86..738136b 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1065,7 +1065,7 @@ The browser to used is specified by the `shr-external-browser' variable."
     ;; just let it remain.
     (ignore-errors
       (delete-window))
-    (eww (plist-get bookmark :url))))
+    (eww-browse-url (plist-get bookmark :url))))

 (defun eww-next-bookmark ()
   "Go to the next bookmark in the list."
--
1.8.3.1





         reply	other threads:[~2013-11-24 15:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-16 11:03 bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts Kenjiro NAKAYAMA
2013-11-21 16:47 ` Ted Zlatanov
2013-11-22  3:26 ` Masatake YAMATO
2013-11-22 16:15   ` Ted Zlatanov
2013-11-24 15:15     ` Kenjiro NAKAYAMA [this message]
2013-11-25 14:54       ` bug#15910: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s Ted Zlatanov
2013-11-26 11:51         ` bug#15966: " Kenjiro NAKAYAMA
2013-11-26 20:10           ` bug#15910: " Ted Zlatanov
2013-11-24 15:57     ` Kenjiro NAKAYAMA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txf1j0ev.fsf@dhcp-193-97.nrt.redhat.com \
    --to=knakayam@redhat.com \
    --cc=15967@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).