From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#17218: 24.3; Dired does not insert subdirs when used with switch "--group-directories-first" Date: Tue, 08 Apr 2014 11:45:55 +0300 Organization: JURTA Message-ID: <87txa4jjjw.fsf@mail.jurta.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1396946848 21471 80.91.229.3 (8 Apr 2014 08:47:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Apr 2014 08:47:28 +0000 (UTC) Cc: Tu Do , 17218@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 08 10:47:20 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WXRgd-0007Bx-I4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Apr 2014 10:47:19 +0200 Original-Received: from localhost ([::1]:38802 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXRgd-0003QY-53 for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Apr 2014 04:47:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXRgT-0003QQ-Mw for bug-gnu-emacs@gnu.org; Tue, 08 Apr 2014 04:47:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXRgM-0004jp-85 for bug-gnu-emacs@gnu.org; Tue, 08 Apr 2014 04:47:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXRgM-0004ji-4R for bug-gnu-emacs@gnu.org; Tue, 08 Apr 2014 04:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WXRgL-0007no-Qm for bug-gnu-emacs@gnu.org; Tue, 08 Apr 2014 04:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Apr 2014 08:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17218 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17218-submit@debbugs.gnu.org id=B17218.139694680629967 (code B ref 17218); Tue, 08 Apr 2014 08:47:01 +0000 Original-Received: (at 17218) by debbugs.gnu.org; 8 Apr 2014 08:46:46 +0000 Original-Received: from localhost ([127.0.0.1]:40275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXRg5-0007nH-Ne for submit@debbugs.gnu.org; Tue, 08 Apr 2014 04:46:46 -0400 Original-Received: from homie-vserver77.dreamhost.com ([69.163.149.154]:37225 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXRg3-0007mH-0u for 17218@debbugs.gnu.org; Tue, 08 Apr 2014 04:46:43 -0400 Original-Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.184.122]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7BF9B34CB016BC; Tue, 8 Apr 2014 01:46:41 -0700 (PDT) In-Reply-To: (Drew Adams's message of "Mon, 7 Apr 2014 09:00:56 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87869 Archived-At: >> I found out the problem in the function "dired-insert-old-subdirs" >> at line 1367 in dired.el. > > There is a similar problem in `dired-sort-R-check' and > `dired-build-subdir-alist'. > > [There probably should be a function that checks for a given switch, > and does not just use `string-match-p' in such a simple way. > (At least it should respect case etc.)] Dired could use something like `ange-ftp-switches-ok' that implements a better check for the -R switch.