From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#20206: 25.0.50; [PATCH] keep diff-mode's window visible when we visit sources from diff-mode Date: Sat, 28 Mar 2015 14:53:38 -0700 Message-ID: <87twx4wztk.fsf@secretsauce.net> References: <87a8yzy5t4.fsf@secretsauce.net> <551456ED.8060101@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1427579787 2932 80.91.229.3 (28 Mar 2015 21:56:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Mar 2015 21:56:27 +0000 (UTC) Cc: 20206@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 28 22:56:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YbyiC-0004X7-9l for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Mar 2015 22:56:12 +0100 Original-Received: from localhost ([::1]:55360 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbyiB-0002GU-5l for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Mar 2015 17:56:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ybyi7-00029k-1g for bug-gnu-emacs@gnu.org; Sat, 28 Mar 2015 17:56:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ybyi2-0006J1-Sb for bug-gnu-emacs@gnu.org; Sat, 28 Mar 2015 17:56:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ybyi2-0006In-QN for bug-gnu-emacs@gnu.org; Sat, 28 Mar 2015 17:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Ybyi2-00042H-Hl for bug-gnu-emacs@gnu.org; Sat, 28 Mar 2015 17:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Mar 2015 21:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20206-submit@debbugs.gnu.org id=B20206.142757974715486 (code B ref 20206); Sat, 28 Mar 2015 21:56:02 +0000 Original-Received: (at 20206) by debbugs.gnu.org; 28 Mar 2015 21:55:47 +0000 Original-Received: from localhost ([127.0.0.1]:39155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ybyhn-00041i-96 for submit@debbugs.gnu.org; Sat, 28 Mar 2015 17:55:47 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:52665) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ybyhl-00041Z-Eg for 20206@debbugs.gnu.org; Sat, 28 Mar 2015 17:55:45 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 40F2F20A0A for <20206@debbugs.gnu.org>; Sat, 28 Mar 2015 17:55:42 -0400 (EDT) Original-Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Sat, 28 Mar 2015 17:55:45 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=tvgmP SjaFoytj7DtniHdcG/q9Tw=; b=cUd37aC6BQcUH7167xof7gVHNuNRSv9wcqMw3 9aQwSQzAfdDIHLMAzPOTeuhvKqhXcsw/TskUHr4qPmYG04I0rmI0I0Mk6ZYmNHFG h7BKC+ueONTyolFySUuiWSdZplUKV4+8Ti39VyTOxe3HTNYhXzq+VFAt6NSLQg9V qIfNa0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=tvgmPSjaFoytj7DtniHdcG/q9Tw=; b=fzP3z Gu7y0fxt576TqIG4Fcjw+GTOcASXqj+YMejeHK1LXqfVV2TuFUKzn3HiXAUjyDtM AHYzXiB64nK9ewSHs+crmCs8Cig2PUAky52IoY4I62KtwVHj9rGfsg6x6flNuCfS c+Yi0IY+PCdc2j78+FYe33mxSbT1aN+YMuTqPA= X-Sasl-enc: skpNIgmSYRSzfFJFkp6amU114qWPKn6WHAaWlsx0ox+b 1427579744 Original-Received: from shorty.local (unknown [104.35.103.243]) by mail.messagingengine.com (Postfix) with ESMTPA id E6D676800BE; Sat, 28 Mar 2015 17:55:44 -0400 (EDT) Original-Received: from ip6-localhost ([::1] helo=shorty) by shorty.local with esmtp (Exim 4.84) (envelope-from ) id 1Ybyit-0006lJ-Kx; Sat, 28 Mar 2015 14:56:55 -0700 In-reply-to: <551456ED.8060101@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101006 Archived-At: martin rudalics writes: > > + (pop-to-buffer (current-buffer) '(display-buffer-use-some-window (inhibit-same-window . t))) > > In any case `display-buffer-use-some-window' as sole action doesn't look > right. It should be preceded by `display-buffer-reuse-window' and > `display-buffer-pop-up-window'. To be clear, this action came from two desires: 1. The (inhibit-same-window . t) is there to get the dont-cover-up-control-buffer behavior 2. The display-buffer-pop-up-window action is there to handle bug 19901. There the user already has two windows, and by default a third is created. It's less obvious to me which is the "right" behavior here, but the earlier behavior of reusing the window seems reasonable.