From: Dima Kogan <dima@secretsauce.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 20206@debbugs.gnu.org
Subject: bug#20206: 25.0.50; [PATCH] keep diff-mode's window visible when we visit sources from diff-mode
Date: Sat, 28 Mar 2015 14:53:38 -0700 [thread overview]
Message-ID: <87twx4wztk.fsf@secretsauce.net> (raw)
In-Reply-To: <551456ED.8060101@gmx.at>
martin rudalics <rudalics@gmx.at> writes:
> > + (pop-to-buffer (current-buffer) '(display-buffer-use-some-window (inhibit-same-window . t)))
>
> In any case `display-buffer-use-some-window' as sole action doesn't look
> right. It should be preceded by `display-buffer-reuse-window' and
> `display-buffer-pop-up-window'.
To be clear, this action came from two desires:
1. The (inhibit-same-window . t) is there to get the
dont-cover-up-control-buffer behavior
2. The display-buffer-pop-up-window action is there to handle bug 19901.
There the user already has two windows, and by default a third is
created. It's less obvious to me which is the "right" behavior here, but
the earlier behavior of reusing the window seems reasonable.
next prev parent reply other threads:[~2015-03-28 21:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 18:25 bug#20206: 25.0.50; [PATCH] keep diff-mode's window visible when we visit sources from diff-mode Dima Kogan
2015-03-26 18:41 ` Eli Zaretskii
2015-03-26 18:58 ` martin rudalics
2015-03-28 6:01 ` Dima Kogan
2015-03-28 9:58 ` martin rudalics
2015-03-28 21:44 ` Dima Kogan
2015-03-29 18:00 ` martin rudalics
2015-03-29 20:06 ` Dima Kogan
2015-03-30 8:37 ` martin rudalics
2015-03-28 21:53 ` Dima Kogan [this message]
2015-03-29 18:01 ` martin rudalics
2015-03-29 19:48 ` Dima Kogan
2015-03-30 8:37 ` martin rudalics
2019-06-25 17:33 ` Lars Ingebrigtsen
2019-06-25 18:10 ` Dima Kogan
[not found] <552BB316.1000204@gmx.at>
2015-04-13 14:34 ` Eli Zaretskii
2015-04-14 15:51 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twx4wztk.fsf@secretsauce.net \
--to=dima@secretsauce.net \
--cc=20206@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).