From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.bugs Subject: bug#21638: 25.0.50; font-lock for CSS variables Date: Tue, 06 Oct 2015 11:57:07 -0600 Message-ID: <87twq3ev7w.fsf@tromey.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1444154552 650 80.91.229.3 (6 Oct 2015 18:02:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 Oct 2015 18:02:32 +0000 (UTC) To: 21638@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 06 20:02:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from eggs.gnu.org ([208.118.235.92]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZjWZ6-0004mj-A2 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Oct 2015 20:02:16 +0200 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjWY1-0000hB-K1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Oct 2015 14:02:15 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:58548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjWY1-0000fe-BP for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Oct 2015 14:01:09 -0400 Original-Received: from localhost ([::1]:53034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjWY0-0003jB-QD for geb-bug-gnu-emacs@m.gmane.org; Tue, 06 Oct 2015 14:01:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjWX3-0003cG-Rv for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 14:01:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjWVz-0004Bp-Cs for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 14:00:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjWVy-00046k-CG for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 13:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZjWVx-0000ce-TG for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 13:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tom Tromey Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Oct 2015 17:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14441543382381 (code B ref -1); Tue, 06 Oct 2015 17:59:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Oct 2015 17:58:58 +0000 Original-Received: from localhost ([127.0.0.1]:57345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjWVt-0000cI-57 for submit@debbugs.gnu.org; Tue, 06 Oct 2015 13:58:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60131) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZjWVp-0000c8-P0 for submit@debbugs.gnu.org; Tue, 06 Oct 2015 13:58:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjWVd-0003II-4E for submit@debbugs.gnu.org; Tue, 06 Oct 2015 13:58:53 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:39493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjWVc-0003I4-Vb for submit@debbugs.gnu.org; Tue, 06 Oct 2015 13:58:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjWVF-0002Ze-3b for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 13:58:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjWUQ-0002Mn-Pu for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 13:58:17 -0400 Original-Received: from gproxy9-pub.mail.unifiedlayer.com ([69.89.20.122]:52575) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1ZjWUQ-0002I7-8B for bug-gnu-emacs@gnu.org; Tue, 06 Oct 2015 13:57:26 -0400 Original-Received: (qmail 2357 invoked by uid 0); 6 Oct 2015 17:57:17 -0000 Original-Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy9.mail.unifiedlayer.com with SMTP; 6 Oct 2015 17:57:17 -0000 Original-Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id Rtx91r00L2f2jeq01txCnl; Tue, 06 Oct 2015 11:57:15 -0600 X-Authority-Analysis: v=2.1 cv=VOBOwb/X c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=zstS-IiYAAAA:8 a=PnD2wP_eR3oA:10 a=meFa6WQr8mcA:10 a=5lJygRwiOn0A:10 a=XgxIVdyZSTaTZ_yyjngA:9 a=CHPn04y0Lino2KIm:21 a=rhVO9XaKcrhFbxXy:21 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=qdrjs+3gGgMBDZ4MXzBVqd7iV8g0hAkkCj1874AE3DE=; b=pPT52rXTyRCWJHFNXHFrNAGprB+02vKBpuTqxUUK96hMF/s6st53+LtJoTr3p/9g+Og+PezN8eZ5fmJOK+PtoWsBL7kJHnkjEyFQTVNtwUhVzMpkBTsJlvB1AONotw3x; Original-Received: from [65.128.91.114] (port=45252 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.84) (envelope-from ) id 1ZjWUA-0007qd-IR; Tue, 06 Oct 2015 11:57:10 -0600 X-Attribution: Tom X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 65.128.91.114 authed with tom+tromey.com} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 Xref: news.gmane.org gmane.emacs.bugs:107382 Archived-At: Right now CSS mode doesn't treat CSS variable definitions as properties. I think it should. Here's the patch that worked for me: diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 5f4eebd..97dd8ab 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -289,7 +289,7 @@ css--font-lock-keywords nil))) ;; Properties. Again, we don't limit ourselves to css-property-ids. (,(concat "\\(?:[{;]\\|^\\)[ \t]*\\(" - "\\(?:\\(" css-proprietary-nmstart-re "\\)\\|" + "\\(?:\\(" css-proprietary-nmstart-re "\\)\\|--\\|" css-nmstart-re "\\)" css-nmchar-re "*" "\\)\\s-*:") (1 (if (match-end 2) 'css-proprietary-property 'css-property))) Tom In GNU Emacs 25.0.50.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6) of 2015-10-06 Repository revision: b8adff8426a4532a0971e9a470d3347aafd99b35 Windowing system distributor 'Fedora Project', version 11.0.11702000 Configured using: 'configure --prefix=/home/tromey/Emacs/install/ --with-file-notification=no' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: CSS Minor modes in effect: bug-reference-prog-mode: t diff-auto-refine-mode: t erc-spelling-mode: t erc-truncate-mode: t flyspell-mode: t which-function-mode: t projectile-global-mode: t projectile-mode: t erc-notify-mode: t erc-notifications-mode: t erc-services-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-netsplit-mode: t erc-hl-nicks-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t savehist-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t auto-fill-function: #[128 \300\301\302.#\207 [apply smie-auto-fill #[128 \301\302\300!."\207 [normal-auto-fill-function apply default-value] 4 (fn &rest ARGS)] nil] 5 nil] transient-mark-mode: t Recent messages: ") (put-text-property (point) (match-end 0) (quote font-lock-multiline) t) nil))) ("\\(?:[{;]\\|^\\)[ ]*\\(\\(?:\\([-_]\\(?:khtml\\|m\\(?:oz\\|s\\)\\|o\\|webkit\\)-\\)\\|--\\|\\(?:[[:alpha:]]\\|\\\\\\(?:[^.-]\\|[0-9a-fA-F]+[ . ]?\\)\\)\\)\\(?:[-[:alnum:]]\\|\\\\\\(?:[^.-]\\|[0-9a-fA-F]+[ . ]?\\)\\)*\\)\\s-*:" (1 (if (match-end 2) (quote css-proprietary-property) (quote css-property)))) ("url\\((\\)[[:space:]]*\\(?:\\\\.\\|[^()[:space:] '\"]\\)+[[:space:]]*\\()\\)" (1 (quote default) t) (2 (quote default) t))) Mark set Mark saved where search started Saving file /home/tromey/firefox-git/tree-2/devtools/client/styleinspector/test/doc_copystyles.css... Wrote /home/tromey/firefox-git/tree-2/devtools/client/styleinspector/test/doc_copystyles.css Finding changes in /home/tromey/Emacs/emacs/lisp/textmodes/css-mode.el...done Quit [4 times] funcall-interactively: No recursive edit is in progress Load-path shadows: /home/tromey/.emacs.d/elpa/bubbles-0.5/bubbles hides /home/tromey/Emacs/install/share/emacs/25.0.50/lisp/play/bubbles Features: (shadow mail-hist emacsbug whitespace css-mode texinfo git-commit-mode log-edit pcvs-util smerge-mode gnus-fun eieio-opt speedbar sb-image ezimage dframe dabbrev git-rebase-mode flow-fill misearch multi-isearch add-log bug-reference js json cc-mode cc-fonts cc-guess cc-menus cc-cmds gnus-html url-cache mm-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars shr-color shr dom browse-url mm-archive bbdb-gui bbdb-hooks bbdb-rmail rmailsum rmail sort smiley gnus-cite gnus-bcklg gnus-async qp gnus-ml disp-table copyright vc-mtn vc-hg vc-git diff-mode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs term/xterm xterm gnus-topic nndraft nnmh nnfolder utf-7 bbdb-gnus bbdb-snarf mail-extr bbdb-com warnings gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg nntp gnus-cache gnus-registry registry eieio-compat eieio-base gnus-art mm-uu mml2015 mm-view mml-smime smime dig mailcap gnus-sum gnus-group gnus-undo smtpmail sendmail gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus gnus-ems nnheader mail-utils gnutls network-stream nsm starttls tls erc-spelling erc-truncate flyspell ispell diminish appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs which-func imenu projectile ibuf-macs ibuf-ext ibuffer minimap autorevert filenotify desktop frameset cus-start cus-load erc-notify erc-desktop-notifications notifications dbus xml erc-services erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match erc-netsplit erc-hl-nicks color erc-button erc-fill erc-stamp wid-edit erc-goodies erc erc-backend erc-compat format-spec auth-source eieio byte-opt bytecomp byte-compile cl-extra cconv gnus-util mm-util help-fns mail-prsvr password-cache thingatpt pp status dired-aux dired-x dired advice vc-dir ewoc vc vc-dispatcher flycheck derived easy-mmode cl-seq edmacro kmacro find-func help-mode rx subr-x dash jka-compr sh-script smie executable compile let-alist cc-styles cc-align cc-engine cc-vars cc-defs bbdb cl timezone ange-ftp comint ansi-color ring server savehist finder-inf bbdb-autoloads dwarf-mode-autoloads eieio-core cl-macs gv cl-loaddefs pcase cl-lib lisppaste-autoloads pydoc-info-autoloads info-look weblogger-autoloads info package easymenu epg-config time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1584563 702016) (symbols 48 102069 0) (miscs 40 23022 3346) (strings 32 661191 206096) (string-bytes 1 24535493) (vectors 16 104304) (vector-slots 8 2294514 218530) (floats 8 874 1102) (intervals 56 38889 1534) (buffers 976 98) (heap 1024 301266 64795))