unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 21669@debbugs.gnu.org
Subject: bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64
Date: Fri, 23 Oct 2015 13:31:29 +0200	[thread overview]
Message-ID: <87twphkei6.fsf@gmx.de> (raw)
In-Reply-To: <5627B74F.8080600@cs.ucla.edu> (Paul Eggert's message of "Wed, 21 Oct 2015 09:03:27 -0700")

Paul Eggert <eggert@cs.ucla.edu> writes:

Hi Paul,

> I'm not sure for the failure I already sent you since I've git pulled
> since then, but I just now reran the tests in master commit
> f6ece2420c3dc6f3dde06c7f8722f5b0b7e1ef4a (which postdates the commit
> you mention) and am still seeing intermittent failures.

Finally, I could fix it. Puhhh.

In fact, there were two problems:

- `write-region' fires in the local case just `created' and `changed'
  events.  In the remote case, it fires `created', `changed' and
  `attribute-changed' events. This is because Tramp calls internally
  `set-file-modes' on the newly created file.

- In the test case `file-notify-test02-events-remote' not all events did
  arrive in time, because there was a fast sequence `write-region',
  `set-file-modes', `delete-file'. So I had to introduce short
  `sleep-for' calls between those functions.

I've committed a fix for both problems (and for one unrelated error in
filenotify.el I found also). I've run file-notify-tests.el 20 times now,
no error again. Could you, pls, recheck?

Best regards, Michael.





  parent reply	other threads:[~2015-10-23 11:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-11 22:35 bug#21669: 25.0.50; file-notify-tests failure on Fedora x86-64 Paul Eggert
2015-10-12 11:14 ` Michael Albinus
2015-10-13  1:36   ` Paul Eggert
2015-10-13  7:46     ` Michael Albinus
2015-10-16 20:20       ` Paul Eggert
2015-10-17  9:27         ` Michael Albinus
2015-10-21  1:34           ` Paul Eggert
2015-10-21  8:01             ` Michael Albinus
2015-10-21 16:03               ` Paul Eggert
2015-10-21 18:25                 ` Michael Albinus
2015-10-23 11:31                 ` Michael Albinus [this message]
2015-10-31  8:31                   ` Michael Albinus
2015-10-31 12:49                   ` Paul Eggert
2015-10-31 13:36                     ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87twphkei6.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=21669@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).