From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alex Newsgroups: gmane.emacs.bugs Subject: bug#23590: 25.0.94; Errors in default lgrep command Date: Sat, 23 Jul 2016 16:12:55 -0600 Message-ID: <87twfg0zrs.fsf@gmail.com> References: <87futcp8wp.fsf@gmail.com> <83fur0x0ft.fsf@gnu.org> <87fur0clhm.fsf@gmail.com> <83a8h8utdm.fsf@gnu.org> <838twsuskk.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1469312065 783 80.91.229.3 (23 Jul 2016 22:14:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Jul 2016 22:14:25 +0000 (UTC) Cc: john.b.mastro@gmail.com, 23590@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 24 00:14:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bR5BV-0006U8-Qd for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Jul 2016 00:14:14 +0200 Original-Received: from localhost ([::1]:53850 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bR5BU-0000W9-Sx for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Jul 2016 18:14:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bR5BO-0000W1-D2 for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2016 18:14:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bR5BK-00048q-65 for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2016 18:14:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bR5BK-00048a-2b for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2016 18:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bR5BJ-0004ks-No for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2016 18:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jul 2016 22:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23590 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23590-submit@debbugs.gnu.org id=B23590.146931199818218 (code B ref 23590); Sat, 23 Jul 2016 22:14:01 +0000 Original-Received: (at 23590) by debbugs.gnu.org; 23 Jul 2016 22:13:18 +0000 Original-Received: from localhost ([127.0.0.1]:35186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bR5Ac-0004jl-Ec for submit@debbugs.gnu.org; Sat, 23 Jul 2016 18:13:18 -0400 Original-Received: from mail-io0-f196.google.com ([209.85.223.196]:33869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bR5Ab-0004jZ-Fg for 23590@debbugs.gnu.org; Sat, 23 Jul 2016 18:13:17 -0400 Original-Received: by mail-io0-f196.google.com with SMTP id g86so9647631ioj.1 for <23590@debbugs.gnu.org>; Sat, 23 Jul 2016 15:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ntTkKit9Xn4Uxrrx+d8j5bFXdtocJfpCBrdvvax//UQ=; b=zbU7U3XHEbpTkByoBramLwgA5053M6vdLPWEmi9ubptD4oh0QLcbGNXI5BxqG48kMQ uuIh7vqc56bZcZX+1TkoswVLfHOJproo4jSmcvrtSTNC5+H4FNB1u3FejZyNMRHBQIid vD35Hc5EZuYg8AcksIzsx/lxggvxldYv7myA6W5Qa7/lVKU6TF1jy0+daqaH7mRJKifz sh1jgnV2odIDc120xRkgyucJSkZNX5Z2ZwMmwRBPU1Ua0fe+TDwVLOk7eg0fq70Uw7dM pvhSPfqVC6zA9Yy7lHx2XUfkyx6W+qt3LdPuog7c1hYkBTsyjHgJEAZlCSDeNLh76G2l WOEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ntTkKit9Xn4Uxrrx+d8j5bFXdtocJfpCBrdvvax//UQ=; b=bHrD0OzB8fT5TlwdIUdsVXwa3eouklrpJLbwxor38DRph5UqbtCsvXnWucBOvBelIa QsLyXgtGzt0xe7qFHLCt7fCkP0GtHNaw8ypVJzFysFjTmm5uwgTDEqaqGwpehB37j8mJ XeSoag9nzwQYm9N7yhGXC2dZBvX0oD+o5fgUzOlB0txZPXRcHIc0fED61Maa0txk9KpV qfb1+iSm+CUO8gHOLnhJT05HSnFazyXyDF277HaTRwbEFz9VnNvsVMcZ/b0qZ2HE+SZV ImSjulsB7yMwtAy3vEgL8mO/9FiUBdxqqRlMkTB9gqGMtBQGWRr/zvNQolkKWIfr0ZWG tIMA== X-Gm-Message-State: AEkoouuys3OVSQClYiP/sKeDXNL3j1a7uffVuN3X+etYvdKSUjRlKhwxuTvoOueEjsSaWg== X-Received: by 10.107.15.218 with SMTP id 87mr14685363iop.0.1469311992007; Sat, 23 Jul 2016 15:13:12 -0700 (PDT) Original-Received: from lylat (S01061859339e9903.ss.shawcable.net. [174.2.107.88]) by smtp.gmail.com with ESMTPSA id b66sm5700291itd.0.2016.07.23.15.13.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 23 Jul 2016 15:13:11 -0700 (PDT) In-Reply-To: <838twsuskk.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 23 Jul 2016 21:18:03 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121477 Archived-At: Eli Zaretskii writes: >> Date: Sat, 23 Jul 2016 21:00:37 +0300 >> From: Eli Zaretskii >> Cc: john.b.mastro@gmail.com, 23590@debbugs.gnu.org >> >> > Grep exited abnormally with code 2 at ... >> >> Because of this: >> >> > grep: ..?*: No such file or directory > > Actually, I see that "Is a directory" also caused exit code of 2. So > I guess patches are welcome to add --directory=skip to the Grep > command when a preliminary test reveals that Grep supports it. Is the following patch acceptable? diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el index f04a722..c696f75 100644 --- a/lisp/progmodes/grep.el +++ b/lisp/progmodes/grep.el @@ -573,10 +573,14 @@ This function is called from `compilation-filter-hook'." grep-template grep-find-template) (let ((grep-options (concat (if grep-use-null-device "-n" "-nH") - (if (grep-probe grep-program - `(nil nil nil "-e" "foo" ,null-device) - nil 1) - " -e")))) + (when (grep-probe grep-program + `(nil nil nil "--directories=skip" "foo" ,null-device) + nil 1) + " --directories=skip") + (when (grep-probe grep-program + `(nil nil nil "-e" "foo" ,null-device) + nil 1) + " -e")))) (unless grep-command (setq grep-command (format "%s %s %s " grep-program