From: Alex <agrambot@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 24766@debbugs.gnu.org
Subject: bug#24766: 26.0.50: [PATCH] Confusing behaviour for indent-relative-maybe
Date: Sun, 23 Oct 2016 14:43:57 -0600 [thread overview]
Message-ID: <87twc2iynm.fsf@gmail.com> (raw)
In-Reply-To: <83a8dvpor2.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 23 Oct 2016 09:23:45 +0300")
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> Like I said, I don't think the behavior should be changed, only the
> documentation, which is somewhat misleading. If we want some
> different behavior, we could have a new function, or a new value of
> the argument to indent-relative.
>
> Thanks.
What about changing `indent-relative-maybe' and adding an extra argument
to `indent-relative'? Since `indent-relative-maybe' has had that
docstring for a good 15 years, and the name fits the new behaviour more.
Then in Emacs core we can replace the single instance of it with
(indent-relative t). The corresponding diff:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: second time --]
[-- Type: text/x-diff, Size: 1430 bytes --]
diff --git a/lisp/indent.el b/lisp/indent.el
index 0f6c68d..675b6b8 100644
--- a/lisp/indent.el
+++ b/lisp/indent.el
@@ -566,9 +566,9 @@ indent-relative-maybe
See also `indent-relative'."
(interactive)
- (indent-relative t))
+ (indent-relative nil t))
-(defun indent-relative (&optional unindented-ok)
+(defun indent-relative (&optional first-only unindented-ok)
"Space out to under next indent point in previous nonblank line.
An indent point is a non-whitespace character following whitespace.
The following line shows the indentation points in this line.
@@ -594,17 +594,18 @@ indent-relative
(if (> (current-column) start-column)
(backward-char 1))
(or (looking-at "[ \t]")
- unindented-ok
+ first-only
(skip-chars-forward "^ \t" end))
(skip-chars-forward " \t" end)
(or (= (point) end) (setq indent (current-column))))))
- (if indent
- (let ((opoint (point-marker)))
- (indent-to indent 0)
- (if (> opoint (point))
- (goto-char opoint))
- (move-marker opoint nil))
- (tab-to-tab-stop))))
+ (cond (indent
+ (let ((opoint (point-marker)))
+ (indent-to indent 0)
+ (if (> opoint (point))
+ (goto-char opoint))
+ (move-marker opoint nil)))
+ (unindented-ok nil)
+ (t (tab-to-tab-stop)))))
(defcustom tab-stop-list nil
"List of tab stop positions used by `tab-to-tab-stop'.
next prev parent reply other threads:[~2016-10-23 20:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 19:01 bug#24766: 26.0.50: [PATCH] Confusing behaviour for indent-relative-maybe Alex
2016-10-22 19:21 ` Eli Zaretskii
2016-10-22 19:40 ` Alex
2016-10-22 19:48 ` Eli Zaretskii
2016-10-22 21:49 ` Alex
2016-10-23 6:23 ` Eli Zaretskii
2016-10-23 20:43 ` Alex [this message]
2016-10-24 8:23 ` Eli Zaretskii
2016-10-24 19:27 ` Alex
2016-10-24 19:57 ` Eli Zaretskii
2016-11-08 1:53 ` Alex
2016-11-08 15:07 ` Eli Zaretskii
2016-11-08 19:09 ` Alex
2016-11-08 20:26 ` Eli Zaretskii
2016-11-18 9:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twc2iynm.fsf@gmail.com \
--to=agrambot@gmail.com \
--cc=24766@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).