From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#16984: dired-do-rename susceptible to .../~/... hijack Date: Thu, 08 Dec 2016 15:58:43 +0100 Message-ID: <87twaefows.fsf@gmx.de> References: <87eh2aq60w.fsf@jidanni.org> <87pomrst3z.fsf@users.sourceforge.net> <837f8zpnih.fsf@gnu.org> <87pomjrita.fsf@users.sourceforge.net> <83pomjr63z.fsf@gnu.org> <87eg2zb860.fsf@gmx.de> <87h97vqhf3.fsf@users.sourceforge.net> <874m3vazx2.fsf@gmx.de> <87wpgoowsx.fsf@users.sourceforge.net> <874m2jpl8c.fsf@gmx.de> <87a8c7fazs.fsf@users.sourceforge.net> <8760muu8wq.fsf@gmx.de> <874m2efpso.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1481209227 32414 195.159.176.226 (8 Dec 2016 15:00:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Dec 2016 15:00:27 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 16984@debbugs.gnu.org, jidanni@jidanni.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 08 16:00:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cF0BE-0006oi-KH for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Dec 2016 16:00:16 +0100 Original-Received: from localhost ([::1]:47111 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cF0BF-0001vq-HF for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Dec 2016 10:00:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cF0B5-0001ju-Hq for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2016 10:00:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cF0B0-0006QD-Oe for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2016 10:00:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47518) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cF0B0-0006Q7-M0 for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2016 10:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cF0B0-0000TX-A7 for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2016 10:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2016 15:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16984 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 16984-submit@debbugs.gnu.org id=B16984.14812091511738 (code B ref 16984); Thu, 08 Dec 2016 15:00:02 +0000 Original-Received: (at 16984) by debbugs.gnu.org; 8 Dec 2016 14:59:11 +0000 Original-Received: from localhost ([127.0.0.1]:34684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cF0AA-0000Ry-Oa for submit@debbugs.gnu.org; Thu, 08 Dec 2016 09:59:10 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:62491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cF0A8-0000Rj-Ku for 16984@debbugs.gnu.org; Thu, 08 Dec 2016 09:59:09 -0500 Original-Received: from detlef.gmx.de ([87.146.62.109]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LobGI-1cr54O026U-00gV2u; Thu, 08 Dec 2016 15:58:46 +0100 In-Reply-To: <874m2efpso.fsf@users.sourceforge.net> (npostavs's message of "Thu, 08 Dec 2016 09:39:35 -0500") X-Provags-ID: V03:K0:WKZZLt2efAVc4yHD7swusbOEeY4KpbsBJ0Uzhyk90RLCxyEJO+u F6fMB5sd74mnJj+i+JD078gfwIpI6n5WFyNJTnvO3DiuJfJqcxCDsMbyuWJv6QRC/hAr425 gAOJm3WrwPb90bOZq2btyVTGzZUUSHENdPst83j5iKCPwpT2HL/Mh0JJqx74DmutHQ3ATlP PSLBlT3XaaDwYqG31jrpA== X-UI-Out-Filterresults: notjunk:1;V01:K0:31lVhBEGBVM=:41fjRwpJrOdT29LQhBi5pr RQPhXV0WCJY3u/G0BD3p06RSIfF1WpOUrRZQvfT9xC8NHc0MFP36KV1fcBFgvCwlfszCj8wu1 F3NPFIGj8sH/CO4ppNAtqUBM6UVNw8Njp0KTrfMRn8096folPsUkg+x+YwBvnI4fGsFHpFB66 HCouKF0wyBLR5hGhkIbWGpYuVynmZ4EfKaZatCbOlBFrq1kiHOFGhHkftDHHizueFTsSsnyrn aWIglbaQBZcwGkY/MtygeJAAEfhk3PcfUU/sOD+gF9CZHJ/MKkOPYp8EkGitOtpwaimRS3lJv G4o+7CCUDlhsLu/IBzxCDJ3ozeRVmfm5kF8fQRrDAeQSMyf7ErHLzCYDKdxXvxeNC0m4u/YEN wBCsQsJrwHcWxwE+5wAEMb5p8BMj423GeY4cvT+D/XZliz0ThyENxwyiaJqodzZ5uZJLIlaWS jGkYkKnf7bPOAF1EX/dp9Wh69rksNYDpkgg5sMRMDUAVFU3oSIdQoCrmDfkA+tD61OA61tEeH B86LIvBZ1e5yevpH3jzFLzxZHgJ8vOnIE8457W3bZ3THpwHxYRfC532J24rfZGyhWebLbOYCR VMhy2BYfTwbUgPCTIHJnu+Lu82Z8AnHjtKh+XHPLaFO5QMCv9RNJSdU8xGmhcPK6/82nkaTGm Foado4KPOXIPYAd2GvBqa4IJgAsewSkcZhk/RjWFt+DPJQyiBR6RHI/ivRKQyxZqgmgmGyRad ky7BTXgUvSUkRNOv57yMvIdxbANXvZJNsqMrTRznCyHtueLHQ9WlrxOIHg3+HiSk6u7pLPbk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126735 Archived-At: npostavs@users.sourceforge.net writes: Hi Noam, > (let ((local (file-remote-p filename 'localname))) Well, this is (file-local-name filename) these days. > Regarding `tramp-quoted-name-p', you should use (string-match "\\`/:" > ...) or (string-prefix-p "/:" ...), not (string-match "^/:" ...) as the > latter could get confused by newlines in filenames (of the first two, I > find the `string-prefix-p' version clearer). In general you are right. But we don't support newlines in file names; at least Tramp doesn't, so it makes no difference using "^/:" or "\\`/:". `string-prefix-p' is the best choice indeed, and I thought about, but Tramp cannot apply it yet. It has been introduced in Emacs 24.1, and Tramp still supports Emacs 23. Well, NEWS.24 says that it exists already since Emacs 23.2, but there is still Emacs 23.1, which is supported by Tramp. Best regards, Michael.