unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Juri Linkov <juri@linkov.net>
Cc: 25562@debbugs.gnu.org, Antoine Levitt <antoine.levitt@gmail.com>
Subject: bug#25562: 25.1; isearch-forward-word first matches a non-word
Date: Wed, 01 Feb 2017 18:51:42 +0100	[thread overview]
Message-ID: <87tw8dztn5.fsf@drachen> (raw)
In-Reply-To: <877f5avj7r.fsf@mail.linkov.net> (Juri Linkov's message of "Wed,  01 Feb 2017 02:38:16 +0200")

Juri Linkov <juri@linkov.net> writes:

> Thanks for confirming that it would be a good solution.  We are
> already using "Pending" indication in the search prompt in other
> places to show that the search is not yet fully accepted.

Ok, then let's just do this.

> This could do the same for word search as well:
>
> diff --git a/lisp/isearch.el b/lisp/isearch.el
> index 5c48c30..3c9dff1 100644
> --- a/lisp/isearch.el
> +++ b/lisp/isearch.el
> @@ -2741,6 +2747,8 @@ (defun isearch-search-fun-default ()
>             (if isearch-forward #'re-search-forward #'re-search-backward)
>             (cond (isearch-regexp-function
>                    (let ((lax (isearch--lax-regexp-function-p)))
> +                    (when lax
> +                      (setq isearch-adjusted t))
>                      (if (functionp isearch-regexp-function)
>                          (funcall isearch-regexp-function string lax)
>                        (word-search-regexp string lax))))

I tried it.  Works as I would expect in *scratch* and dired, but hmm,
not in Info (the prompt just doesn't contain "pending" there).  I tried
with emacs -Q, and in any buffer I started a word search and just began
typing characters.


BTW, a different question: when I delete characters from my input (with
backspace) in a word search and then add some new characters, I somehow
expected that isearch would return to that "pending" state.  But I got
the jumpy (nonlax) incremental search behavior instead.  I don't have an
opinion about that, just wanted to mention it.


Regards,

Michael.





  reply	other threads:[~2017-02-01 17:51 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-28 11:23 bug#25562: 25.1; isearch-forward-word first matches a non-word Antoine Levitt
2017-01-29  0:29 ` Juri Linkov
2017-01-29  6:52   ` Antoine Levitt
2017-01-30  0:30     ` Juri Linkov
2017-01-30  8:12       ` Antoine Levitt
2017-01-30 23:24         ` Juri Linkov
2017-01-31  3:28           ` Eli Zaretskii
     [not found]             ` <CABfD5m0NxLQ5rbfXcXvxXLDK6c_88Rzsu-bwRj8gJNdh3cinSw@mail.gmail.com>
     [not found]               ` <CABfD5m1wB_z3aLsW_vOj0Vx6+1H48bUeWs46ORW0fFBUsNB0ew@mail.gmail.com>
2017-01-31  7:57                 ` Antoine Levitt
2017-01-31 15:38                   ` Eli Zaretskii
2017-02-01  0:44                     ` Juri Linkov
2017-02-09 23:28                       ` Juri Linkov
2017-02-14 23:28                         ` Juri Linkov
2017-01-31 16:45     ` Michael Heerdegen
2017-01-31 16:51   ` Michael Heerdegen
2017-02-01  0:38     ` Juri Linkov
2017-02-01 17:51       ` Michael Heerdegen [this message]
2017-02-02  0:51         ` Juri Linkov
2017-02-02 21:07           ` Michael Heerdegen
2017-02-03 11:04           ` Michael Heerdegen
2017-02-03 13:06             ` Eli Zaretskii
2017-02-03 14:16               ` Michael Heerdegen
2017-02-05 23:48                 ` Juri Linkov
2017-02-07 20:02                   ` Michael Heerdegen
2017-02-09 22:35                     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw8dztn5.fsf@drachen \
    --to=michael_heerdegen@web.de \
    --cc=25562@debbugs.gnu.org \
    --cc=antoine.levitt@gmail.com \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).