From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25777: 25.1; [PATCH] `rectangle--pos-cols' should not move point Date: Mon, 27 Feb 2017 23:57:50 -0500 Message-ID: <87tw7edi9d.fsf@users.sourceforge.net> References: <1efbacdb-7d86-454d-b0e0-7a783c47b804@default> <87poi4e7mv.fsf@users.sourceforge.net> <877f4beok7.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1488257833 8472 195.159.176.226 (28 Feb 2017 04:57:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Feb 2017 04:57:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 25777@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 28 05:57:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciZqW-0001cF-Sg for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Feb 2017 05:57:08 +0100 Original-Received: from localhost ([::1]:58613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciZqb-00031H-93 for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Feb 2017 23:57:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciZqV-000319-KC for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2017 23:57:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciZqQ-0005FU-Qn for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2017 23:57:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60730) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ciZqQ-0005FP-MS for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2017 23:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ciZqQ-00041Z-9h for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2017 23:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Feb 2017 04:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25777 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25777-submit@debbugs.gnu.org id=B25777.148825780615445 (code B ref 25777); Tue, 28 Feb 2017 04:57:02 +0000 Original-Received: (at 25777) by debbugs.gnu.org; 28 Feb 2017 04:56:46 +0000 Original-Received: from localhost ([127.0.0.1]:58929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciZqA-000413-3M for submit@debbugs.gnu.org; Mon, 27 Feb 2017 23:56:46 -0500 Original-Received: from mail-it0-f51.google.com ([209.85.214.51]:38516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciZq8-00040r-DV for 25777@debbugs.gnu.org; Mon, 27 Feb 2017 23:56:44 -0500 Original-Received: by mail-it0-f51.google.com with SMTP id y135so2466980itc.1 for <25777@debbugs.gnu.org>; Mon, 27 Feb 2017 20:56:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=18m8YJVm4Ejhf4Bo6uKNDhcLYYx+gJjLjbHDv+daLHM=; b=XLWfkgofomrYlYpTOUl9k7mW5jnI0pkCfdPmgEmWJHdK46Fq/0BvBgm2okMRDrkAHW BTsJjzVoZFpjq9Wl5R84xwsMM6YgrdBJ1yoWnQ0QtpntxsaCtAgDXwlY9U0MagyJxK+W Hucqqcur1CXhoPdvTYMfgSUMB2rDxFVSBSMp2tzoIryzB3YOuy2q7BMwu9mNOIzP0atE hhTBJ/9yP/91D0to/dE1mN0gusRkuOOIOuROMHVOZOrQAAs/jRlvaMcic55M8hxXKYTy LXPnrd/UaNeClUHVatoMD7lEdX2520aw38TUaha504lYpUcdg2nxVO7qnMilTgV4zzEu p45A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=18m8YJVm4Ejhf4Bo6uKNDhcLYYx+gJjLjbHDv+daLHM=; b=c48fuAcbqt3eiHbW1igJwn7dhVJGyfT7bn4jGHylZ+gXP+ZDEzhNFmiQBJy7tjVYZf K0030Ye4Idjwry6ubS2fMrUSvCpQ0+p7o9t5Ojd4eFVKqx2ZzSi9e9zJhSN7ajUaNfXV YBcne4+VHmOvAGIDKjCW1sHp+mjkeF1NyQW5e6oeoUnsM88WQYfqwtALhdorbLCSdwe/ rxiumfVkki71NqvAo3nkInQw+OxF62lsRhgR3m25tgmLtKo6degA7xGSTWMi4d1BzQIq FNCPEJxoRBwahA6Jekd/eHdI8jTD6kYCxVnOOGDhrtQpg7bMMeYq+SJjgijeBP1j4vp1 /6Lg== X-Gm-Message-State: AMke39l42ZHny1OI20xoU1hd14jDSqVOZz7ji2Y2Xya1ZWCMuy4yxYzhzBsbCfA4epEFSw== X-Received: by 10.36.200.9 with SMTP id w9mr18411302itf.113.1488257798816; Mon, 27 Feb 2017 20:56:38 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id p68sm428090iop.8.2017.02.27.20.56.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Feb 2017 20:56:38 -0800 (PST) In-Reply-To: (Drew Adams's message of "Mon, 27 Feb 2017 09:51:30 -0800 (PST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129923 Archived-At: Drew Adams writes: > I think it's great that a function such as `rectangle--pos-cols' > was added. (But it has no business being considered "internal".) > > Do you really think that a function whose only purpose is > to let you know what the rectangle columns are should move > point and leave it in a position that is not one of the > rectangle corners? After looking over this thread again, I conclude we got totally side-tracked on the question of whether this is a regression or not. That's just a distraction. I think it's reasonable to make rectangle--pos-cols preserve point. Could you update your patch to 1. Use a single save-excursion around the whole body, instead of adding several. 2. Rename rectangle--pos-cols to rectangle-pos-cols. 3. Add a docstring to rectangle-pos-cols.