From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Johan =?UTF-8?Q?Bockg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#27272: 25.2; [patch] Fix positional args among keyword args in eldoc. Date: Sat, 10 Jun 2017 18:15:28 +0200 Message-ID: <87tw3ng6ov.fsf@gnu.org> References: <87poegnnyn.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1497111378 17276 195.159.176.226 (10 Jun 2017 16:16:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Jun 2017 16:16:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Cc: 27272@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 10 18:16:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJj3X-0003yS-Mk for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Jun 2017 18:16:07 +0200 Original-Received: from localhost ([::1]:59022 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJj3c-00073a-Qg for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Jun 2017 12:16:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dJj3X-00073J-Dj for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2017 12:16:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dJj3S-0002vs-F8 for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2017 12:16:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36421) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dJj3S-0002vo-6I for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2017 12:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dJj3R-00033A-RG for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2017 12:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Johan =?UTF-8?Q?Bockg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2017 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27272-submit@debbugs.gnu.org id=B27272.149711133911693 (code B ref 27272); Sat, 10 Jun 2017 16:16:01 +0000 Original-Received: (at 27272) by debbugs.gnu.org; 10 Jun 2017 16:15:39 +0000 Original-Received: from localhost ([127.0.0.1]:39098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJj34-00032X-PY for submit@debbugs.gnu.org; Sat, 10 Jun 2017 12:15:38 -0400 Original-Received: from manu26.manufrog.com ([98.142.98.2]:56266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJj33-00032K-7a for 27272@debbugs.gnu.org; Sat, 10 Jun 2017 12:15:37 -0400 Original-Received: from c-5306e555.04-211-6c6b701.cust.bredbandsbolaget.se ([85.229.6.83]:40710 helo=muon.localdomain) by manu26.manufrog.com with esmtpa (Exim 4.89) (envelope-from ) id 1dJj2w-003FlO-Lz; Sat, 10 Jun 2017 18:15:30 +0200 Original-Received: by muon.localdomain (Postfix, from userid 1000) id E8D424841D3; Sat, 10 Jun 2017 18:15:28 +0200 (CEST) In-Reply-To: <87poegnnyn.fsf@gmail.com> (Thierry Volpiatto's message of "Wed, 07 Jun 2017 11:31:28 +0200") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - manu26.manufrog.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gnu.org X-Get-Message-Sender-Via: manu26.manufrog.com: authenticated_id: noreply@tryserumgardar.se X-Authenticated-Sender: manu26.manufrog.com: noreply@tryserumgardar.se X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133449 Archived-At: Thierry Volpiatto writes: > Fix eldoc with positional arg among keyword args. > > * lisp/progmodes/elisp-mode.el (elisp--highlight-function-argument): > Switch to indexed arg searching when no keyword found behind arg. This code is wrong both with and without your fix. All mandatory and optional arguments should be used *before* keywords are matched. Given this definition of `foo', (cl-defun foo (x &key a b c) (list x a b c)) `:b' in the following call specifies the positional argument `x', not the keyword argument `b': (foo :b :a 1) => (:b 1 nil nil)