From: Nicolas Richard <youngfrog@members.fsf.org>
To: 27982@debbugs.gnu.org
Subject: bug#27982: 25.1.50; expand-file-name docstring on how to traverse the filesystem
Date: Sun, 06 Aug 2017 13:38:32 +0200 [thread overview]
Message-ID: <87tw1lkjt8.fsf@members.fsf.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
The docstring of expand-file-name suggest
(directory-file-name (file-name-directory dirname))
to traverse a directory
This looks wrong to me, e.g.
(list current-directory
(directory-file-name (file-name-directory current-directory)))
=> ("/home/youngfrog/" "/home/youngfrog")
I think it should be (file-name-directory (directory-file-name dirname))
instead. Then the example becomes:
(list current-directory
(file-name-directory (directory-file-name current-directory)))
=> ("/home/youngfrog/" "/home/")
Am I overlooking something ?
Is this patch ok to commit ?
In GNU Emacs 25.1.50.1 (x86_64-pc-linux-gnu)
of 2016-11-15 built on phie-fixe
Repository revision: f994c2046588b168c1a4a900879cdffaf9d02f01
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description: Ubuntu 16.04.2 LTS
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-src-fileio.c-Fexpand_file_name-fix-suggestion-to-tra.patch --]
[-- Type: text/x-diff, Size: 959 bytes --]
From 607e1445cfb1294c14af38cb4c39a93683e5671d Mon Sep 17 00:00:00 2001
From: Nicolas Richard <youngfrog@members.fsf.org>
Date: Sun, 6 Aug 2017 13:14:41 +0200
Subject: [PATCH] * src/fileio.c (Fexpand_file_name): fix suggestion to
traverse the filesystem
---
src/fileio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/fileio.c b/src/fileio.c
index c3b2be7..28d619c 100644
--- a/src/fileio.c
+++ b/src/fileio.c
@@ -776,7 +776,7 @@ See also the function `substitute-in-file-name'.
For technical reasons, this function can return correct but
non-intuitive results for the root directory; for instance,
\(expand-file-name ".." "/") returns "/..". For this reason, use
-\(directory-file-name (file-name-directory dirname)) to traverse a
+\(file-name-directory (directory-file-name dirname)) to traverse a
filesystem tree, not (expand-file-name ".." dirname). */)
(Lisp_Object name, Lisp_Object default_directory)
{
--
2.7.4
next reply other threads:[~2017-08-06 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-06 11:38 Nicolas Richard [this message]
2017-08-06 16:53 ` bug#27982: 25.1.50; expand-file-name docstring on how to traverse the filesystem Eli Zaretskii
2017-08-23 12:18 ` Nicolas Richard
2017-08-23 17:50 ` Eli Zaretskii
2017-08-23 19:18 ` Nicolas Richard
2017-08-24 17:08 ` Eli Zaretskii
2017-08-30 15:43 ` Nicolas Richard
2017-09-02 9:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw1lkjt8.fsf@members.fsf.org \
--to=youngfrog@members.fsf.org \
--cc=27982@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).