unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 28998@debbugs.gnu.org
Subject: bug#28998: 27.0.50; Man--sections is in reverse order
Date: Mon, 06 Nov 2017 19:50:22 -0500	[thread overview]
Message-ID: <87tvy66hf5.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87zi8f18yw.fsf@gmail.com> (Basil L. Contovounesios's message of "Wed, 25 Oct 2017 17:35:35 +0100")

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> -(defsubst Man-build-section-alist ()
> +(defsubst Man-build-section-list ()

Perhaps we should switch to defun while we're at it?

> -  (let ((case-fold-search nil))
> +  (let (case-fold-search)

Personally, I like the more explicit version here.

> AFAICT there is no purpose or benefit to keeping
> Man--sections reversed, other than avoiding a call to
> nreverse, which AFAIK is quite an efficient operation.
>
> Conversely, keeping the sections in their natural order
> (i.e. from (point-min) to (point-max)) both seems more
> natural and is more convenient for users of completion
> frontends like ivy.el.

Makes sense to me.





  reply	other threads:[~2017-11-07  0:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-25 16:35 bug#28998: 27.0.50; Man--sections is in reverse order Basil L. Contovounesios
2017-11-07  0:50 ` Noam Postavsky [this message]
2017-11-07 15:07   ` Basil L. Contovounesios
2017-11-07 17:43     ` Noam Postavsky
2017-11-11 16:18       ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvy66hf5.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=28998@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).