From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alex Newsgroups: gmane.emacs.bugs Subject: bug#29150: Fwd: 26.0.90; Input decoding is sometimes skipped in TTY (xterm-mouse-mode) Date: Sun, 12 Nov 2017 02:25:22 -0600 Message-ID: <87tvxz3nv1.fsf@gmail.com> References: <87y3nka4ez.fsf@t-online.de> <87wp34a2i1.fsf@t-online.de> <83y3njs8i1.fsf@gnu.org> <878tfjnkwg.fsf@t-online.de> <834lq1p455.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1510475174 20097 195.159.176.226 (12 Nov 2017 08:26:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 12 Nov 2017 08:26:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: Olaf Rogalsky , 29150@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 12 09:26:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDnag-0004s3-00 for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 Nov 2017 09:26:06 +0100 Original-Received: from localhost ([::1]:48353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDnan-0003e4-E4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 Nov 2017 03:26:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDnaf-0003df-OR for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2017 03:26:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eDnac-0006tg-Gv for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2017 03:26:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55523) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eDnac-0006tW-CV for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2017 03:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eDnac-0007s8-3a for bug-gnu-emacs@gnu.org; Sun, 12 Nov 2017 03:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alex Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Nov 2017 08:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29150 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29150-submit@debbugs.gnu.org id=B29150.151047514530229 (code B ref 29150); Sun, 12 Nov 2017 08:26:02 +0000 Original-Received: (at 29150) by debbugs.gnu.org; 12 Nov 2017 08:25:45 +0000 Original-Received: from localhost ([127.0.0.1]:35971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDnaL-0007rV-Hy for submit@debbugs.gnu.org; Sun, 12 Nov 2017 03:25:45 -0500 Original-Received: from mail-io0-f177.google.com ([209.85.223.177]:53536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eDnaJ-0007rE-RU for 29150@debbugs.gnu.org; Sun, 12 Nov 2017 03:25:44 -0500 Original-Received: by mail-io0-f177.google.com with SMTP id 189so17595216iow.10 for <29150@debbugs.gnu.org>; Sun, 12 Nov 2017 00:25:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=xF1DhPtmof7PC2nVxv39b27LaFMZN1kyT/RbrnRYQl0=; b=oCX+JLOEhVBD5xWhEzIrtqnhORiri66sqrXWrkqER21MVYvOvnuZaKbpPs5Nmkrabj XnSLPO6lsEc6cBfYfl1YewigjJ55/ZIMoUeis6DJ0/hacqkC+8cnOOolXrbeN/AVy1lV fYRmBGqMMqL5EdiEeEOZpRG4FP6DqC1dCDFNcBmBo8AI5thKR7IDCD4lHoys22pJV2T6 YvHfcjm7LPg8Od/mm/HRgp+ft68NFnbK/kghoGvAE9PTIDUfM0ZnGXby5YykrCg8X94t 9GP/rj3+Na4301FrQg4hIt42B7m2WlokIvkhOgsEaKh6etLLWl5e+dLgBsAidG4Lwp+i JsrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=xF1DhPtmof7PC2nVxv39b27LaFMZN1kyT/RbrnRYQl0=; b=BeXRyD6cooVCXm5eRTc2qC7qfvaKMK96pzAfxc7ysb+QIteqL9RXzAOUUsHEwXV/Gs OgAOeXyQ8bM4/RZ3Ri9g1ZM7Rp7PKVy0AgASCrfxiWv2AmxlNhCUeuHSqYFgyzlE6CnD ed2t/qHlVwAvVDApW1DvQUc8xpeFtdJYkYs2lwCaaZ5kKEIVXGFtkTX0g0HCKpUs+fiH viRqpD37qNIEkxvlsG92Yxmxp6O9FSQzwRi50g3Y/xzi641vu3fmkVjFljFLog2AquPY fld1WhDbuH9CeT7FmwPwQbqKUTkzaEAZ67PG6cZzBGuLc+yKNCFLCPm/DlfHZAXz6F6W TjYQ== X-Gm-Message-State: AJaThX6nKekObUOVWH4jgP06KNliXt8j9BbL1oGA6y7ofFeffFxFzkMA FS4KbeSHKi11qeEo4enfQUM= X-Google-Smtp-Source: AGs4zMYrsHQGFh2hFJ6vMNMWlo+1jTk7mD87Duhb9YpMlYe1MKpZiSSQm+sentTKyxd4fQv2jgriCA== X-Received: by 10.107.137.163 with SMTP id t35mr6091406ioi.198.1510475138120; Sun, 12 Nov 2017 00:25:38 -0800 (PST) Original-Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id 23sm2912403itj.15.2017.11.12.00.25.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 Nov 2017 00:25:36 -0800 (PST) In-Reply-To: <834lq1p455.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 11 Nov 2017 11:15:50 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139790 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Thanks, I installed that patch on the release branch. Should it use `read-key' instead? See: https://lists.gnu.org/archive/html/emacs-devel/2017-11/msg00245.html Perhaps the patch should be replaced on the master branch with one that uses `read-key' in all cases? > Should we close this bug now, or is there anything else to do with it? The first issue is fixed, but not the second (`mouse-drag-secondary' uses `read-event'). Here's a diff for the second: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=secondary.diff Content-Description: drag-secondary diff --git a/lisp/mouse.el b/lisp/mouse.el index 5eeee1ec52..c165e1b0d2 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -1740,7 +1740,7 @@ mouse-drag-secondary (let (event end end-point) (track-mouse (while (progn - (setq event (read-event)) + (setq event (read-key)) (or (mouse-movement-p event) (memq (car-safe event) '(switch-frame select-window)))) --=-=-= Content-Type: text/plain Stefan, the above is what I meant by "is using `read-key' inside of `track-mouse' an acceptable stopgap solution?". > Btw, it seems like "C-h k" is not really working for complex mouse > clicks even without xterm-mouse-mode. For example, try this: > > C-h k C-mouse-3 > > This pops up a menu; select any item from that menu. The expected > result is to get the description of the menu item you selected, but > instead you get the prompt for "following key, mouse click, or menu > item" anew. This worked fine in Emacs 25.2, FWIW. --=-=-=--