From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#30280: async-shell-command-display-buffer doesn't work anymore Date: Sat, 03 Feb 2018 14:13:15 +0000 Message-ID: <87tvuyqhz8.fsf@tcd.ie> References: <87a7wxd1g9.fsf@mail.linkov.net> <83607kinmx.fsf@gnu.org> <877erz41re.fsf@tcd.ie> <87zi4tu2ic.fsf@mail.linkov.net> <83lggbd661.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1517667144 19102 195.159.176.226 (3 Feb 2018 14:12:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 3 Feb 2018 14:12:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Juri Linkov , 30280@debbugs.gnu.org, rrt@sc3d.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 03 15:12:19 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehyY9-0004M5-9Q for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Feb 2018 15:12:13 +0100 Original-Received: from localhost ([::1]:34233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehyaA-0001xZ-8G for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Feb 2018 09:14:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehyZy-0001us-UB for bug-gnu-emacs@gnu.org; Sat, 03 Feb 2018 09:14:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehyZu-00055S-QA for bug-gnu-emacs@gnu.org; Sat, 03 Feb 2018 09:14:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47116) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ehyZu-00055E-L8 for bug-gnu-emacs@gnu.org; Sat, 03 Feb 2018 09:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ehyZu-0002h1-Cc for bug-gnu-emacs@gnu.org; Sat, 03 Feb 2018 09:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Feb 2018 14:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30280 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30280-submit@debbugs.gnu.org id=B30280.151766720710289 (code B ref 30280); Sat, 03 Feb 2018 14:14:02 +0000 Original-Received: (at 30280) by debbugs.gnu.org; 3 Feb 2018 14:13:27 +0000 Original-Received: from localhost ([127.0.0.1]:55013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehyZK-0002ft-Nn for submit@debbugs.gnu.org; Sat, 03 Feb 2018 09:13:26 -0500 Original-Received: from mail-wm0-f41.google.com ([74.125.82.41]:35333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehyZG-0002fb-Uh for 30280@debbugs.gnu.org; Sat, 03 Feb 2018 09:13:23 -0500 Original-Received: by mail-wm0-f41.google.com with SMTP id r78so17735860wme.0 for <30280@debbugs.gnu.org>; Sat, 03 Feb 2018 06:13:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Lql5fzhLPPyByYRpvYhlFd1DdozRC3+th4qGTSgL5ao=; b=kcKJtdgzMEfJe0sx5+b+/ZmkxgcfQD0SxMvcca3js5/6agQP5wtGKFZWvumH6Hx2S7 1RGwPoJj/7IFCECm+tKw58wOrCpNlsQNqF+Jjg722FSa31rdEKNF2vKfyvj7NudzrDnR p/ngys6jHTxg/n7RKVlOiZKqyWY83EVKpx9EbEQ282cPzf5KV1/Xpd9SRlu5ad9QesYv TkIMz9sdm4XTnMDWutWXFPHwtdyRPxU4vawKZD9ddurR5bch1qYc36v8O3QNiwndhXPu Gk0FMgyJgajwwKyHIYlRMnJmvuK9EQrue+8fCChkCIrVyD1EIJzZ+KcrdG3Jp607q4bS +oXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Lql5fzhLPPyByYRpvYhlFd1DdozRC3+th4qGTSgL5ao=; b=s+b7DFrQx6bzEUwUg2AJvWfUUvVLZ/57GjeTTfZZ4uC4r8ax3XRFHgt5624DILjKTI 5gWc1nAw/XcOD/P81y1P0vIYZaBc5Aqpjc8xxZjgrKkHfaVtP9BolvsuaaWCYnpII0Ot 06a6rpL48z4f41S4Z9lqYlDmqWW7Mk+QboQ9e4vPaWpOxxxICjDIomcLrETYDaqchiMx /dmQCNHv8stylEFfiE18JyROyJzULscKlzb3ipTYgDzxpV6ZP7kbHVBEEsWchZyyS/yH oLLirYKMcFu7IPMQPvPn3JzokNdDYE89Q4Kt7VZ03HNYhWSVkc9Lpb3eTJpIlQEnRzAy cHpg== X-Gm-Message-State: AKwxytcXi0fr1GeukeQAzW1RwOls4L1hxpE9+YaPQcQvmFa6dsdYCjVR QGEZP1atqRJUCHX/WAH2+Vr95g== X-Google-Smtp-Source: AH8x225hflawqd84NjwrYshJGF7+cE9AJNYEUHURR9RLiBiEf4HcrIxiq5oELxhk+g6Y7cmgk8qaTQ== X-Received: by 10.80.213.28 with SMTP id u28mr69767942edi.224.1517667196976; Sat, 03 Feb 2018 06:13:16 -0800 (PST) Original-Received: from localhost ([2a02:8084:4f41:8c80:9c34:da08:a010:edfc]) by smtp.gmail.com with ESMTPSA id p57sm4232251edc.33.2018.02.03.06.13.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Feb 2018 06:13:16 -0800 (PST) In-Reply-To: <83lggbd661.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 2 Feb 2018 12:42:14 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142845 Archived-At: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-simple.el-async-shell-command-shell-command-Fix.patch >From b5167407b464a13968af600ac3d09f13d52e6d26 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sat, 3 Feb 2018 13:52:03 +0000 Subject: * lisp/simple.el (async-shell-command, shell-command): Fix grammar --- lisp/simple.el | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index e2deceb4c2..b7ad6ebd79 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -3351,15 +3351,15 @@ async-shell-command The output appears in the buffer `*Async Shell Command*'. That buffer is in shell mode. -You can configure `async-shell-command-buffer' to specify what to do in -case when `*Async Shell Command*' buffer is already taken by another +You can configure `async-shell-command-buffer' to specify what to do +when the `*Async Shell Command*' buffer is already taken by another running shell command. To run COMMAND without displaying the output in a window you can configure `display-buffer-alist' to use the action `display-buffer-no-window' for the buffer `*Async Shell Command*'. In Elisp, you will often be better served by calling `start-process' -directly, since it offers more control and does not impose the use of a -shell (with its need to quote arguments)." +directly, since it offers more control and does not impose the use of +a shell (with its need to quote arguments)." (interactive (list (read-shell-command "Async shell command: " nil nil @@ -3428,8 +3428,8 @@ shell-command specifies the value of ERROR-BUFFER. In Elisp, you will often be better served by calling `call-process' or -`start-process' directly, since it offers more control and does not impose -the use of a shell (with its need to quote arguments)." +`start-process' directly, since they offer more control and do not +impose the use of a shell (with its need to quote arguments)." (interactive (list -- 2.15.1 --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> Thanks, I confirm this is the right thing to do and your patch fixes >> the reported issue. > > Then please push them to the emacs-26 branch, and thanks. Perhaps I can sneak in the attached doc fixes as well. -- Basil --=-=-=--