From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Nicolas Goaziou Newsgroups: gmane.emacs.bugs Subject: bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link Date: Tue, 27 Feb 2018 01:10:48 +0100 Message-ID: <87tvu3xpfb.fsf__32415.8109528527$1519690235$gmane$org@nicolasgoaziou.fr> References: <87twh01tfu.fsf@secretsauce.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1519690235 31932 195.159.176.226 (27 Feb 2018 00:10:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Feb 2018 00:10:35 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Cc: 23745-done@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 27 01:10:30 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqSqk-0007vR-HB for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Feb 2018 01:10:30 +0100 Original-Received: from localhost ([::1]:33992 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqSsn-0002y1-0J for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Feb 2018 19:12:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqSrL-0002Fs-8Q for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 19:11:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqSrK-0000wu-GQ for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2018 19:11:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54460) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eqSrG-0000uA-4H; Mon, 26 Feb 2018 19:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eqSrF-0004Uz-V1; Mon, 26 Feb 2018 19:11:01 -0500 Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Tue, 27 Feb 2018 00:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 23745 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Mail-Followup-To: 23745@debbugs.gnu.org, mail@nicolasgoaziou.fr, dima@secretsauce.net Original-Received: via spool by 23745-done@debbugs.gnu.org id=D23745.151969025317274 (code D ref 23745); Tue, 27 Feb 2018 00:11:01 +0000 Original-Received: (at 23745-done) by debbugs.gnu.org; 27 Feb 2018 00:10:53 +0000 Original-Received: from localhost ([127.0.0.1]:34123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqSr6-0004UX-Te for submit@debbugs.gnu.org; Mon, 26 Feb 2018 19:10:53 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:60758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqSr5-0004UL-6E for 23745-done@debbugs.gnu.org; Mon, 26 Feb 2018 19:10:51 -0500 Original-Received: from saiph (00004301584731203741b516.ipv6.commingeshautdebit.fr [IPv6:2a03:a0a0:0:4301:5847:3120:3741:b516]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id DC06DA80C6; Tue, 27 Feb 2018 01:10:49 +0100 (CET) Original-Received: from ngz by saiph with local (Exim 4.89) (envelope-from ) id 1eqSr2-0004GY-4U; Tue, 27 Feb 2018 01:10:48 +0100 In-Reply-To: <87twh01tfu.fsf@secretsauce.net> (Dima Kogan's message of "Fri, 10 Jun 2016 17:05:09 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143687 Archived-At: Hello, Dima Kogan writes: > Hi. Consider this org-mode file: > > ===================== > * aaaa > bbbbb > > * cccc > [[aaaa]] > ===================== > > With the point at the [[aaaa]] link, I can visit the aaaa heading with > C-c C-o (org-open-at-point), and I can go back to where I was with the > org-specific C-c & (org-mark-ring-goto). But I should also be able to go > back with C-u C-SPC (effectively pop-to-mark-command), since that works > for inside-the-same-buffer jumps in all other emacs context, including > non-org ones. I suspect all we would need to do is to > (push-mark-command) before we jump in (org-open-at-point). Is this > simply forgotten, or was it omitted on purpose? If the former, I'll post > a patch. Fixed. Now `org-mark-ring-push' also calls `push-mark'. Ultimately, I think the latter should replace former, although navigation with Org dedicated mark ring is still slightly easier (e.g., no distinction between global and local rings). Thank you. Regards, -- Nicolas Goaziou 0x80A93738