From: phillip.lord@russet.org.uk (Phillip Lord)
To: 30745@debbugs.gnu.org
Subject: bug#30745: 26.0.91; ert should macros nest strangely
Date: Wed, 07 Mar 2018 22:24:38 +0000 [thread overview]
Message-ID: <87tvtr34nt.fsf@russet.org.uk> (raw)
In-Reply-To: <874llr4lk1.fsf@russet.org.uk> (Phillip Lord's message of "Wed, 07 Mar 2018 21:34:22 +0000")
This reproduction with a simpler test shows that the problem is nesting.
(require 'ert)
(defun simple-test ()
(ert-test-result-with-condition-condition
(ert-run-test
(make-ert-test
:body
(lambda () (should (eq 1 2)))))))
(princ (simple-test))
(princ "\nAnd forcibly unnested\n")
(princ
(let ((res (simple-test)))
(should
(equal
'(ert-test-failed
((should (eq 1 2)) :form (eq 1 2) :value nil))
res))))
(princ "\nAnd nested\n")
(princ
(should
(equal
'(ert-test-failed
((should (eq 1 2)) :form (eq 1 2) :value nil))
(simple-test))))
(princ "\n")
Emacs-25
(ert-test-failed ((should (eq 1 2)) :form (eq 1 2) :value nil))
And forcibly unnested
t
And nested
t
Emacs-26
(ert-test-failed ((should (eq 1 2)) :form (eq 1 2) :value nil))
And forcibly unnested
t
And nested
Test failed: ((should (equal (quote (ert-test-failed ((should (eq 1 2)) :form (eq 1 2) :value nil))) (simple-test))) :form (equal (ert-test-failed ((should (eq 1 2)) :form (eq 1 2) :value nil)) (((should (eq 1 2)) :form (eq 1 2) :value nil))) :value nil :explanation (proper-lists-of-different-length 2 1 (ert-test-failed ((should (eq 1 2)) :form (eq 1 2) :value nil)) (((should (eq 1 2)) :form (eq 1 2) :value nil)) first-mismatch-at 0))
next prev parent reply other threads:[~2018-03-07 22:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 21:34 bug#30745: 26.0.91; ert should macros nest strangely Phillip Lord
2018-03-07 22:24 ` Phillip Lord [this message]
2018-03-08 14:49 ` bug#24402: " Phillip Lord
2018-03-08 0:12 ` Noam Postavsky
2018-03-08 8:54 ` Phillip Lord
2018-08-15 0:47 ` Noam Postavsky
2019-06-24 18:54 ` Lars Ingebrigtsen
2019-06-24 22:53 ` Noam Postavsky
2019-06-28 3:06 ` Noam Postavsky
2020-11-29 10:35 ` Philipp Stephani
2021-07-22 13:13 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvtr34nt.fsf@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=30745@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).