From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#30823: 25.3; modification-hooks of overlays are not run in some cases Date: Thu, 23 Aug 2018 08:13:59 -0400 Message-ID: <87tvnluvp4.fsf@gmail.com> References: <83lgetri7r.fsf@gnu.org> <87in9cpd3a.fsf@gmail.com> <87in48ww9l.fsf@gmail.com> <83o9e0f9uj.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1535026390 32092 195.159.176.226 (23 Aug 2018 12:13:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 23 Aug 2018 12:13:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: victorhge@gmail.com, 30823@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 23 14:13:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsoU4-0008CG-Ch for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Aug 2018 14:13:04 +0200 Original-Received: from localhost ([::1]:36161 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsoWA-0001cc-QM for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Aug 2018 08:15:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsoW2-0001br-1E for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 08:15:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsoVy-0001nU-Po for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 08:15:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53324) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fsoVy-0001n3-JY for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 08:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fsoVy-0002L1-48 for bug-gnu-emacs@gnu.org; Thu, 23 Aug 2018 08:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Aug 2018 12:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30823-submit@debbugs.gnu.org id=B30823.15350264488896 (code B ref 30823); Thu, 23 Aug 2018 12:15:02 +0000 Original-Received: (at 30823) by debbugs.gnu.org; 23 Aug 2018 12:14:08 +0000 Original-Received: from localhost ([127.0.0.1]:58341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsoV6-0002JQ-L0 for submit@debbugs.gnu.org; Thu, 23 Aug 2018 08:14:08 -0400 Original-Received: from mail-it0-f46.google.com ([209.85.214.46]:35951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fsoV5-0002Iy-BX for 30823@debbugs.gnu.org; Thu, 23 Aug 2018 08:14:07 -0400 Original-Received: by mail-it0-f46.google.com with SMTP id p81-v6so7270005itp.1 for <30823@debbugs.gnu.org>; Thu, 23 Aug 2018 05:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Da9omGGaJr7/MEf/gGM4hb7FHtaQwnoFy1uPJHFWflk=; b=OndJGjLzOHfYjilB+VZoIpeCWL/sGdJ3g5i/XD7grC7aIsoT0SITtt5J301BN/fQBv eYPZgeldYElnpCoXZLA7LO680/J98Vb489BXpPUg3KhfiTBVdoOThk3uvWdjIMWV1DJA 2hoJvEm9fbbDHnJ57e53V5WAczoVFNpPp2OAwS9Pzq9nmzq5b+sGwZoiIgrz/PkKkmMx kwHV82RF2OdX57AvBYPjK5mcOrouTD+Uejl6Eurj+BrDYAIXbOj1AmQLDVPqiV5FJAcv ElluoDkwOJIazR4AEfuZW5zxWnUWpZ3WtIHU5mi+KGJSm3e6Dp3jWZFGif6KwMAKUNrH bW0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Da9omGGaJr7/MEf/gGM4hb7FHtaQwnoFy1uPJHFWflk=; b=NwfriAVdsMQs2qDaOobjcxgM222YF+W4//3XeFSsoq+rrjjRlmaLmNnsLIj2Lj7Y/n a+tGKuaibKMGcU5Bf15JAQOuxnqVQT594UOdkTi3qletzUetxNY8N9halcEB8NycBCce 4OpoyqhsA1hB6o8jPPTPjvnmUa4ar7ABAnPjQGmC5V25r8mFJbnYye0FIEdPKeHK4SUf 0icLbIn2SOvt79BKXq1XFbknXnEHbbKKuBrtqc816dUdEmfQZR+LOgAPpns7IFy1stvP n902vCiYHiB8i/Qp2N94Yx9jRp97R3oie6/7Os8bant6SuRVTA76fnML3g7uaAOnezJb es6Q== X-Gm-Message-State: APzg51ChvQd+WMe1F22kwbmbRNihxk2ENjCnp/iUMX5HwQSCGIFbb530 nWOLG2n+NHOZH6gNPHiHd/E= X-Google-Smtp-Source: ANB0VdYjPDGjxkmxm1mBJR5/0tEGb8X4lOn5tVV2mBhS1D9v5oDVyxvuVI4irFQ/JhYAPeHbd8RYHw== X-Received: by 2002:a24:f68c:: with SMTP id u134-v6mr6711582ith.17.1535026441672; Thu, 23 Aug 2018 05:14:01 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d134-v6sm1418567iog.84.2018.08.23.05.14.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Aug 2018 05:14:00 -0700 (PDT) In-Reply-To: <83o9e0f9uj.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Aug 2018 09:49:08 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149686 Archived-At: Eli Zaretskii writes: > Btw, I'm somewhat worried by the solution being proposed: it removes a > general safety device and replaces it by a solution that targets only > bug#21824, a much narrower class of problems. Is that wise? IMO, a safety device which causes new bugs is disqualified from its job. So yes, replacing this device with a more targeted fix seems like the Right Thing to me. Furthermore, we're currently calling the after change hooks without the before change hooks which is just asking for trouble (as exemplified by Bug#21824 and this one).