From: Juri Linkov <juri@linkov.net>
To: Drew Adams <drew.adams@oracle.com>
Cc: 32628@debbugs.gnu.org
Subject: bug#32628: 26; Rename `window-setup-hook'
Date: Fri, 07 Sep 2018 00:44:12 +0300 [thread overview]
Message-ID: <87tvn2jq2b.fsf@mail.linkov.net> (raw)
In-Reply-To: <f64aec09-21ce-45b2-bbbc-63ca58a46641@default> (Drew Adams's message of "Wed, 5 Sep 2018 22:35:51 +0000 (UTC)")
>>> > `after-set-frame-parameters-startup-hook'
>> > I'm probably OK with nearly any name that tries to suggest what this is really for.
>>
>> Looking at the existing hooks in startup.el:
>> before-init-hook
>> after-init-hook
>> emacs-startup-hook
>> term-setup-hook
>> inhibit-startup-hooks
>> window-setup-hook
>>
>> maybe a better rename for window-setup-hook would be after-init-frames-hook
>> or even after-frames-setup-hook
>
> The frame settings involved are user settings; it's not about the init frame without user settings.
>
> The latter name is OK: after-frames-setup-hook.
Actually the prefix after- implies there is its counterpart before- like in
before-init-hook and after-init-hook. So we don't need the prefix after-,
that leaves just frames-setup-hook. Is it better than window-setup-hook?
next prev parent reply other threads:[~2018-09-06 21:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 20:31 bug#32628: 26; Rename `window-setup-hook' Drew Adams
2018-09-04 21:41 ` Juri Linkov
2018-09-04 22:13 ` Drew Adams
2018-09-05 22:11 ` Juri Linkov
2018-09-05 22:35 ` Drew Adams
2018-09-06 21:44 ` Juri Linkov [this message]
2018-09-07 0:31 ` Drew Adams
2018-09-11 23:58 ` Juri Linkov
2022-01-29 15:26 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvn2jq2b.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=32628@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).