From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#32975: Emacs 26.1; GTK Warnings Date: Thu, 11 Oct 2018 09:35:57 +0200 Message-ID: <87tvltylya.fsf@gmail.com> References: <1538936366.8755.2.camel@tjernlund.se> <83zhvpzihx.fsf@gnu.org> <1538976428.8755.6.camel@tjernlund.se> <837eiryx33.fsf@gnu.org> <1539108072.8755.7.camel@tjernlund.se> <83zhvnx9ua.fsf@gnu.org> <1539110025.8755.10.camel@tjernlund.se> <83va6bx7a3.fsf@gnu.org> <87d0si1b41.fsf@gmail.com> <5BBDBC75.2010605@gmx.at> <875zya15cm.fsf@gmail.com> <1539193453.8755.14.camel@tjernlund.se> <871s8x0zgw.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1539243315 7255 195.159.176.226 (11 Oct 2018 07:35:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 Oct 2018 07:35:15 +0000 (UTC) Cc: 32975@debbugs.gnu.org To: Tjernlund Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 11 09:35:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAVV0-0001n9-A8 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Oct 2018 09:35:10 +0200 Original-Received: from localhost ([::1]:60962 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAVX6-0002Tu-J5 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Oct 2018 03:37:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gAVWu-0002Sp-0o for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2018 03:37:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gAVWo-00070m-0u for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2018 03:37:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39847) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gAVWn-00070a-SB for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2018 03:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gAVWn-0006Lx-L3 for bug-gnu-emacs@gnu.org; Thu, 11 Oct 2018 03:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Oct 2018 07:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32975-submit@debbugs.gnu.org id=B32975.153924337024361 (code B ref 32975); Thu, 11 Oct 2018 07:37:01 +0000 Original-Received: (at 32975) by debbugs.gnu.org; 11 Oct 2018 07:36:10 +0000 Original-Received: from localhost ([127.0.0.1]:44105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAVVx-0006Kr-Na for submit@debbugs.gnu.org; Thu, 11 Oct 2018 03:36:09 -0400 Original-Received: from mail-wr1-f65.google.com ([209.85.221.65]:38547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gAVVt-0006KL-PV for 32975@debbugs.gnu.org; Thu, 11 Oct 2018 03:36:06 -0400 Original-Received: by mail-wr1-f65.google.com with SMTP id a13-v6so8450766wrt.5 for <32975@debbugs.gnu.org>; Thu, 11 Oct 2018 00:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=3YtCvceO2bupVZjwemOHAt1b+SRnztTluLXDaCNTwsM=; b=hYHwXENRkMBCUdzeXXXrvP5L/TTRNFLU+n2ElQfF2GsX+ZJGdigIsIPxzJcDDbffS1 3FZlx6L7WpJoQC+WGa4ujhVMe+UHe9wnBlW5TleZDxPOA6k9GAVy6RShIYRyptBp7jeV IwHgHFHjoWdHdRo8hCxvShHOeyqwYL9Ifltqm2nQLJH3YGvswFUlL9CLsB4g7HpaI+in Su0lv9wTmxnZIZ6cxRjLurHxDZ/i4yH780VrBDSDZg8t8ewK7kdSEqiLQRsZnP+LWgsk Sir3dZoouJstn098RHk5RwLNAFRhs8iUwGGLBvqGM+vI290q24wMRXCKVjR2JUEz9hHN IBlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=3YtCvceO2bupVZjwemOHAt1b+SRnztTluLXDaCNTwsM=; b=tfuTnG3YW3Aecx4wC6Qug5hMJefuldesfizsVX++ugqDuxdrja273dRNeqaU6UxkPp +aypDqv70j49KweMjfjX8shu7gANDDXWe3onB3a+iFXomzbwCgzCqzIox5II9VpiiTS8 IHxjbRHf/ykJF/4Ob2Ifg0BgLodzjXnM+IB/KazAlVFuhK6qxKlqCpHT3/tbk4bwitv8 zDkJdfQiVa8p1m15yWk0hiXcPCNHFIuu3sai7BttiPQtt4PnG+LiIlunyxXQAu4bzTK2 kZpMH1i2P0tRWLZ99icmTJR4/KZ32iI2u4u38AZu8PV+twRm+DCKpTWRAijJG2sPG2dI uG3w== X-Gm-Message-State: ABuFfojA0dvf/CLlC31wW8v2GspCGyLTOOF04J7bBdskewfeVhRAYocn k5Ahh+OTxTyCIMhK6Hw9KPA= X-Google-Smtp-Source: ACcGV60BT0CfZhmHxxQkUh0C8UB5Vqim0qKg6L/RIAnpVgBRF0OVNaLTle2QR93ZA3OHDGCqTA1HZQ== X-Received: by 2002:adf:f301:: with SMTP id i1-v6mr430699wro.161.1539243359761; Thu, 11 Oct 2018 00:35:59 -0700 (PDT) Original-Received: from rpluim-ubuntu (cust-west-pareq2-46-193-13-178.wb.wifirst.net. [46.193.13.178]) by smtp.gmail.com with ESMTPSA id n15-v6sm15276282wrm.27.2018.10.11.00.35.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Oct 2018 00:35:58 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <871s8x0zgw.fsf@gmail.com> (Robert Pluim's message of "Thu, 11 Oct 2018 08:27:59 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151097 Archived-At: Robert Pluim writes: > Tjernlund writes: > >> X11 >> >> I now did some more test and found that (require 'ecb) is also needed. > > With that I can reproduce it. '--without-toolkit-scroll-bars' is > required, which narrows down the potential source a lot. > So I don=CA=BCt think we should be calling GTK functions on scrollbars that are not GTK widgets (I=CA=BCm stunned we've never seen this before). This fixes it for me. Martin? diff --git a/src/xfns.c b/src/xfns.c index 1381fee57e..4fad01a68e 100644 --- a/src/xfns.c +++ b/src/xfns.c @@ -1085,12 +1085,13 @@ x_set_background_color (struct frame *f, Lisp_Objec= t arg, Lisp_Object oldval) XSetWindowBackground (dpy, FRAME_X_WINDOW (f), bg); XSetForeground (dpy, x->cursor_gc, bg); =20 -#ifdef USE_GTK +#ifdef USE_TOOLKIT_SCROLL_BARS +# ifdef USE_GTK xg_set_background_color (f, bg); -#endif - -#ifndef USE_TOOLKIT_SCROLL_BARS /* Turns out to be annoying with - toolkit scroll bars. */ +# endif +#else +/* Turns out to be annoying with toolkit scroll bars, so only set the + background for non-toolkit. */ { Lisp_Object bar; for (bar =3D FRAME_SCROLL_BARS (f);