From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jules Tamagnan Newsgroups: gmane.emacs.bugs Subject: bug#33195: 27.0.50; user-login-name has no group-login-name Date: Tue, 30 Oct 2018 11:28:16 -0700 Message-ID: <87tvl3cmrj.fsf@gmail.com> References: <87d0rsegbi.fsf@gmail.com> <837ehzlo3a.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1540924028 7381 195.159.176.226 (30 Oct 2018 18:27:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Oct 2018 18:27:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 33195@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 30 19:27:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHYjG-0001m0-58 for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Oct 2018 19:27:02 +0100 Original-Received: from localhost ([::1]:54933 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHYlM-0004so-FS for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Oct 2018 14:29:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHYlG-0004sh-3O for bug-gnu-emacs@gnu.org; Tue, 30 Oct 2018 14:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHYlC-0006Q8-2A for bug-gnu-emacs@gnu.org; Tue, 30 Oct 2018 14:29:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51656) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHYlB-0006Q2-TK for bug-gnu-emacs@gnu.org; Tue, 30 Oct 2018 14:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gHYlB-0004U8-Lc for bug-gnu-emacs@gnu.org; Tue, 30 Oct 2018 14:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jules Tamagnan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Oct 2018 18:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33195 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33195-submit@debbugs.gnu.org id=B33195.154092410617196 (code B ref 33195); Tue, 30 Oct 2018 18:29:01 +0000 Original-Received: (at 33195) by debbugs.gnu.org; 30 Oct 2018 18:28:26 +0000 Original-Received: from localhost ([127.0.0.1]:55914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHYkc-0004TH-1n for submit@debbugs.gnu.org; Tue, 30 Oct 2018 14:28:26 -0400 Original-Received: from mail-pl1-f179.google.com ([209.85.214.179]:32995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHYka-0004T3-JS for 33195@debbugs.gnu.org; Tue, 30 Oct 2018 14:28:24 -0400 Original-Received: by mail-pl1-f179.google.com with SMTP id x6-v6so5977245pln.0 for <33195@debbugs.gnu.org>; Tue, 30 Oct 2018 11:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ejgdAKKL2yUF0tpqSh02Ke1SJJGyO9UBX22q8gxOyLU=; b=HTAJ2wmO4LVYvKGa1kr4X3n01Cy1Al4DK4hKwt9zDwUULGOmNTxH+g2M9TyZDW+Luw 4lfL1e/nCIhFlyA5Kq7AuAO3vOghaVkRf5axp6wZLo5HE39MnCqheJSDOBKbfphd992S 9/AzI78fe140LoWtEjDaRS/voY/CBa322l4/regwIHUEdztyoxyVW+u3mFKl9DYNVgvm +2fUhPHnw7DvEq62hph6HFQo/ms1sgZMMhnf9APGR51p8ncu13/1IKv/LWN0bnFZwvVN PJG+Z+MmY19400l6E70HrYF/r1uYO0EIxXB+5v6Est30e6O4r767bSYvU6Lf7FSWrMhh B8Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ejgdAKKL2yUF0tpqSh02Ke1SJJGyO9UBX22q8gxOyLU=; b=ZKFLMEgCfdykG2tKUH+LE3gywTs0FeHxj0nKp29xbxJx6fdhTV3Xf96Rr03sFQgbfI qd9PPeNqwK/slSMf6vgI9gjFDAsDy4sdcd74c0nmow4LFoNK+b0o80DS5kYjE0uzNems 8+mB3+lDmzs33MFvxphSXjtDGftl19gRfpv0SygieL8JFWZw9wC0ozN17HJkdLuuVlLd AsvnRAPE0cSy6kZwz2NLleVYcmHANwbfkuPYyWyDyrPsfH+v7hn8Rr8vj+LOFyIZZjUS rLr0qe9Khm2JvM56hXCRooqjtxJOIg3VOvgdwNLDzzz6UaLXLh0ayGPH9Vygws9aEg4Y AQ7w== X-Gm-Message-State: AGRZ1gLA5d1EcS/Rlo4YrSDmswqdD8F2wAKoZNq+8JIeEauJHFEdPi/r sh0xHAKOJuEgrrIur674sOz66781 X-Google-Smtp-Source: AJdET5ehqQ/CypeWAR5IHKCPDryql2XhXpx0UDVDeUucXdxqPWuqtDgxCC7elcJGbtL0z56Z7bcN3w== X-Received: by 2002:a17:902:5a42:: with SMTP id f2-v6mr5748923plm.324.1540924098409; Tue, 30 Oct 2018 11:28:18 -0700 (PDT) Original-Received: from jat-delphix-lap (DELPHIX-COR.ear2.SanJose1.Level3.net. [4.16.207.62]) by smtp.gmail.com with ESMTPSA id q26-v6sm31558618pfi.165.2018.10.30.11.28.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Oct 2018 11:28:17 -0700 (PDT) In-Reply-To: <837ehzlo3a.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 Oct 2018 12:34:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151842 Archived-At: --=-=-= Content-Type: text/plain I noticed that I had marked GID as optional in the manual, below is a patch with that fixed. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-src-editfns.c-group-name-New-function.patch Content-Description: Patch-2 >From 5c67d0177ba14428e6e3f5acdaf34c2be7ee93be Mon Sep 17 00:00:00 2001 From: Jules Tamagnan Date: Tue, 30 Oct 2018 10:22:03 -0700 Subject: [PATCH] src/editfns.c (group-name): New function. --- doc/lispref/os.texi | 5 +++++ etc/NEWS | 3 +++ src/editfns.c | 16 ++++++++++++++++ test/src/editfns-tests.el | 7 +++++++ 4 files changed, 31 insertions(+) diff --git a/doc/lispref/os.texi b/doc/lispref/os.texi index cb33757..6d1b3f3 100644 --- a/doc/lispref/os.texi +++ b/doc/lispref/os.texi @@ -1230,6 +1230,11 @@ User Identification return value is @code{nil}. @end defun +@defun user-login-name gid +This runction returns the group name that corresponds to @var{gid}, +or @code{nil} if there is no such group. +@end defun + @node Time of Day @section Time of Day diff --git a/etc/NEWS b/etc/NEWS index 226ae1e..a0bcbb5 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1228,6 +1228,9 @@ where there's no better alternative. We believe that the incorrect uses of this function all but disappeared by now, so we are un-obsoleting it. ++++ +** New function 'group-name' returns a group name based on a group-GID + * Changes in Emacs 27.1 on Non-Free Operating Systems diff --git a/src/editfns.c b/src/editfns.c index e995b38..15a0fa7 100644 --- a/src/editfns.c +++ b/src/editfns.c @@ -1143,6 +1143,21 @@ of the user with that uid, or nil if there is no such user. */) return (pw ? build_string (pw->pw_name) : Qnil); } +DEFUN ("group-name", Fgroup_name, Sgroup_name, 1, 1, 0, + doc: /* If argument GID is an integer or a float, return the login name +of the group with that gid, or nil if there is no such GID. */) + (Lisp_Object gid) +{ + struct group *gr; + gid_t id; + + CONS_TO_INTEGER (gid, gid_t, id); + block_input (); + gr = getgrgid (id); + unblock_input (); + return (gr ? build_string (gr->gr_name) : Qnil); +} + DEFUN ("user-real-login-name", Fuser_real_login_name, Suser_real_login_name, 0, 0, 0, doc: /* Return the name of the user's real uid, as a string. @@ -4487,6 +4502,7 @@ it to be non-nil. */); defsubr (&Sinsert_byte); defsubr (&Suser_login_name); + defsubr (&Sgroup_name); defsubr (&Suser_real_login_name); defsubr (&Suser_uid); defsubr (&Suser_real_uid); diff --git a/test/src/editfns-tests.el b/test/src/editfns-tests.el index 17b2c51..6ee0ab0 100644 --- a/test/src/editfns-tests.el +++ b/test/src/editfns-tests.el @@ -351,4 +351,11 @@ transpose-test-get-byte-positions (should (equal (format "%-#50.40x" v3) "-0x000000003ffffffffffffffe000000000000000 ")))) +(ert-deftest group-name () + (let ((list `((0 . "root") + (1000 . ,(user-login-name 1000)) + (1212345 . nil)))) + (dolist (test list) + (should (equal (group-name (car test)) (cdr test)))))) + ;;; editfns-tests.el ends here -- 2.7.4 --=-=-=--